triacontakai 3f5c113394 Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer (#37646) ...

Fixes a bug that allowed for selecting the same mod twice in multiplayer
if the playlist entry has non-default settings for a required mod.
This happens due to a strict equality mod check in the mod set
compatibility check function, which only considers mods duplicates if
their settings are exactly the same. Replacing with a more lenient
`Type` check fixes this.

Adds a regression test for this behavior

Fixes https://github.com/ppy/osu/issues/37625.

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

3f5c113394 · 2026-05-07 08:59:54 +02:00

History

..

Audio

…

Beatmaps

Fix lack of encode-decode stability when writing out mania beatmaps with some key counts (#37256)

2026-04-11 00:38:22 +09:00

Chat

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

Collections/IO

Automated pass

2023-06-24 01:00:03 +09:00

Database

Turn tests green, for a short while, maybe (#37218)

2026-04-06 17:59:39 +09:00

Editing

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

Extensions

Always use current culture in ToStandardFormattedString()

2025-10-24 08:26:01 +02:00

Gameplay

Tooling updates (#37031)

2026-03-19 00:05:52 +09:00

Input

Rename enum to non-plural now that it won't conflict

2024-10-01 19:55:46 +09:00

IPC

Implement WebSocket server skeleton for external integrations (#37335)

2026-04-21 18:25:12 +09:00

Localisation

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

Models

Make ScoreInfo.BeatmapInfo nullable

2023-07-04 14:50:34 +09:00

Mods

Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer (#37646)

2026-05-07 08:59:54 +02:00

NonVisual

Fix failing test

2026-04-17 17:06:24 +09:00

Online

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

OnlinePlay

Add RNG seed

2025-03-18 16:24:01 +09:00

Resources

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

Rulesets

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

Scores/IO

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

ScrollAlgorithms

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

Skins

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

Testing

Add missing ruleset shader tests

2023-05-02 11:55:05 +03:00

Utils

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

Visual

Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer (#37646)

2026-05-07 08:59:54 +02:00

CodeAnalysis.tests.globalconfig

Convert legacy ruleset to globalconfig

2024-11-28 19:34:56 +08:00

ImportTest.cs

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

osu.Game.Tests.csproj

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

WaveformTestBeatmap.cs

Remove another similar finaliser

2025-06-03 20:48:36 +09:00