1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 02:43:19 +08:00
osu-lazer/osu.Game.Tests/Beatmaps
Bartłomiej Dach 15feb17da8
Change difficulty cache storage type to nullable
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
..
Formats Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
IO Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
SliderEventGenerationTest.cs Remove redundant arguments 2021-07-05 23:52:39 +08:00
TestSceneBeatmapDifficultyCache.cs Change difficulty cache storage type to nullable 2021-11-20 17:00:50 +01:00
TestSceneEditorBeatmap.cs Add back inadvertently removed spacing 2020-09-14 17:52:59 +09:00
ToStringFormattingTest.cs Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
WorkingBeatmapTest.cs Add test coverage for ruleset load failure scenario 2021-11-17 22:10:45 +01:00