mirror of
https://github.com/ppy/osu.git
synced 2026-05-17 04:32:35 +08:00
Bartłomiej Dach
89c48451cd
The replay stability tests needed adjustments because hit windows have been materially changed with the previous commit. What matters in the replay stability tests is covering the time instants near the hit window edges and ensuring that re-encode doesn't mutate the resulting judgements, not what the particular numbers used are.
141 lines
6.1 KiB
C#
141 lines
6.1 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using NUnit.Framework;
|
|
using osu.Game.Beatmaps;
|
|
using osu.Game.Replays;
|
|
using osu.Game.Rulesets.Mania.Beatmaps;
|
|
using osu.Game.Rulesets.Mania.Objects;
|
|
using osu.Game.Rulesets.Mania.Replays;
|
|
using osu.Game.Rulesets.Scoring;
|
|
using osu.Game.Tests.Visual;
|
|
|
|
namespace osu.Game.Rulesets.Mania.Tests
|
|
{
|
|
public partial class TestSceneReplayStability : ReplayStabilityTestScene
|
|
{
|
|
private static readonly object[][] test_cases =
|
|
{
|
|
// With respect to notation,
|
|
// square brackets `[]` represent *closed* or *inclusive* bounds,
|
|
// while round brackets `()` represent *open* or *exclusive* bounds.
|
|
|
|
// OD = 5 test cases.
|
|
// PERFECT hit window is [ -19.5ms, 19.5ms]
|
|
// GREAT hit window is [ -49.5ms, 49.5ms]
|
|
// GOOD hit window is [ -82.5ms, 82.5ms]
|
|
// OK hit window is [-112.5ms, 112.5ms]
|
|
// MEH hit window is [-136.5ms, 136.5ms]
|
|
// MISS hit window is [-173.5ms, 173.5ms]
|
|
new object[] { 5f, -19d, HitResult.Perfect },
|
|
new object[] { 5f, -19.2d, HitResult.Perfect },
|
|
new object[] { 5f, -19.7d, HitResult.Great },
|
|
new object[] { 5f, -20d, HitResult.Great },
|
|
new object[] { 5f, -48d, HitResult.Great },
|
|
new object[] { 5f, -48.4d, HitResult.Great },
|
|
new object[] { 5f, -48.7d, HitResult.Great },
|
|
new object[] { 5f, -49d, HitResult.Great },
|
|
new object[] { 5f, -49.2d, HitResult.Great },
|
|
new object[] { 5f, -49.7d, HitResult.Good },
|
|
new object[] { 5f, -50d, HitResult.Good },
|
|
new object[] { 5f, -81d, HitResult.Good },
|
|
new object[] { 5f, -81.2d, HitResult.Good },
|
|
new object[] { 5f, -81.7d, HitResult.Good },
|
|
new object[] { 5f, -82d, HitResult.Good },
|
|
new object[] { 5f, -82.2d, HitResult.Good },
|
|
new object[] { 5f, -82.7d, HitResult.Ok },
|
|
new object[] { 5f, -83d, HitResult.Ok },
|
|
new object[] { 5f, -111d, HitResult.Ok },
|
|
new object[] { 5f, -111.2d, HitResult.Ok },
|
|
new object[] { 5f, -111.7d, HitResult.Ok },
|
|
new object[] { 5f, -112d, HitResult.Ok },
|
|
new object[] { 5f, -112.2d, HitResult.Ok },
|
|
new object[] { 5f, -112.7d, HitResult.Meh },
|
|
new object[] { 5f, -113d, HitResult.Meh },
|
|
new object[] { 5f, -135d, HitResult.Meh },
|
|
new object[] { 5f, -135.2d, HitResult.Meh },
|
|
new object[] { 5f, -135.8d, HitResult.Meh },
|
|
new object[] { 5f, -136d, HitResult.Meh },
|
|
new object[] { 5f, -136.2d, HitResult.Meh },
|
|
new object[] { 5f, -136.7d, HitResult.Miss },
|
|
new object[] { 5f, -137d, HitResult.Miss },
|
|
|
|
// OD = 9.3 test cases.
|
|
// PERFECT hit window is [ -14.5ms, 14.5ms]
|
|
// GREAT hit window is [ -36.5ms, 36.5ms]
|
|
// GOOD hit window is [ -69.5ms, 69.5ms]
|
|
// OK hit window is [ -99.5ms, 99.5ms]
|
|
// MEH hit window is [-123.5ms, 123.5ms]
|
|
// MISS hit window is [-160.5ms, 160.5ms]
|
|
new object[] { 9.3f, 14d, HitResult.Perfect },
|
|
new object[] { 9.3f, 14.2d, HitResult.Perfect },
|
|
new object[] { 9.3f, 14.7d, HitResult.Great },
|
|
new object[] { 9.3f, 15d, HitResult.Great },
|
|
new object[] { 9.3f, 35d, HitResult.Great },
|
|
new object[] { 9.3f, 35.3d, HitResult.Great },
|
|
new object[] { 9.3f, 35.8d, HitResult.Great },
|
|
new object[] { 9.3f, 36.3d, HitResult.Great },
|
|
new object[] { 9.3f, 36.7d, HitResult.Good },
|
|
new object[] { 9.3f, 37d, HitResult.Good },
|
|
new object[] { 9.3f, 68d, HitResult.Good },
|
|
new object[] { 9.3f, 68.4d, HitResult.Good },
|
|
new object[] { 9.3f, 68.9d, HitResult.Good },
|
|
new object[] { 9.3f, 69.25d, HitResult.Good },
|
|
new object[] { 9.3f, 69.85d, HitResult.Ok },
|
|
new object[] { 9.3f, 70d, HitResult.Ok },
|
|
new object[] { 9.3f, 98d, HitResult.Ok },
|
|
new object[] { 9.3f, 98.3d, HitResult.Ok },
|
|
new object[] { 9.3f, 98.6d, HitResult.Ok },
|
|
new object[] { 9.3f, 99d, HitResult.Ok },
|
|
new object[] { 9.3f, 99.3d, HitResult.Ok },
|
|
new object[] { 9.3f, 99.7d, HitResult.Meh },
|
|
new object[] { 9.3f, 100d, HitResult.Meh },
|
|
new object[] { 9.3f, 122d, HitResult.Meh },
|
|
new object[] { 9.3f, 122.34d, HitResult.Meh },
|
|
new object[] { 9.3f, 122.57d, HitResult.Meh },
|
|
new object[] { 9.3f, 123.45d, HitResult.Meh },
|
|
new object[] { 9.3f, 123.95d, HitResult.Miss },
|
|
new object[] { 9.3f, 124d, HitResult.Miss },
|
|
};
|
|
|
|
[TestCaseSource(nameof(test_cases))]
|
|
public void TestHitWindowStability(float overallDifficulty, double hitOffset, HitResult expectedResult)
|
|
{
|
|
const double note_time = 300;
|
|
|
|
var beatmap = new ManiaBeatmap(new StageDefinition(1))
|
|
{
|
|
HitObjects =
|
|
{
|
|
new Note
|
|
{
|
|
StartTime = note_time,
|
|
Column = 0,
|
|
}
|
|
},
|
|
Difficulty = new BeatmapDifficulty
|
|
{
|
|
OverallDifficulty = overallDifficulty,
|
|
CircleSize = 1,
|
|
},
|
|
BeatmapInfo =
|
|
{
|
|
Ruleset = new ManiaRuleset().RulesetInfo,
|
|
},
|
|
};
|
|
|
|
var replay = new Replay
|
|
{
|
|
Frames =
|
|
{
|
|
new ManiaReplayFrame(0),
|
|
new ManiaReplayFrame(note_time + hitOffset, ManiaAction.Key1),
|
|
new ManiaReplayFrame(note_time + hitOffset + 20),
|
|
}
|
|
};
|
|
|
|
RunTest(beatmap, replay, [expectedResult]);
|
|
}
|
|
}
|
|
}
|