mirror of
https://github.com/ppy/osu.git
synced 2024-11-13 16:47:46 +08:00
03a279a48d
Something I ran into when investigating https://github.com/ppy/osu/issues/28169. If there are two scores with the same online ID available in the database - for instance, one being recorded locally, and one recorded by spectator server, of one single play - the lookup code would use online ID first to find the score and pick any first one that matched. This could lead to the wrong replay being refetched and presented / exported. (In the case of the aforementioned issue, I was confused as to whether after restarting spectator server midway through a play and importing the replay saved by spectator server after the restart, I was seeing a complete replay with no dropped frames, even though there was nothing in the code that prevented the frame drop. It turns out that I was getting presented the locally recorded replay instead all along.) Instead, jiggle the fallback preference to use hash first. |
||
---|---|---|
.. | ||
Legacy | ||
HitResultDisplayStatistic.cs | ||
IScoreInfo.cs | ||
LegacyDatabasedScore.cs | ||
RankingTier.cs | ||
Score.cs | ||
ScoreImporter.cs | ||
ScoreInfo.cs | ||
ScoreInfoExtensions.cs | ||
ScoreManager.cs | ||
ScoreModelDownloader.cs | ||
ScoreRank.cs |