3497 Commits

• Add GetMatchmakingPools server method
  Dan Balasescu · 2025-09-05 14:40:58 +09:00
  4475bcafa9
• Replace MatchmakingSettings with MatchmakingPool
  Dan Balasescu · 2025-09-05 14:40:48 +09:00
  32576ff249
• Add variant to MatchmakingSettings
  Dean Herbert · 2025-09-04 18:43:46 +09:00
  1627f67ada
• Add matchmaking model types required for server-side deploy
  Dan Balasescu · 2025-09-04 18:26:56 +09:00
  815bf9c37b
• Merge pull request #34819 from smoogipoo/fix-room-event-loss

  Fix potential loss of room events during join

  Dean Herbert · 2025-09-03 02:20:43 +09:00
  c29217240e
• Eagerly clear the request queue on join
  Dan Balasescu · 2025-09-02 17:57:15 +09:00
  1519084f72
• Configure await calls
  Dan Balasescu · 2025-08-28 13:47:55 +09:00
  9ae6e509b7
• Fix potential loss of room events during join
  Dan Balasescu · 2025-08-28 13:20:02 +09:00
  b95573f97d
• Show pinned rooms on top of listing
  Bartłomiej Dach · 2025-08-21 14:18:13 +02:00
  a6f823e5bc
• Fix incorrect rank animation when beatmap panels retrieved from pool

  Rank animation is played for new panels when scrolling down, showing the
  previous rank belonging to the previous beatmap assigned to that
  specific panel instance.

  Salman Alshamrani · 2025-08-11 19:21:22 +03:00
  522f94277b
• Always use MessagePack to talk to spectator server
  Dan Balasescu · 2025-08-06 16:36:33 +09:00
  d0e9fda874
• Assert that FetchWithCriteria is called from the update thread
  Salman Alshamrani · 2025-08-04 17:01:27 +09:00
  c09f40a8cf
• Fix missing disposal of Realm subscription
  Dan Balasescu · 2025-08-03 01:46:04 +09:00
  4e5dfb82ca
• Adjust truncation and formatting to feel better
  Dean Herbert · 2025-07-29 15:41:43 +09:00
  898e051501
• Update design once more
  Salman Alshamrani · 2025-07-29 14:35:25 +09:00
  35a7588c3d
• Update message notification design to match web
  Salman Alshamrani · 2025-07-29 14:35:25 +09:00
  fa7ecc0d28
• Display user avatar in friend presence notifications
  Salman Alshamrani · 2025-07-29 14:35:24 +09:00
  2a7ec60cc8
• Display user avatar and content in DM / mention notifications
  Salman Alshamrani · 2025-07-29 14:35:24 +09:00
  d796dee6fc
• Apply minor refactor to notification classes to be more flexible in usages
  Salman Alshamrani · 2025-07-29 14:35:24 +09:00
  c2ace36348
• Move exception in better place (and also throw it better)
  Bartłomiej Dach · 2025-07-28 11:33:59 +02:00
  99f9a3b1f4
• Merge branch 'master' into local-score-sorting-v2
  Bartłomiej Dach · 2025-07-28 11:32:59 +02:00
  c620d58bc2
• Store pause timestamps (rounded to ms) instead of general count
  Bartłomiej Dach · 2025-07-22 09:26:12 +02:00
  d8900defd3
• Merge branch 'master' into store-pause-count
  Bartłomiej Dach · 2025-07-22 08:44:16 +02:00
  b08ba3c9e4
• Add one more missing FireAndForget call

  ```csharp
  2025-07-17 08:52:06 [error]: An unobserved error has occurred.
  2025-07-17 08:52:06 [error]: System.TimeoutException: Server timeout
  (30000.00ms) elapsed without receiving a message from the server.
  2025-07-17 08:52:06 [error]: at
  Microsoft.AspNetCore.SignalR.Client.HubConnection.InvokeCoreAsync(String
  methodName, Type returnType, Object[] args, CancellationToken
  cancellationToken)
  2025-07-17 08:52:06 [error]: at
  Microsoft.AspNetCore.SignalR.Client.HubConnection.InvokeCoreAsyncCore(String
  methodName, Type returnType, Object[] args, CancellationToken
  cancellationToken)
  2025-07-17 08:52:06 [error]: at
  Microsoft.AspNetCore.SignalR.Client.HubConnection.InvokeCoreAsync(String
  methodName, Type returnType, Object[] args, CancellationToken
  cancellationToken)
  2025-07-17 08:52:06 [error]: at
  Microsoft.AspNetCore.SignalR.Client.HubConnectionExtensions.InvokeCoreAsync[TResult](HubConnection
  hubConnection, String methodName, Object[] args, CancellationToken
  cancellationToken)
  2025-07-17 08:52:06 [error]: at
  osu.Game.Online.Metadata.OnlineMetadataClient.<isConnectedChanged>b__31_1()
  ```

  Dean Herbert · 2025-07-18 16:24:17 +09:00
  f50323460f
• Adjust behavior of beatmap set with deleted author
  eyhn · 2025-07-14 20:58:03 +08:00
  3eca3897ed
• Use comment instead of xmldoc
  Dan Balasescu · 2025-07-14 16:04:43 +09:00
  64f6fce918
• Fix typo
  eyhn · 2025-07-12 23:35:54 +08:00
  2b26506c4c
• Fix failed to load beatmaps host by deleted user
  eyhn · 2025-07-12 21:51:10 +08:00
  39808970d3
• Fix leaks from directly binding API bindable events
  Dan Balasescu · 2025-07-09 03:37:02 +09:00
  cce09ceadb
• Fix leak from polling chat client being initialised too early

  This one is quite dumb.
  
  `OsuGame` uses
  [`loadComponentSingleFile`](https://github.com/ppy/osu/blob/15878f7f9fc7088494d3b66e98a7bc1004a1a06d/osu.Game/OsuGame.cs#L1228)
  to load the `ChannelManager`. Importantly, this process does _not_ add
  the component to any place in the hierarchy where it would normally be
  disposed - this includes `InternalChildren`, but _also_ a lesser known
  list of [currently-loading
  components](https://github.com/ppy/osu-framework/blob/cfb0d7b4b673583f0cf56273e94352769aa5bc9a/osu.Framework/Graphics/Containers/CompositeDrawable.cs#L316-L323)
  (those which have been sent through a `LoadComponentAsync` call).
  
  The end result of this is that, `ChannelManager` creates the
  `IChatClient` in its constructor, expecting to be able to dispose it,
  but `Dispose` is never called!
  
  And the failure case here is that `PollingChatClient` creates a
  background task to continuously poll the API, unfortunately keeping a
  reference to the rest of the world in the process.

  Dan Balasescu · 2025-07-09 03:37:02 +09:00
  02cb93d854
• Fix leak from inverted event unbind
  Dan Balasescu · 2025-07-08 00:23:35 +09:00
  8298374e59
• Pass along pause count when submitting score
  Bartłomiej Dach · 2025-07-07 11:00:31 +02:00
  4cdbe7e195
• Update resources
  Dean Herbert · 2025-07-07 15:17:21 +09:00
  65cc89a64d
• Make sure you can't request non-local scores with a sort mode other than score.
  Dani211e · 2025-06-27 04:46:49 +02:00
  abfd4f6338
• RankingsSort -> LeaderboardSortMode
  Dani211e · 2025-06-26 19:03:49 +02:00
  c1a34d8c6a
• Move room URL formatting to extension method
  Salman Alshamrani · 2025-06-26 02:56:43 +03:00
  75a3cdcfe2
• Add sorting dropdown

  Only use sorting when on local scope otherwise hide

  Dani211e · 2025-06-25 05:01:40 +02:00
  ad35dad46d
• Reword documentation
  Salman Alshamrani · 2025-06-20 20:21:44 +03:00
  b603a88043
• Fix beatmap set author information
  eyhn · 2025-06-20 16:23:18 +08:00
  4177dc395b
• Add support for reading release stream from assembly version
  Dean Herbert · 2025-06-13 18:52:22 +09:00
  3291a4cb7b
• Fix general confusion in which combo should be read on which gameplay leaderboard

  Closes https://github.com/ppy/osu/issues/33455.
  
  The fundamental misunderstanding and source of confusion in
  https://github.com/ppy/osu/pull/33062 is that solo wants to show
  *maximum combo*, and multiplayer wants to show *current combo*, for
  their own, valid reasons. Which is spelled out explicitly in this
  change.

  Bartłomiej Dach · 2025-06-06 10:08:01 +02:00
  a92a659662
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Fix profile score display logic not matching website

  Reported via e-mails.
  
  The web-side change that wasn't ported here is
  https://github.com/ppy/osu-web/pull/11151. I wanted to port it at the
  time but then ran into issues because this logic should *ideally* also
  be applied to the beatmap set overlay leaderboards, but those are
  hard-glued to `ScoreInfo`, cannot be easily weaned off it to use
  `SoloScoreInfo` instead, and I did not want to make `ScoreInfo` even
  more of a mess than it already is.
  
  This time I'm just ignoring it and adding a TODO instead because I have
  no confidence I will get review eyes on any refactor of the beatmap set
  overlay. All I'll say that such refactors would have potentially
  beneficial effects on results screens too which also (ab)use
  `ScoreInfo`.

  Bartłomiej Dach · 2025-05-26 13:11:41 +02:00
  90bc8865c9
• Use null coalesce wherever possible

  Rider EAP being noisy about this one now.

  Dean Herbert · 2025-05-26 17:15:35 +09:00
  5450298468
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Add matching comment in SpectatorClient for clarity
  Dean Herbert · 2025-05-17 23:33:46 +09:00
  7c44883042
• Also perform time-based frame de-duplication at frame bundle level

  See https://github.com/ppy/osu/pull/33148#discussion_r2092467082

  Bartłomiej Dach · 2025-05-16 09:39:29 +02:00
  baf069ccf7
• Fetch more scores for supporter scope leaderboards

  Which are: global and team leaderboards with mods, and friends and
  country leaderboards.
  
  Only attempting this because of
  https://github.com/ppy/osu/issues/31056#issuecomment-2719787189. Not
  sure if this addresses the concern 🤷

  Bartłomiej Dach · 2025-05-12 09:54:56 +02:00
  934c2440cc
• Merge branch 'master' into open-playlist-link
  Bartłomiej Dach · 2025-05-07 09:31:58 +02:00
  810346ab34