338 Commits

Author	SHA1	Message	Date
Joseph Madamba	5185f6010e	Fix missed identifier typos	2022-01-12 15:46:20 -08:00
mk-56	fd5af1fbe7	Code refactor and name changes ... cleaned code up with Jetbrains i hope it suffices	2021-12-17 13:16:06 +01:00
mk-56	cd095b5f7d	Merge remote-tracking branch 'origin/positional-sounds-strength-adjustment' into positional-sounds-strength-adjustment	2021-11-28 14:21:26 +01:00
mk-56	9c42cc0c05	Fix	2021-11-28 14:12:39 +01:00
mk-56	9065179c52	Fix	2021-11-28 14:09:30 +01:00
mk-56	c3fb793762	Fixed the problems that were brought up and deleted the old bind logic	2021-11-28 14:06:53 +01:00
mk-56	e83115ad5e	Binding logic fix, nullification of unnecessary path	2021-11-28 03:25:11 +01:00
mk-56	eaa464e548	Initial implementation of adjustable positional hitobject audio strength	2021-11-28 02:58:08 +01:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
ekrctb	c63dfa21e1	Always initialize DHO transforms on LoadComplete ... With the previous commit, the transform application is skipped when the state is already changed. But it turns out the previous commit breaks slider animation in the standard editor. This is probably due to the transforms are applied before nested hit objects are added.	2021-08-10 16:34:38 +09:00
ekrctb	f262f288fc	Fix DHO state is overwritten to Idle on LoadComplete ... The state may already be changed before `LoadComplete` is called because DHO is already added to the draw hierarchy.	2021-08-06 19:58:46 +09:00
Salman Ahmed	0b3b9e35ba	Also update colours once on DrawableHitObject	2021-07-23 07:32:56 +03:00
Salman Ahmed	523c154f15	Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable	2021-07-22 16:40:33 +03:00
Salman Ahmed	1af230c48c	Merge branch 'master' into refactor-combo-colour-retrieval	2021-07-20 10:08:25 +03:00
PercyDan54	e1c646b9b2	Remove redundant arguments	2021-07-05 23:52:39 +08:00
ekrctb	117e94bc94	Allow setting Entry of PoolableDrawableWithLifetime ... It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call. Also, the object initializer syntax can be used.	2021-06-16 16:00:08 +09:00
Bartłomiej Dach	296761ade5	Add missing CurrentSkin null check in DHO disposal	2021-06-11 09:18:58 +02:00
Dean Herbert	b8df3fff9e	Fix incorrect method referenced in xmldco ... Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>	2021-06-09 14:20:01 +09:00
Dean Herbert	62199a38a8	Add one missing obsoletion removal date	2021-06-09 14:11:50 +09:00
Dean Herbert	f41e34ae2c	Remove more obsoleted members	2021-06-09 14:10:48 +09:00
ekrctb	abb77b95b4	Fix comment grammar	2021-05-30 13:06:28 +09:00
ekrctb	1d5e8f4a91	Fix wrong/misleading comment of InitialLifetimeOffset	2021-05-28 17:19:36 +09:00
Dean Herbert	122bb05aa8	Add a mention that OnApply/OnFree is performed after ApplyDefaults	2021-05-27 15:20:35 +09:00
smoogipoo	7494ddeef4	Fix DHOs not receiving initial skin changed events	2021-05-24 14:07:40 +09:00
Salman Ahmed	eeeb001d62	Refactor combo colour retrieval logic to request skin lookups instead	2021-05-05 07:17:27 +03:00
Dan Balasescu	5fc731967b	Merge pull request #12592 from ekrctb/fix-entry-lifetime ... Fix Setting DHO's lifetime doesn't update its entry lifetime	2021-04-28 01:38:19 +09:00
Derrick Timmermans	3ea55314f2	Update osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-04-27 11:29:16 +02:00
ekrctb	a2c0951d94	Use overriding instead of hiding in HitObjectLifetimeEntry ... Hidden properties are used when the type is the base class. It caused issues when `DrawableHitObject` logic is factored out to `PoolableDrawableWithLifetime` because it is using the base `LifetimeEntry`, not `HitObjectLifetimeEntry`.	2021-04-27 15:23:33 +09:00
Derrick Timmermans	08a232f7fa	Add method to safely refresh DrawableHitObject transforms	2021-04-26 20:08:40 +02:00
ekrctb	6561a7c7d6	Rename DrawableObject -> PoolableDrawableWithLifetime	2021-04-26 12:06:21 +09:00
ekrctb	e6474e6ff7	Remove redundant statement (lifetime is set in base)	2021-04-26 11:47:38 +09:00
ekrctb	b877a29737	Factor out pooling and lifetime management logic of DHO to a base class	2021-04-21 17:37:42 +09:00
ekrctb	bbf2ec369b	Remove SkinReloadableDrawable inheritance from DHO	2021-04-21 17:34:57 +09:00
ekrctb	3fbeadf318	Deprecate old overload of Apply	2021-04-21 14:32:37 +09:00
ekrctb	73d3da1687	Fix wrong InitialLifetimeOffset is used for a non-pooled DHO. ... HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.	2021-04-21 11:32:01 +09:00
ekrctb	44ff08cce4	Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO." ... This reverts commit 67fcfd9d	2021-04-21 10:02:50 +09:00
ekrctb	67fcfd9dbc	Fix wrong InitialLifetimeOffset is used for a non-pooled DHO. ... HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.	2021-04-21 09:48:16 +09:00
ekrctb	e80c3c317a	Rename UnmanagedHitObjectEntry -> SyntheticHitObjectEntry ... "Unmanaged" was confusing because its lifetime is still managed by the HitObjectContainer.	2021-04-21 09:23:23 +09:00
ekrctb	c6ee4e900e	Ensure a non-null hitobject entry has a non-null Result	2021-04-20 15:18:36 +09:00
ekrctb	8a8b9084ef	Make single-argument overloead of DHO.Apply public	2021-04-20 10:11:36 +09:00
ekrctb	1bc63a4c61	Now, DHO.lifetimeEntry can be non-null even it is not fully applied	2021-04-20 09:22:16 +09:00
ekrctb	2c487ddb70	Create synthetic LifetimeEntry for a DHO when not supplied ... Now, a DHO is always associated with a HitObjectLifetimeEntry while used. Result is always stored in the entry, and not in the DHO.	2021-04-19 21:54:19 +09:00
ekrctb	5afdc3ff66	Make DHO application logic clearer with Entry/HitObject separation	2021-04-19 19:56:17 +09:00
ekrctb	50fad47ebc	Remove usage of Lazy<List<...>> for NestedHitObjects	2021-04-15 18:26:01 +09:00
Dean Herbert	b5954a55ad	Remove empty <returns> xmldoc	2021-04-12 17:46:14 +09:00
smoogipoo	76981f2547	Remove unused using	2021-04-09 13:58:24 +09:00
smoogipoo	8293b06c0a	Remove obsolete code	2021-04-09 13:56:58 +09:00
Bartłomiej Dach	09742998cd	Fix mistaken obsoletion notice ... It was added in c9f38f7bb6, which specified 2021 in another place (and was committed in October of 2020 anyway). Update the year so that it doesn't get culled prematurely.	2021-01-06 18:38:24 +01:00
Bartłomiej Dach	a31e8d137f	Add guard when clearing samples	2020-12-20 15:42:24 +01:00
Dean Herbert	a0f92628ac	Merge branch 'master' into fix-sample-expire	2020-12-04 13:49:08 +09:00