9855 Commits

• Reduce bleed in tests to allow them to pass
  Bartłomiej Dach · 2025-04-11 10:13:49 +02:00
  9911e0819e
• Merge branch 'master' into fix-carousel-bleed
  Bartłomiej Dach · 2025-04-11 08:23:37 +02:00
  4398479846
• Remove previous beatmap wedge implementation
  Salman Alshamrani · 2025-04-11 01:55:36 +09:00
  430b22b383
• Fix carousel handling of bleed areas

  The idea of specifying "bleed" is to make the carousel aware of its
  vertical display area. The top bleed is under the filter control; bottom
  beneath the toolbar. At the end of the day, the point of panel X offset
  incursion, and the scroll target for current selection, should be at the
  centre of the screen.
  
  The fixes match code which already exists in the previous
  implementation. Basically, without incorporating `BleedTop` into
  calculations a second time, the centre position would not match
  expectations (of being the centre including bleed).

  Dean Herbert · 2025-04-11 00:05:51 +09:00
  f9112066d3
• Merge pull request #32669 from smoogipoo/refactor-match-subscreen

  Rewrite match subscreen to remove bindables

  Bartłomiej Dach · 2025-04-08 12:51:36 +02:00
  b3626bfb48
• Add failing countdown start test
  Dan Balasescu · 2025-04-08 18:35:22 +09:00
  968fe6e618
• Merge pull request #32665 from peppy/fix-editor-metadata-save-without-commit

  Fix saving via ctrl+s while metadata textbox is focused not saving changes

  Bartłomiej Dach · 2025-04-08 08:21:03 +02:00
  5f168b9b9f
• Merge pull request #32679 from bdach/playlist-hacksawing

  Remove filtering & rearranging controls from now playing overlay

  Dean Herbert · 2025-04-07 23:07:39 +09:00
  10abd55a15
• Merge pull request #32640 from bdach/better-user-tag-ui

  Re-do user tag voting UI to address user complaints

  Dean Herbert · 2025-04-07 22:52:10 +09:00
  3e9ce6cd3c
• Fix crashes in statistics panel test scene
  Bartłomiej Dach · 2025-04-07 14:49:55 +02:00
  9643beafa7
• Merge pull request #32678 from bdach/prev-next-weirdness

  Fix weird behaviour when skipping back and forth with shuffle enabled

  Dan Balasescu · 2025-04-07 21:11:16 +09:00
  19f761b125
• Switch to using a popover again
  Dean Herbert · 2025-04-07 20:14:08 +09:00
  43ee43c9e2
• Remove unused local variable in test
  Dean Herbert · 2025-04-05 23:34:43 +09:00
  3287cc2e55
• Remove filtering & rearranging controls from now playing overlay
  Bartłomiej Dach · 2025-04-04 13:16:12 +02:00
  f5b849b4f3
• Add failing test coverage
  Bartłomiej Dach · 2025-04-04 13:12:24 +02:00
  55129620b8
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Rewrite match subscreen to use full online state
  Dan Balasescu · 2025-04-04 10:48:55 +09:00
  286b3d9f5b
• Merge pull request #32593 from peppy/less-sample-overhead-during-silly-sliders

  Fix stutters when sliders with hundreds of repeats display for the first time

  Bartłomiej Dach · 2025-04-03 12:31:46 +02:00
  f11d3ddb5c
• Merge branch 'master' into better-user-tag-ui
  Bartłomiej Dach · 2025-04-03 11:59:16 +02:00
  375beae8a9
• Merge pull request #32657 from bdach/ruleset-specific-user-tags

  Add support for ruleset-specific user tags

  Dean Herbert · 2025-04-03 18:58:05 +09:00
  42a7094f9c
• Merge pull request #32601 from sineplusx/median-offset

  Use median instead of mean for average hit error calculations

  Dean Herbert · 2025-04-03 18:56:04 +09:00
  db0811bad9
• Change editor to save metadata changes without explicit textbox commit

  Closes https://github.com/ppy/osu/issues/32365.

  Dean Herbert · 2025-04-03 15:31:24 +09:00
  ce288023fe
• Merge branch 'ruleset-specific-user-tags' into better-user-tag-ui
  Bartłomiej Dach · 2025-04-02 13:28:28 +02:00
  ad334b2bf4
• Add rudimentary test coverage
  Bartłomiej Dach · 2025-04-02 13:25:18 +02:00
  db0f1895fb
• Add failing test
  Dan Balasescu · 2025-04-02 19:58:31 +09:00
  56169d7ac4
• Add failing test case

  Co-authored-by: Rodrigo Correia <rodrigo.figueiredo.correia@tecnico.ulisboa.pt>

  Bartłomiej Dach · 2025-03-31 14:25:35 +02:00
  79375eccb7
• Add groupings to all tags list
  Bartłomiej Dach · 2025-03-31 10:45:44 +02:00
  624948f082
• Replace RoomID change with test-local fixes
  Dan Balasescu · 2025-03-31 16:32:32 +09:00
  74d234a7de
• Adapt TestNotEnoughTimedHitEvents with new minimum hit amount
  sineplusx · 2025-03-29 20:43:59 +01:00
  403b24ef9b
• Move the extra tag selector out of popover
  Bartłomiej Dach · 2025-03-28 14:05:35 +01:00
  1d44d5e100
• Re-enable ignored playlist test
  Dan Balasescu · 2025-03-28 22:01:23 +09:00
  1a0432ce3a
• Refactor MultiplayerPlaylist to not have a selected item bindable
  Dan Balasescu · 2025-03-28 22:01:07 +09:00
  b93e21c666
• Add test for changing item in list

  Brought forward from https://github.com/ppy/osu/pull/32250.

  Dan Balasescu · 2025-03-28 21:49:36 +09:00
  133a1bc1fa
• Redesign vote buttons to better work with hierarchical tags
  Bartłomiej Dach · 2025-03-28 13:24:26 +01:00
  9b9cfbc9c2
• Merge pull request #32610 from bdach/user-tags-on-beatmap-set-overlay

  Show user tags on beatmap set overlay

  Dean Herbert · 2025-03-28 17:10:57 +09:00
  f4c96ecb54
• Show user tags on beatmap set overlay

  Resolves one part of
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928
  
  A few caveats:
  
  - Layout is slightly different than web intentionally. Web does things
    that I think will be difficult to reproduce or just plain look bad in
    client, such as:
  
    - On web, the metadata info box has 200px min height and 300px max
      height. I just hardcoded 300 units.
  
    - On web, user tags and mapper tags are individually scrollable, and
      the amount of space taken up by each is calculated in a way that
      is - as far as I can tell - indeterminate, and probably influenced
      by some flexbox magic. I just made the entire thing scrollable
      instead.
  
  - Because song select shares controls with the beatmap set overlay, now
    song select says "Mapper Tags" in the header instead of just "Tags"
    too. I think this is fine, because people asked for user tags to be
    shown in song select too.
  
  - Search query syntax lifted from
    https://github.com/ppy/osu-web/pull/12047.
  
  - Using hardcoded English strings for now, will update to the
    translations after the next osu-resources localisations update.

  Bartłomiej Dach · 2025-03-27 14:58:03 +01:00
  7bb97d5796
• Merge pull request #32596 from bdach/fix-bogus-daily-challenge-lookup

  Fix daily challenge not querying beatmap properly

  Dan Balasescu · 2025-03-27 21:25:47 +09:00
  b414ed0e42
• Merge pull request #32458 from smoogipoo/refactor-room-panels

  Refactor multiplayer/playlists room panels

  Bartłomiej Dach · 2025-03-27 12:43:32 +01:00
  e5ff123e11
• Fix tests
  Bartłomiej Dach · 2025-03-27 12:39:19 +01:00
  2ba621550c
• Merge pull request #32606 from smoogipoo/fix-mod-overlay-panel-refresh

  Refresh mod panel active states when recreated

  Bartłomiej Dach · 2025-03-27 12:07:35 +01:00
  dbd97166a4
• Merge pull request #32577 from bdach/improve-card-button-input-handling

  Improve input handling in beatmap card buttons

  Dean Herbert · 2025-03-27 20:03:37 +09:00
  a91dcbab6b
• Merge branch 'master' into refactor-room-panels
  Dan Balasescu · 2025-03-27 19:46:07 +09:00
  914c425fa7
• Add failing test
  Dan Balasescu · 2025-03-27 19:05:11 +09:00
  8c244134d5
• Merge pull request #32604 from bdach/fix-multiplayer-join-logging

  Fix several issues with multiplayer & playlists room join error logging

  Dan Balasescu · 2025-03-27 18:30:52 +09:00
  c69e0cbb73
• Merge pull request #32573 from smoogipoo/refactor-mp-user-mod-display

  Add multiplayer-specific implementation for user mod display

  Bartłomiej Dach · 2025-03-27 10:08:30 +01:00
  eeed29ce03
• Fix test
  Dan Balasescu · 2025-03-27 17:49:21 +09:00
  2cfb06bcde
• Fix several issues with multiplayer & playlists room join error logging

  This is in response to
  https://osu.ppy.sh/community/forums/topics/2058708?n=5, wherein the user
  is having a problem with joining multiplayer, but I have basically no
  diagnosing capabilities, because the logs are all
  
      2025-03-26 18:57:57 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:40 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
  
  which appears to originate from
  
  https://github.com/ppy/osu/blob/c82eaafe98d96b9f49a4a7f168ef5c484e67d76f/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs#L91
  
  Now, as far as I can tell, there are two possibilities here:
  
  1. The exception's `Message` is null or empty. That's not exactly great
     or typical, but sure, this could possibly happen - in which case the
     error logging is silently eating whatever little relevant detail
     there is left to use.
  
  2. The exception is *actually* `null` itself, and we're in the X Files.
  
  This PR is intending to defend against (1).
  
  In examining the logging further, I also spotted the following issues:
  
  - In the single path that specifies a custom failure handler (which is
    `DrawableLoungeRoom` which handles joining a passworded room), the
    custom failure handler being present means that the error would be
    presented to the user, but it would not be logged. At all.
  
  - In playlists, if the exception for whatever reason had an empty
    message, an empty notification would get posted. And in general to me
    it feels a bit dodgy to be directly presenting exception notifications
    to users without any preamble, hence the added "Failed to open
    playlist" prefix.

  Bartłomiej Dach · 2025-03-27 08:52:33 +01:00
  1c4ecba950
• Merge pull request #32571 from smoogipoo/refactor-mp-availability

  Refactor online play beatmap availability, add multiplayer-specific implementation

  Bartłomiej Dach · 2025-03-26 13:52:07 +01:00
  c82eaafe98
• Merge branch 'master' into refactor-room-panels
  Bartłomiej Dach · 2025-03-26 11:58:20 +01:00
  43d652bc3e
• Remove unused local
  Dean Herbert · 2025-03-26 19:10:14 +09:00
  90bc2318e1