72717 Commits

This Branch

This Branch

All Branches

• Fix stack overflow due to bindable equality
  Dan Balasescu · 2025-04-23 18:17:27 +09:00
  e36c6db008
• Fix initial song select states

  The core freestyle-changed code business logic doesn't need to run on
  load (or maybe _should not_ be run), but some of the housekeeping code
  it also runs _does_ need to be run immediately.
  
  Extracting said housekeeping code fulfills both requirements.

  Dan Balasescu · 2025-04-23 15:32:17 +09:00
  43386a193b
• Rename methods
  Dan Balasescu · 2025-04-23 15:04:44 +09:00
  f23eb99527
• Reorder function parameters, hopefully improve documentation
  Dan Balasescu · 2025-04-17 19:12:13 +09:00
  f0a8ddd513
• Improve IMod documentation
  Dan Balasescu · 2025-04-17 18:32:35 +09:00
  92267c8bb3
• Use IMod documentation where present
  Dan Balasescu · 2025-04-17 18:32:26 +09:00
  95cf4887e1
• Remove no longer relevant comments
  Dan Balasescu · 2025-04-17 18:25:01 +09:00
  5bda93aac6
• Adjust method name
  Dan Balasescu · 2025-04-17 02:36:55 +09:00
  2a09572d09
• Add/improve xmldocs
  Dan Balasescu · 2025-04-17 02:34:10 +09:00
  c283859bab
• Apply changes from reviews
  Dan Balasescu · 2025-04-17 02:19:31 +09:00
  64aafa4e4c
• Fix missing binding
  Dan Balasescu · 2025-04-14 20:53:11 +09:00
  ac7014992a
• Adjust logic to properly list selectable mods
  Dan Balasescu · 2025-04-14 20:23:00 +09:00
  3dcd1a9e74
• Restore freemods/freestyle button exclusivity
  Dan Balasescu · 2025-04-14 20:20:35 +09:00
  276e923843
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Only apply freestyle validation to required mods
  Dan Balasescu · 2025-04-14 19:34:21 +09:00
  b4c7d7f498
• Allow classic mod in freestyle
  Dan Balasescu · 2025-04-10 13:05:17 +09:00
  c6e368d3ea
• Update test with stricter assertions
  Dan Balasescu · 2025-04-10 13:04:40 +09:00
  69630263a8
• Merge mod validity checks to closer match osu!web
  Dan Balasescu · 2025-04-10 13:02:25 +09:00
  05e70cd938
• Merge branch 'master' into freestyle-mods
  Dan Balasescu · 2025-04-08 19:57:28 +09:00
  1c060f986c
• Merge pull request #32669 from smoogipoo/refactor-match-subscreen

  Rewrite match subscreen to remove bindables

  Bartłomiej Dach · 2025-04-08 12:51:36 +02:00
  b3626bfb48
• Clone countdown objects in test client

  Beyond isolation, this stuff is also used to test (de-)serialisation.
  Much-of-a-muchness in this case since it isn't too thoroughly tested,
  but best do it anyway.

  Dan Balasescu · 2025-04-08 18:42:25 +09:00
  874ec49590
• Fix crash when trying to start countdown
  Dan Balasescu · 2025-04-08 18:35:51 +09:00
  5769292daf
• Add failing countdown start test
  Dan Balasescu · 2025-04-08 18:35:22 +09:00
  968fe6e618
• Merge pull request #32733 from peppy/beatmap-name-in-load-failure-error

  Include beatmap details in logs when load fails

  Bartłomiej Dach · 2025-04-08 09:23:04 +02:00
  5be7b00562
• Merge pull request #32732 from peppy/vertex-selection-increase

  Increase range of vertex selection in polygon generation popover

  Bartłomiej Dach · 2025-04-08 09:07:49 +02:00
  b1b8601105
• Merge pull request #32731 from peppy/adjust-menu-positioning

  Adjust menu tips and supporter display to not overlap

  Bartłomiej Dach · 2025-04-08 09:00:57 +02:00
  5094b34159
• Remove obsoleted overload of ApplyResult
  Dean Herbert · 2025-04-08 15:47:30 +09:00
  5d572e1ab2
• Include beatmap details in logs when load fails

  See
  https://github.com/ppy/osu/discussions/32682#discussioncomment-12760059
  for ambiguous logs.

  Dean Herbert · 2025-04-08 15:33:43 +09:00
  d31ffd9014
• Merge pull request #32730 from peppy/fix-keyboard-steps

  Fix editor setup screen sliders not having correct keyboard steps

  Bartłomiej Dach · 2025-04-08 08:32:37 +02:00
  99ee5767cb
• Increase range of vertex selection in polygon generation popover

  Addresses https://github.com/ppy/osu/discussions/32703.

  Dean Herbert · 2025-04-08 15:26:41 +09:00
  e990099cd9
• Merge pull request #32665 from peppy/fix-editor-metadata-save-without-commit

  Fix saving via ctrl+s while metadata textbox is focused not saving changes

  Bartłomiej Dach · 2025-04-08 08:21:03 +02:00
  5f168b9b9f
• Adjust menu tips and supporter display to not overlap

  Closes https://github.com/ppy/osu/issues/32684.
  
  Also did a very brief pass on timings and animations.

  Dean Herbert · 2025-04-08 15:12:28 +09:00
  38608360b5
• Merge pull request #32718 from minetoblend/feature/tag-vote-count-transition

  Add transition when vote-count changes in user tag control

  Bartłomiej Dach · 2025-04-08 07:46:12 +02:00
  ef63f623a3
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Merge pull request #32726 from peppy/fix-health-bar-ki-sizing

  Fix incorrect sizing of legacy health display "ki" markers

  Dan Balasescu · 2025-04-08 14:21:19 +09:00
  4bd405ab10
• Simplify animation application and remove autosizeduration hack
  Dean Herbert · 2025-04-08 14:02:59 +09:00
  0bb085bce6
• Fix incorrect sizing of legacy health display "ki" markers

  Closes https://github.com/ppy/osu/issues/32724.

  Dean Herbert · 2025-04-08 13:52:07 +09:00
  6d833939ae
• Add transition when vote-count changes in UserTagControl
  Marvin Schürz · 2025-04-07 16:37:25 +02:00
  7f52952840
• Merge pull request #32679 from bdach/playlist-hacksawing

  Remove filtering & rearranging controls from now playing overlay

  Dean Herbert · 2025-04-07 23:07:39 +09:00
  10abd55a15
• Merge pull request #32640 from bdach/better-user-tag-ui

  Re-do user tag voting UI to address user complaints

  Dean Herbert · 2025-04-07 22:52:10 +09:00
  3e9ce6cd3c
• Make dependency on editor optional
  Bartłomiej Dach · 2025-04-07 15:00:47 +02:00
  5db4f80e84
• Fix code quality harder
  Bartłomiej Dach · 2025-04-07 14:59:51 +02:00
  f968f8ed68
• Fix crashes in statistics panel test scene
  Bartłomiej Dach · 2025-04-07 14:49:55 +02:00
  9643beafa7
• Close popovers on hiding the statistics view

  Now that the tagging popover is back,
  https://github.com/ppy/osu/issues/32630 actually needs fixing.

  Bartłomiej Dach · 2025-04-07 14:48:26 +02:00
  11e48f9f8e
• Allow tag control popover to attach to bottom too

  Looks bad when trying to tag on a replay otherwise.

  Bartłomiej Dach · 2025-04-07 14:45:38 +02:00
  cded1311c8
• Cache aquamarine colour provider at results screen

  To fix the user tag control.
  
  I would have done it locally to the user tag control, but it was pissing
  me off because I wanted the add button to be aquamarine (as it's closer
  to the accents the screen is already using), but the popover on open was
  for whatever reason purple and I just want consistency where possible.

  Bartłomiej Dach · 2025-04-07 14:39:37 +02:00
  23c711d1bc
• Merge pull request #32678 from bdach/prev-next-weirdness

  Fix weird behaviour when skipping back and forth with shuffle enabled

  Dan Balasescu · 2025-04-07 21:11:16 +09:00
  19f761b125
• Validate state with lesser magic
  Dan Balasescu · 2025-04-07 20:56:54 +09:00
  71af50f675
• Animate scroll back to zero
  Dean Herbert · 2025-04-07 20:55:39 +09:00
  c42d7aa4fa
• Don't delay scroll on hover of playlist items
  Dean Herbert · 2025-04-07 20:51:32 +09:00
  60e6b56b66