1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 22:32:55 +08:00
Commit Graph

69598 Commits

Author SHA1 Message Date
Bartłomiej Dach
8d89557ab8
Fix not being able to send chat reports on daily challenge screen
Something something some people cannot be trusted with a textbox.
2024-07-25 11:11:54 +02:00
Bartłomiej Dach
537403bb0b
Merge branch 'master' into fix-results-fetching-twice 2024-07-25 10:47:21 +02:00
Bartłomiej Dach
9790c5a574
Merge pull request #29058 from frenzibyte/daily-challenge-fix-score-selection
Fix daily challenge abruptly discarding score selection when opening results screen
2024-07-25 10:46:32 +02:00
Salman Ahmed
615f07d54c Fix results screen fetching more scores twice 2024-07-25 09:16:09 +03:00
Salman Ahmed
f3dd1facf1 Add failing test case 2024-07-25 09:16:09 +03:00
Salman Ahmed
9d5fbb8b4f Fix target score selection abruptly discarded after opening results screen 2024-07-25 09:01:43 +03:00
Salman Ahmed
e1ccf68801 Revert "Add failing test case"
This reverts commit 0182f3d7c3.
2024-07-25 08:51:48 +03:00
Dan Balasescu
542cb12059
Merge pull request #28995 from bdach/swell-editor-test-play
Fix swells not being correctly treated in editor gameplay test
2024-07-25 14:39:49 +09:00
Dean Herbert
f1dda4ab1e
Fix too many event rows displaying after spending a long time in gameplay/results 2024-07-25 14:31:22 +09:00
Dean Herbert
c90d345ff9
Scroll content forever rather than aggressively fading 2024-07-25 14:31:21 +09:00
Dean Herbert
bba151a776
Make event feed test show more realistic content automatically 2024-07-25 14:31:21 +09:00
Bartłomiej Dach
ccef98d24e
Merge pull request #29054 from peppy/fix-leaderboard-refreshing
Fix excessive leaderboard refreshes in daily challenge screen
2024-07-25 07:15:17 +02:00
Salman Ahmed
dad8e28446 Fix replay download button not added when no score is selected initially 2024-07-25 07:40:17 +03:00
Salman Ahmed
0182f3d7c3 Add failing test case 2024-07-25 07:39:58 +03:00
Dean Herbert
aac98ab6b2
Debounce leaderboard refetches to stop excessive operations after returning from gameplay 2024-07-25 12:58:35 +09:00
Dean Herbert
9ec687caab
Avoid reloading the daily challenge leaderboard when already requested 2024-07-25 12:55:45 +09:00
Dan Balasescu
a696e3c261
Add reference to android project 2024-07-25 10:44:44 +09:00
Dan Balasescu
c5814e0869
Merge pull request #29047 from RealCyGuy/good-first-issues
Fix link to good first issues in CONTRIBUTING.md
2024-07-25 10:38:23 +09:00
Cyrus Yip
d63335082e
fix link to good first issues 2024-07-24 18:24:52 -07:00
Dan Balasescu
3dd7db5499
Merge pull request #29046 from peppy/disable-macos-runs
Disable macOS test runs for now
2024-07-25 09:49:00 +09:00
Dean Herbert
4cc07badbd
Disable macOS test runs for now
We are seeing update frames run as little as [once per
second](aa4d16bdb8/osu.Game/Overlays/BeatmapListingOverlay.cs (L141)).
Until we can ascertain why this is happening, let's reduce developer
stress by not running macOS tests for now.
2024-07-25 09:05:58 +09:00
Dan Balasescu
d057bee4fb
Merge pull request #29044 from frenzibyte/fix-drag-overwritten-by-focus
Fix dragging number boxes no longer working correctly
2024-07-25 08:36:39 +09:00
Salman Ahmed
b3e3bf7cec Add lenience to avoid floating point errors 2024-07-24 23:26:23 +03:00
Salman Ahmed
6645dac71d Fix dragging number boxes overwritten by select-all-on-focus feature 2024-07-24 23:19:04 +03:00
Bartłomiej Dach
12a9086aa3
Fix test failure
After the legacy key counter was moved to ruleset-specific component
containers, `TestSceneSkinnableHUDOverlay` no longer had a key counter,
because it wasn't creating a ruleset-specific HUD component container
due to

    4983e5f33e/osu.Game/Screens/Play/HUDOverlay.cs (L131-L133)

Therefore, to fix, do just enough persuading to make it create one.
2024-07-24 18:30:18 +02:00
Dean Herbert
4983e5f33e
Merge pull request #29039 from bdach/multiple-selection-sample-popover
Make sample popover change properties of all samples in multiple selection
2024-07-24 22:49:20 +09:00
Bartłomiej Dach
c3dae81935
Only add legacy key overlay to osu! and catch HUD layers 2024-07-24 15:41:20 +02:00
Bartłomiej Dach
26395bd443
Adjust animations further to match stable 2024-07-24 15:26:27 +02:00
Bartłomiej Dach
3c28c116ca
Simplify input overlay text colour decode (and fix incorrect default) 2024-07-24 14:53:01 +02:00
Bartłomiej Dach
087dd759be
Adjust layout to ballpark-match stable
I dunno what the wiki is claiming with the "24px" figure or why
but I'm not playing conversion games either. Dimensions ballparked
via screenshots captured at x768 resolution.

Also removes a weird homebrew method to keep the text upright.
There is one canonical way to do this, namely
`UprightAspectMaintainingContainer`. And the other key counters
were already using it.
2024-07-24 14:52:56 +02:00
Bartłomiej Dach
ace5071d88
Add better test scene 2024-07-24 14:25:51 +02:00
Bartłomiej Dach
1ed7e4b075
Make sample popover change properties of all samples in multiple selection
Closes https://github.com/ppy/osu/issues/28916.

The previous behaviour *may* have been intended, but it was honestly
quite baffling. This seems like a saner variant.
2024-07-24 12:15:12 +02:00
Bartłomiej Dach
55382a4ba6
Add test coverage for expected sample popover behaviour 2024-07-24 12:08:13 +02:00
Dean Herbert
6e4625609d
Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard
Fill daily challenge top 50 position numbers client-side
2024-07-24 17:49:51 +09:00
Dean Herbert
65fcef1929
Merge pull request #29037 from bdach/daily-challenge-exit-when-offline
Exit daily challenge screen when going offline
2024-07-24 17:48:07 +09:00
Bartłomiej Dach
788b70469d
Exit daily challenge screen when going offline
This sort of thing is bound to happen when rewriting screens from
scratch without invoking abstract eldritch entities sometimes. Damned if
you do, damned if you don't...
2024-07-24 09:15:32 +02:00
Bartłomiej Dach
bf4bf4d39e
Fill daily challenge top 50 position numbers client-side
Only doing this client-side, because doing this server-side is
expensive:

	https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285
2024-07-24 08:57:11 +02:00
Dean Herbert
aded31bd07
Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt
Respect pre-empt time when auto-generating breaks
2024-07-24 15:21:12 +09:00
normalid
0306ef4096 Update test assets 2024-07-24 14:13:45 +08:00
normalid
fede6b3657 Fix indent problems 2024-07-24 13:09:21 +08:00
normalid
b24be96d04 Fix code quality 2024-07-24 12:57:30 +08:00
normalid
56143de2c6 Update offset factor 2024-07-24 12:39:36 +08:00
normalid
e2beacb3dd Remove logging 2024-07-24 12:31:01 +08:00
normalid
395f8424b5 Match the stable animation 2024-07-24 12:30:08 +08:00
normalid
95f287104e Add visual test seane 2024-07-24 12:24:58 +08:00
normalid
661f58a397 Add test coverage 2024-07-24 12:18:05 +08:00
normalid
c52a993607 Support custom input overlay color 2024-07-23 23:35:25 +08:00
normalid
c7b110a471 * Fix the default position
* Make the font match stable style
2024-07-23 22:11:28 +08:00
Dean Herbert
a9ccb50b98
Merge pull request #29020 from bdach/drag-selection-tolerance
Add tolerance when drag-scrolling editor timeline
2024-07-23 22:28:29 +09:00
normalid
989ac56cbb Fix the return button being squshed 2024-07-23 21:12:55 +08:00