10328 Commits

• Fix skin editor tests not passing on macOS
  Dan Balasescu · 2025-08-03 03:50:06 +09:00
  0270ca6cf1
• Add support for grouping beatmaps by collections

  Takes changes in https://github.com/ppy/osu/pull/34233 and removes *all*
  of the complexity.
  
  Supersedes and closes #34233.
  
  Contains same caveat that we can only display one beatmap once in the
  carousel; this will be addressed separately.

  Dean Herbert · 2025-08-01 16:23:26 +09:00
  c3396a93a6
• Fix test
  Bartłomiej Dach · 2025-07-31 08:47:23 +02:00
  cf41a04a2e
• Fix test
  Bartłomiej Dach · 2025-07-30 15:01:58 +02:00
  34292a75ee
• Fix test
  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  1319a5499b
• Fix test failure due to stupid reasons

  I'm actually not sure why not resetting this fails, but I don't want to
  spend the time investigating either.

  Dean Herbert · 2025-07-29 17:51:15 +09:00
  54a7f7ee71
• Fix missed inspection
  Dean Herbert · 2025-07-29 16:48:39 +09:00
  584362efc3
• Add test coverage of read-only scenario
  Dean Herbert · 2025-07-29 16:46:07 +09:00
  988f1a4e76
• Merge branch 'master' into NotStirred/master
  Dean Herbert · 2025-07-29 16:36:37 +09:00
  2dde5b1eaf
• Add test coverage of long messages
  Dean Herbert · 2025-07-29 15:12:00 +09:00
  8560c74c70
• Make UserAvatarNotification abstract since it has no actual usage
  Dean Herbert · 2025-07-29 15:02:18 +09:00
  aa4afa8776
• Update design once more
  Salman Alshamrani · 2025-07-29 14:35:25 +09:00
  35a7588c3d
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-28 19:12:34 +03:00
  6936533522
• Merge pull request #34410 from bdach/favourite-fail

  Fix song select favourite button getting stuck spinning if operation failed

  Dean Herbert · 2025-07-28 23:14:08 +09:00
  bec0b94af6
• Fix failing test

  Started failing after master merge.

  Bartłomiej Dach · 2025-07-28 13:15:33 +02:00
  c59b4f9526
• Merge branch 'master' into local-score-sorting-v2
  Bartłomiej Dach · 2025-07-28 11:32:59 +02:00
  c620d58bc2
• Add failing test coverage
  Bartłomiej Dach · 2025-07-28 11:02:54 +02:00
  7407efeea5
• Account for BPM rounding in grouping setup
  Dean Herbert · 2025-07-28 16:32:04 +09:00
  996c1e0637
• Change song select grouping to be divided into 10 BPM groups
  Dean Herbert · 2025-07-25 17:55:09 +09:00
  c6cbda5ecc
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-25 11:36:52 +03:00
  4b73afd195
• Remove duplicate test
  Dean Herbert · 2025-07-24 13:24:57 +09:00
  ad9584e658
• Adjust variable name
  eyhn · 2025-07-23 22:33:22 +08:00
  843cd86551
• Fix present beatmap audio start at the preview point
  eyhn · 2025-07-23 22:29:07 +08:00
  e55a9e486b
• Merge pull request #33530 from JackArmstrong22/fix-negative-zero-audio-offset

  Fix beatmap offset control potentially reporting negative zero

  Dean Herbert · 2025-07-23 16:54:33 +09:00
  9f6b156d0c
• Add test coverage of incorrect formatting output

  Fix a cosmetic UI issue where -0.0 is displayed when clicking the Calibrate using last play button.
  
  Removed changes to AudioOffsetAdjustControl and added check to ToStandardFormattedString for if floatValue is 0

  Dean Herbert · 2025-07-23 14:47:38 +09:00
  44531794a1
• Fix tests
  Bartłomiej Dach · 2025-07-22 10:11:16 +02:00
  b9bda61e27
• Store pause timestamps (rounded to ms) instead of general count
  Bartłomiej Dach · 2025-07-22 09:26:12 +02:00
  d8900defd3
• Merge branch 'master' into store-pause-count
  Bartłomiej Dach · 2025-07-22 08:44:16 +02:00
  b08ba3c9e4
• Merge pull request #34231 from bdach/user-tag-search-wip

  Add initial support for filtering by user tags in song select

  Dean Herbert · 2025-07-21 14:52:47 +09:00
  b4466aa7a2
• Update test cases to match expected behaviour
  Salman Alshamrani · 2025-07-21 02:22:53 +03:00
  1b473f8a81
• Add test coverage for favouriting from song select
  Bartłomiej Dach · 2025-07-18 12:34:20 +02:00
  a686157b47
• Merge branch 'ppy:master' into ssv2-localisation
  Denis Titovets · 2025-07-16 11:59:47 +03:00
  021ef6d727
• Fix tests
  Bartłomiej Dach · 2025-07-15 14:30:30 +02:00
  02d54e5a38
• Merge pull request #34209 from smoogipoo/playlist-results-no-submission-no-indexing

  Make online play results not request leaderboard on failed submission

  Bartłomiej Dach · 2025-07-15 07:54:41 +02:00
  0d1788e7f1
• Fix flaky playlists navigation test

  See: https://github.com/ppy/osu/actions/runs/16267403227/job/45929099025
  
  Repro:
  
  ```diff
  diff --git a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  index a4e808ff76..db0a0e83a6 100644
  --- a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  +++ b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
  @@ -88,6 +88,7 @@ public abstract partial class LoungeSubScreen : OnlinePlaySubScreen, IOnlinePlay
           [BackgroundDependencyLoader(true)]
           private void load()
           {
  +            System.Threading.Thread.Sleep(1000);
               Masking = true;
  
               const float controls_area_height = 25f;
  
  ```

  Dan Balasescu · 2025-07-14 22:41:08 +09:00
  3a3c1c4e09
• Merge pull request #34169 from EYHN/eyhn/fix/deleted-user-map

  Fix failed to load beatmap detail host by deleted user

  Dan Balasescu · 2025-07-14 22:33:07 +09:00
  e43ccb99d0
• Adjust behavior of beatmap set with deleted author
  eyhn · 2025-07-14 20:58:03 +08:00
  3eca3897ed
• Use more descriptive test step name
  Bartłomiej Dach · 2025-07-14 14:47:33 +02:00
  9cc5fab383
• Re-privatise PlaylistItem.Beatmap, adjust tests
  Dan Balasescu · 2025-07-14 21:19:20 +09:00
  13fc37b2de
• Change failing test to use until step instead
  Bartłomiej Dach · 2025-07-14 13:51:46 +02:00
  fc44301713
• Add failing test
  Dan Balasescu · 2025-07-14 20:30:15 +09:00
  fd776c58ad
• Add failing tests
  Dan Balasescu · 2025-07-14 17:57:41 +09:00
  e36c590315
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-12 10:37:17 +03:00
  0065331659
• Fix tests (they're using LocalisableStrings now)
  Denis Titovets · 2025-07-10 21:58:05 +03:00
  d5fe7e20be
• Merge pull request #34087 from peppy/song-select-v2-deletion-handling

  Improve song select's automatic selection behaviour when current selection is no longer valid

  Dean Herbert · 2025-07-10 21:52:29 +09:00
  8ff2100560
• Simplify post-hide selection
  Dean Herbert · 2025-07-10 21:08:57 +09:00
  acdd246518
• Add test coverage of ruleset changes, ensuring same beatmap is preferred if possible
  Dean Herbert · 2025-07-10 18:13:38 +09:00
  5bc1dd1415
• Disallow hiding beatmap difficulties if only one difficulty remains
  Dean Herbert · 2025-07-10 17:57:45 +09:00
  789ddcf395
• Ensure adjacent selection when currently selected beatmap is hidden
  Dean Herbert · 2025-07-10 17:46:10 +09:00
  44bbb7f029
• Ensure adjacent selection when currently selected beatmap(set) is deleted
  Dean Herbert · 2025-07-10 17:46:09 +09:00
  994bd4abfe