6074 Commits

• Integrate ready button implementation
  Dan Balasescu · 2022-03-17 18:43:04 +09:00
  da0ffab14e
• Integrate spectate button implementation
  Dan Balasescu · 2022-03-17 18:36:33 +09:00
  461d41529b
• Add missing OverlayColourProvider to SkinEditor test
  Dean Herbert · 2022-03-16 22:23:19 +09:00
  3f61b0d968
• Merge branch 'master' into skin-editor-sidebars
  Dan Balasescu · 2022-03-16 21:12:18 +09:00
  7f65f6adcc
• Merge branch 'master' into skin-editor-scene-library
  Dan Balasescu · 2022-03-16 20:42:30 +09:00
  b9387c7ff1
• Update skin editor to use EditorSidebar
  Dean Herbert · 2022-03-16 19:30:51 +09:00
  4525ed645c
• Add basic scene selector
  Dean Herbert · 2022-03-16 19:12:06 +09:00
  d062810ff2
• Add missing Schedule call to allow individual tests from TestSceneMessageNotifier to pass
  Dean Herbert · 2022-03-16 18:44:30 +09:00
  2452d84e98
• Merge pull request #17260 from peppy/editor-sidebar

  Add `EditorSidebar` component

  Dan Balasescu · 2022-03-16 18:20:18 +09:00
  7e8aa77b2b
• Allow section headers to wrap
  Dean Herbert · 2022-03-16 17:19:08 +09:00
  ba1642a680
• Move all PlaylistResultScreen test state initialisation into SetUpSteps
  Jai Sharma · 2022-03-15 22:15:35 +00:00
  1c79083f96
• Fix PlaylistResultsScreen test failures

  As seen: https://github.com/ppy/osu/pull/17252/checks?check_run_id=5545717506
  
  The `PlaylistsResultsScreen` takes a lease on the `Beatmap` bindable
  when entered. During `SetUp`, the `Beatmap` bindable is reassigned but
  fails in cases where an existing test instance of the screen hasn't been
  exited yet. This fix moves the assignment into the `SetUpSteps` function
  after `base.SetUpSteps` is called which will exit the existing screens
  first.

  Jai Sharma · 2022-03-15 20:38:04 +00:00
  c56df80106
• Add EditorSidebar component
  Dean Herbert · 2022-03-15 16:38:00 +09:00
  9e476ced63
• Merge branch 'master' into pp-counter-alloc-reduction
  Dean Herbert · 2022-03-15 13:31:57 +09:00
  6fb06d69cc
• Merge pull request #17242 from smoogipoo/performance-calculator-cleanup

  Restructure PerformanceCalculator to not require ScoreInfo argument

  Dean Herbert · 2022-03-15 13:31:34 +09:00
  deb4aeb4b2
• Remove unnecessary ctor arguments
  Dan Balasescu · 2022-03-15 12:34:58 +09:00
  daac933498
• Prevent incorrect usages by hard-typing ctor type
  Dan Balasescu · 2022-03-15 09:11:59 +09:00
  59d57a44d4
• Provide correct HitResult type for random judgements in TestSceneHitErrorMeter
  Dean Herbert · 2022-03-14 19:16:19 +09:00
  b31ff679fb
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Restructure PerformanceCalculator to not require ScoreInfo argument
  Dan Balasescu · 2022-03-14 14:25:28 +09:00
  4a3e3aba65
• Add failing test cases
  Salman Ahmed · 2022-03-14 03:47:18 +03:00
  720e1cd206
• Add failing test assertion
  Salman Ahmed · 2022-03-14 03:46:11 +03:00
  dbc26c3534
• Merge branch 'master' into chat-mention-highlight
  Salman Ahmed · 2022-03-11 17:51:22 +03:00
  cc87563d57
• Improve channel switching flow in HighlightMessage
  Salman Ahmed · 2022-03-10 23:07:15 +03:00
  a31611bdec
• Add test coverage for highlighting message on left channel
  Salman Ahmed · 2022-03-10 21:30:02 +03:00
  e419370830
• Merge pull request #17180 from jai-x/new-chat-channel-listing

  Implement `ChannelListing` for new chat design

  Dean Herbert · 2022-03-10 19:27:58 +09:00
  d1f8fd01df
• Fix potential test failures due to slow realm refresh in TestSceneScreenNavigation

  As seen at https://github.com/ppy/osu/runs/5492345983?check_suite_focus=true.

  Dean Herbert · 2022-03-10 18:10:08 +09:00
  d5eca16b69
• Merge pull request #17164 from smoogipoo/scoreprocessor-rework

  Rework ScoreProcessor score calculation methods to fix various issues

  Dean Herbert · 2022-03-10 16:48:58 +09:00
  db5c2c15dc
• Merge branch 'master' into new-chat-channel-listing
  Dean Herbert · 2022-03-10 15:49:06 +09:00
  0155519343
• Merge branch 'master' into chat-mention-highlight
  Dean Herbert · 2022-03-10 14:23:23 +09:00
  022dd88aef
• Add too many messages to better test long scrolls
  Salman Ahmed · 2022-03-10 04:01:07 +03:00
  f229447453
• Add test case for highlighting while chat overlay is hidden
  Salman Ahmed · 2022-03-10 02:50:27 +03:00
  d4de435eb2
• Scroll chat line to channel center

  We may eventually want that encapsulated within `ScrollIntoView`, as it
  would also come in handy for `GameplayLeaderboard`.

  Salman Ahmed · 2022-03-10 02:50:15 +03:00
  80c0df6af5
• Remove NewChat namespace
  Jai Sharma · 2022-03-09 18:13:56 +00:00
  b67f9269f9
• Merge branch 'master' into scoreprocessor-rework
  Dean Herbert · 2022-03-09 23:04:18 +09:00
  94ff6a338f
• Fix non-matching filename
  Dean Herbert · 2022-03-09 18:07:43 +09:00
  2e350a91cc
• Fix regressing issues when attempting to exit Player after an unsuccessful beatmap load
  Dean Herbert · 2022-03-09 17:57:58 +09:00
  2eb3365f46
• Ensure gameplay can't start when an UnknownMod is present
  Dean Herbert · 2022-03-09 17:57:58 +09:00
  1ee0be5e39
• Merge pull request #17161 from smoogipoo/fix-listing-score-conversion

  Fix scores not being recalculated in beatmap overlay

  Dean Herbert · 2022-03-09 13:32:45 +09:00
  affcf5180b
• Merge pull request #17152 from bdach/mod-overlay/difficulty-multiplier

  Implement difficulty multiplier display for new mod select design

  Dean Herbert · 2022-03-09 12:11:16 +09:00
  58aef25ad5
• Merge pull request #17170 from peppy/fix-top-local-rank-test-failures-realm-callback

  Refactor top local rank test method to be more resilient to slow realm callbacks

  Dan Balasescu · 2022-03-09 11:14:37 +09:00
  810cbd745d
• Merge pull request #17169 from peppy/fix-song-select-test-failures-realm-callback

  Refactor song select test methods to be resilient to slow realm callbacks

  Dan Balasescu · 2022-03-09 11:14:26 +09:00
  af4423959c
• Use int in ChannelListing test
  Jai Sharma · 2022-03-09 00:52:33 +00:00
  9720a06b16
• Implement ChannelListing for new chat design

  Adds components `ChannelListing` and `ChannelListing` item with visual
  test. Essentially a more simplified version of the existing
  `ChannelSelectionOverlay` component.
  
  Correctly implements `IFilterable` behaviour to filter child channel
  items. Channel joined state is based on the underlying `Joined` bindable
  of the `Channel` class.
  
  Channel join/leave events are exposed via `OnRequestJoin` and
  `OnRequestLeave` events which should be handled by parent component.
  
  Requires a cached `OverlayColourScheme` instance to be provided by the
  parent overlay component when added.

  Jai Sharma · 2022-03-08 22:30:58 +00:00
  a3477c3841
• Merge pull request #17167 from peppy/fix-download-button-test-failure

  Fix potential test failure on slow realm callback in `TestSceneBeatmapDownloadButton`

  Dan Balasescu · 2022-03-09 01:49:23 +09:00
  714789f726
• Fix TestSceneTopLocalRank.TestHighScoreSet not waiting for potentially slow realm callback

  As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.

  Dean Herbert · 2022-03-09 01:22:01 +09:00
  233c8232d3
• Refactor multiple TestScenePlaySongSelect test methods to be resilient to slow realm callbacks
  Dean Herbert · 2022-03-09 01:18:53 +09:00
  286bafe326
• Fix potential test failure on slow realm callback in TestSceneBeatmapDownloadButton

  As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847.

  Dean Herbert · 2022-03-09 01:11:46 +09:00
  56ad684f5b
• Fix intermittent test failure
  Dan Balasescu · 2022-03-09 00:48:12 +09:00
  729af28a64
• Fix test failure ripple through entire TestScene
  Dan Balasescu · 2022-03-09 00:48:03 +09:00
  94d5e2f264