Dean Herbert
d9d083752a
Clamp backwards index to total current items to fix edge case of item removal
2022-10-26 11:03:11 +09:00
Dean Herbert
cf3bf41b49
Harden and simplify logic to avoid weird issues
2022-10-25 18:57:15 +09:00
Dean Herbert
22ea9a8ab4
Add early return of carousel group has no items
2022-10-25 13:34:22 +09:00
Dean Herbert
2456a18bc1
Rewrite implementation to avoid duplicated LINQ returns
2022-10-25 12:48:17 +09:00
Endrik Tombak
b95091fbb0
Move test to improve diff readability
2022-10-24 22:55:09 +03:00
Endrik Tombak
9def12c60b
Write new tests
2022-10-24 22:50:56 +03:00
Endrik Tombak
5a118cfdc3
Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection
...
Conflicts:
osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs
2022-10-24 21:40:48 +03:00
Bartłomiej Dach
6ac7518df4
Merge pull request #20904 from peppy/fix-tournament-seeding-editor-crash
...
Fix crash when exiting seeding editor too soon
2022-10-24 19:25:20 +02:00
Bartłomiej Dach
3f6b8ec38c
Merge branch 'master' into fix-tournament-seeding-editor-crash
2022-10-24 18:50:49 +02:00
Dean Herbert
e3e88d0d50
Merge pull request #19048 from ggliv/directoryselector-hidden-toggle
...
Add hidden item toggle to directory/file selectors
2022-10-24 16:28:47 +09:00
Dean Herbert
14704fd07c
Fix crash when exiting seeding editor too soon
...
Closes https://github.com/ppy/osu/issues/20783 .
2022-10-24 16:08:50 +09:00
Dean Herbert
247cf589aa
Merge branch 'master' into directoryselector-hidden-toggle
2022-10-24 15:33:10 +09:00
Dean Herbert
995216cced
Merge pull request #20819 from Joppe27/taiko-kiai-flashing
...
Implement taiko hitobject kiai flashing
2022-10-24 15:31:13 +09:00
Dan Balasescu
83dd295b22
Merge pull request #20899 from peppy/fix-tournament-point-deserialisation
...
Fix point conversion not using invariant culture
2022-10-24 13:32:48 +09:00
Dean Herbert
889c2978d7
Fix point conversion not using invariant culture
...
This was only the case in a fallback path (ie. when the user provides a
`json` file with an old or computed format from an external source).
Closes #20844 .
2022-10-24 13:15:00 +09:00
Bartłomiej Dach
4ad669e729
Merge pull request #20811 from cdwcgt/taiko-compose
...
Fix placement preview not showing in timeline of osu!taiko editor
2022-10-23 20:27:54 +02:00
Bartłomiej Dach
819e598d23
Merge branch 'master' into taiko-compose
2022-10-23 19:54:20 +02:00
Bartłomiej Dach
a094225bc5
Merge pull request #20850 from peppy/fix-editor-distanct-snap-sv-accounting
...
Change distance snap to never account for slider velocity
2022-10-23 19:20:15 +02:00
Bartłomiej Dach
3a6a87db0f
Merge branch 'master' into fix-editor-distanct-snap-sv-accounting
2022-10-23 18:42:08 +02:00
Dean Herbert
bff82a71a9
Merge pull request #20872 from Susko3/fix-android-startup-crash
...
Downgrade AutoMapper to fix Android startup crash
2022-10-23 12:00:45 +09:00
Susko3
a35026d537
Downgrade AutoMapper to fix Android startup crash
2022-10-22 23:29:44 +02:00
cdwcgt
f14d871f97
let TaikoSpan show in timeline before placed
2022-10-23 01:32:22 +09:00
cdwcgt
a74e873b98
remove useless using
2022-10-23 01:13:29 +09:00
Dean Herbert
c195c13bcc
Merge pull request #20852 from peppy/update-framework
...
Update framework
2022-10-22 23:52:44 +09:00
Dean Herbert
9155fcf3cb
Update framework
2022-10-22 23:25:08 +09:00
Dean Herbert
3d37a67590
Update framework
2022-10-22 14:15:17 +09:00
Bartłomiej Dach
9ca41b3054
Merge pull request #20855 from frenzibyte/ban-char-lower-upper
...
Ban `char.ToLower()`/`char.ToUpper()` as well for better safety
2022-10-21 23:20:16 +02:00
Bartłomiej Dach
2d00658bf1
Merge branch 'master' into ban-char-lower-upper
2022-10-21 22:08:29 +02:00
Salman Ahmed
0491b1fd18
Merge branch 'master' into update-framework
2022-10-21 22:39:56 +03:00
Salman Ahmed
0148f25171
Merge pull request #20848 from peppy/fix-settings-volume-sliders-double-samples
...
Fix adjusting volume via settings playing tick samples twice
2022-10-21 22:07:16 +03:00
Salman Ahmed
678bfb2caa
Ban char.ToLower()/char.ToUpper() as well for better safety
2022-10-21 20:56:34 +03:00
Dean Herbert
c1ed775deb
Update framework
2022-10-21 23:36:16 +09:00
Dean Herbert
bace3df4ca
Update test assertions in line with change
2022-10-21 22:58:10 +09:00
Dean Herbert
7dc03097ff
Change distance snap to never account for slider velocity
...
This is a nuanced detail that was implemented incorrectly from the
outset. When mapping, generally a mapper chooses the distance spacing
with no regard to the SV. It has always been common to have a lower
or higher distance spacing than SV, but with the way the lazer editor
has worked, the SV was multiplied into the distance snap grid display,
incorectly changing its spacing depending on the "reference object"
(which is usually the previous hitobject chronologically).
2022-10-21 21:51:24 +09:00
Dean Herbert
447d420c99
Fix adjusting volume via settings playing tick samples twice
2022-10-21 21:03:39 +09:00
Dean Herbert
4803f606c2
Merge pull request #20845 from nekodex/settings-sidebar-sfx
...
Add unique hover/select samples to settings sidebar buttons
2022-10-21 20:56:58 +09:00
Dean Herbert
8b74b5807f
Update resources
2022-10-21 20:53:37 +09:00
Dan Balasescu
bbdeec1630
Merge pull request #20846 from peppy/reduce-solo-scores-legacy-serialisation
...
Avoid serialising some more properties of `SoloScoreInfo` unless present
2022-10-21 20:38:49 +09:00
Dean Herbert
bcd65f3c3c
Merge pull request #20827 from goodtrailer/smoke-uncapped-v3
...
Remove smoke point maximum
2022-10-21 19:58:49 +09:00
Dean Herbert
af84f708b7
Avoid serialising some more properties of SoloScoreInfo unless present
2022-10-21 19:30:35 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons
2022-10-21 18:06:38 +09:00
Alden Wu
23b7b9013e
Change smoke quadbatch growth factor to 2 from 1.5
2022-10-20 23:37:05 -07:00
Dean Herbert
d441e98af7
Adjust kiai flash period in line with stable
2022-10-21 15:34:25 +09:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
...
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
Dean Herbert
7dbd6e2469
Merge branch 'master' into taiko-kiai-flashing
2022-10-21 12:48:35 +09:00
Dean Herbert
39099e293d
Merge pull request #20840 from Joehuu/fix-skin-toolbox-component-button
...
Fix skin toolbox component button not playing hover/click sounds
2022-10-21 10:03:18 +09:00
Joseph Madamba
bf4a91f1f0
Fix skin toolbox component button not playing hover/click sounds
2022-10-20 13:16:03 -07:00
Dean Herbert
5c13c443ff
Fix incorrect fallback logic
...
Regressed when attempting to share implementation of binary search.
2022-10-20 23:08:44 +09:00
Dean Herbert
26860a903e
Refactor implementation to support hitobjects nested multiple levels deep
2022-10-20 22:30:30 +09:00
cdwcgt
42bb9dc3e3
revert EndPlacement change
2022-10-20 22:17:26 +09:00
