Dean Herbert
27a81dfb9f
Merge pull request #20270 from OliBomby/fix-selectionblueprint-order
...
Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes
2022-09-13 17:18:58 +09:00
Dan Balasescu
53ac9dbc38
Merge branch 'master' into notification-fling
2022-09-13 17:07:16 +09:00
Dan Balasescu
08f0056b37
Merge pull request #20265 from peppy/fix-song-progress-invalidations
...
Fix `SongProgress` invalidating too often
2022-09-13 16:51:11 +09:00
Dan Balasescu
0e2155303e
Merge branch 'master' into fix-song-progress-invalidations
2022-09-13 16:07:05 +09:00
Dan Balasescu
62971ef1cc
Merge pull request #20281 from peppy/fix-drawable-ruleset-dependencies
...
Fix null considerations in `DrawableRulesetDependencies`
2022-09-13 15:26:29 +09:00
Dean Herbert
608c893b23
Add basic test guarantees
2022-09-13 15:03:13 +09:00
Dan Balasescu
ea07f6692c
Merge pull request #20283 from peppy/fix-multi-spectator-player-null-ref
...
Fix potential crash if multiplayer spectator load is aborted early
2022-09-13 14:59:36 +09:00
Dean Herbert
f53507828c
Rename event to be more generic (and add comprehensive xmldoc)
2022-09-13 14:59:30 +09:00
Dean Herbert
ac034bffeb
Fix potential crash if multiplayer spectator load is aborted early
2022-09-13 14:21:54 +09:00
Dean Herbert
0fcd9e02f6
Fix skin dropdown not updating correctly when skin is changed externally
2022-09-13 14:01:40 +09:00
Dean Herbert
d368f37c3a
Remove redundant second Current set operation
2022-09-13 13:50:59 +09:00
Dean Herbert
6bf6b7e125
Fix null considerations in DrawableRulesetDependencies
2022-09-13 13:13:38 +09:00
Dean Herbert
9c2b0efbc7
Merge pull request #20262 from smoogipoo/scoreprocessor-computeaccuracy
...
Add `ScoreProcessor.ComputeAccuracy()`
2022-09-13 11:55:02 +09:00
Salman Ahmed
34463c3956
Merge pull request #20260 from peppy/fix-skin-animation-edge-case
...
Fix new-style legacy skins with animated judgements not adding correct transforms
2022-09-13 04:20:09 +03:00
Salman Ahmed
0ca4be5e5b
Fix one more inspection
2022-09-13 03:45:31 +03:00
OliBomby
fd48249eef
fix with new event
2022-09-13 02:20:52 +02:00
Salman Ahmed
69b9bae3b3
Merge branch 'master' into scoreprocessor-computeaccuracy
2022-09-13 03:09:52 +03:00
Salman Ahmed
a6f68e4a90
Fix NRT inspections
2022-09-13 03:08:13 +03:00
OliBomby
a1f4724685
moved the location of the tests
2022-09-13 01:38:29 +02:00
Salman Ahmed
a20c97d072
Merge branch 'master' into fix-skin-animation-edge-case
2022-09-13 02:26:55 +03:00
Salman Ahmed
5fba21d658
Rename parameter to clarify purpose
2022-09-13 02:21:01 +03:00
OliBomby
718f8c4ee2
revert the fix
2022-09-13 01:09:42 +02:00
Salman Ahmed
07f577a0c6
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-13 01:39:21 +03:00
Salman Ahmed
a5b962d9a3
Add failing test case
2022-09-13 01:37:23 +03:00
OliBomby
8400de4b2e
invoking hitobject updated before invoking removed
2022-09-12 17:50:11 +02:00
ansel
8cbc0502ae
Inline CalculateEffect
2022-09-12 15:51:18 +03:00
Dean Herbert
88107108ee
Add ability to flick notifications to the right to store for later
2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling
2022-09-12 20:09:21 +09:00
Dean Herbert
2b4b14ca99
Fix SongProgress invalidating too often
...
This regressed with https://github.com/ppy/osu/pull/19556 . Rather than
try and figure whether that new container needs to handle size
differently, this is a simple solution.
Height was taken from a runtime check (maxes out at about 14.5).
Closes #20235 .
2022-09-12 20:06:53 +09:00
OliBomby
f48a743890
Merge remote-tracking branch 'upstream/master' into fix-selectionblueprint-order
2022-09-12 12:52:32 +02:00
Dean Herbert
f31deaef7c
Simplify skin bindable flow
...
Now, nothing touches the configuration apart from `OsuGame`, making
everything else flow better and avoid weird cyclic set bugs.
Closes https://github.com/ppy/osu/issues/20234 .
2022-09-12 19:51:50 +09:00
OliBomby
837cc76019
Create TestSceneSelectionBlueprintDeselection.cs
2022-09-12 12:50:16 +02:00
Dan Balasescu
00c9763d67
Merge pull request #20261 from peppy/cancel-in-progress-ci
...
Cancel in progress CI runs when new commits are pushed
2022-09-12 19:47:51 +09:00
Dan Balasescu
5bd0be14ed
Merge pull request #20259 from peppy/fix-changelog-crash
...
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 19:47:21 +09:00
Dan Balasescu
7f291552c7
Merge pull request #20258 from peppy/fix-slider-leak-editor
...
Fix bindable event binds to `HitObject` directly
2022-09-12 19:47:10 +09:00
Dean Herbert
431e84f992
Cancel in progress CI runs when new commits are pushed
...
Same as https://github.com/ppy/osu-web/pull/9268 .
Should hopefully help with organisation concurrent limits.
2022-09-12 19:09:46 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
...
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
f56f6545c0
Add test coverage of flinging
2022-09-12 19:06:09 +09:00
Dean Herbert
d92e000fe6
Fix flinging a notification not correctly running Close
2022-09-12 19:00:03 +09:00
Dean Herbert
4ee3e8f087
Don't play fling animation when activating a notification
2022-09-12 18:57:18 +09:00
Dean Herbert
c064853751
Merge branch 'master' into notification-fling
2022-09-12 18:56:15 +09:00
Dean Herbert
e29f5cb456
Fix new-style legacy skins with animated judgements not adding correct transforms
...
Closes #16173 .
2022-09-12 18:54:06 +09:00
Dan Balasescu
27d4016ccb
Add ScoreProcessor.ComputeAccuracy()
2022-09-12 18:37:55 +09:00
Dan Balasescu
4b37330316
Merge pull request #20248 from acid-chicken/fix/stats/td
...
Fix new hit distribution graph didn't account for size changes
2022-09-12 18:11:18 +09:00
Dan Balasescu
b0980a7bf1
Merge pull request #20215 from peppy/notification-dismiss
...
Allow dismissing notifications without performing action using middle / right click
2022-09-12 18:03:06 +09:00
Dan Balasescu
3cfacb5e39
Merge pull request #20257 from peppy/update-button-show-login
...
Show login overlay when attempting to update a beatmap while logged out
2022-09-12 17:51:45 +09:00
Dean Herbert
58c1ea0321
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 17:51:15 +09:00
Dean Herbert
89e128c0f3
Fix bindable event binds to HitObject directly
2022-09-12 17:35:56 +09:00
Dean Herbert
91c415f29b
Fix nullability oversight in ManiaRulesetConfigManager
2022-09-12 16:58:20 +09:00
Dean Herbert
d561fcb126
Don't trigger fling animation when Close is triggered by non-user action
2022-09-12 16:54:25 +09:00
