11 Commits

• Refactor TestSceneScreenFooter to test entire OsuScreens (#36718)

  Part of the `ScreenFooter` refactor, which intends to move the footer
  content handling to `OsuScreen`. This commit updates the `ScreenFooter`
  test to operate on entire `OsuScreen`s, in order to better test the
  entire flow of pushing a screen, and having it create and add its own
  content to the footer.
  
  This should be 80-90% identical to the original test case structure
  wise, just that instead of manually manipulating the footer with
  `SetButtons()`, various screens with the appropriate buttons are being
  moved around the screen stack.
  
  Additionally this adds some more tests handling common use cases, as
  well as removes `TestLoadOverlayAfterFooterIsDisplayed()`, since as far
  as I understand the behaviour described in it doesn't actually happen in
  production code. From what I can see, Screens instantiate their overlays
  in `load()`, and then register them in `LoadComplete()`. There seems to
  be no case where a `ShearedOverlayContainer` is created in the middle of
  a screen's lifecycle.

  Krzysztof Gutkowski · 2026-03-01 22:36:07 +09:00
  b88cba0829
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5
• Add test coverage
  Salman Alshamrani · 2025-03-22 22:15:02 -04:00
  b6068e6e29
• Change ModSelectOverlay.ShowPresets to init
  Dean Herbert · 2025-03-04 22:32:13 +09:00
  dff354247e
• Add failing test case for edge case
  Salman Ahmed · 2024-07-10 11:51:49 +03:00
  f0a7a3f856
• Ask for VisibilityContainer explicitly
  Salman Ahmed · 2024-07-10 11:14:22 +03:00
  002679ebb0
• Remove local footer from ShearedOverlayContainer
  Salman Ahmed · 2024-06-30 06:50:36 +03:00
  e57a0029f1
• Add test coverage
  Salman Ahmed · 2024-06-30 06:50:22 +03:00
  900d15e777
• Move screen footer to OsuGame
  Salman Ahmed · 2024-05-16 07:48:58 +03:00
  03220598b8
• Clean up screen footer test scene
  Salman Ahmed · 2024-05-16 07:48:10 +03:00
  95840672cb
• Rename and move footer classes to appropriate places
  Salman Ahmed · 2024-05-16 04:41:16 +03:00
  21f5d891bb