828 Commits

• Allow reporting users from their profile page (#36335)

  This PR refactors the report popover to have an optional confirmation
  message after completing the request. This was initially meant for
  #32584, but then I realized I can first test it out on the user
  profiles, so I've implemented it here as well. Can be reviewed commit by
  commit.
  
  
  
  https://github.com/user-attachments/assets/cd59c560-c824-4a5e-bab6-5ecbf5125af1
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-05-05 19:49:24 +09:00
  2006485d60
• Use placeholder user models in ranked play if online lookups fail (#37455)

  Suboptimal? Sure. But the primary goal is not to crash. Crashing is a
  failure of the game programmer.
  
  Better can be done later.
  
  Remedies/fixes https://github.com/ppy/osu/issues/37421.

  Bartłomiej Dach · 2026-04-21 22:16:45 +09:00
  71356a9455
• Replicate osu!web logic in display of matchmaking badge (#37303)
  Dan Balasescu · 2026-04-15 15:49:10 +09:00
  4fd4544442
• Add matchmaking profile badge (#37241)

  Using the same styling as osu!web + daily challenge.
  
  <img width="1920" height="1034" alt="Screenshot_20260409-164600"
  src="https://github.com/user-attachments/assets/97e2270e-af9f-478d-b2d6-c9fb8be16720"
  />
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2026-04-09 19:25:21 +09:00
  93b7c3324d
• Add ability to search for users (#37225)

  This was a private request for roundtable event usage. It’s also a
  common feature request, so I decided to spend a bit of time getting this
  working well-enough.
  
  
  https://github.com/user-attachments/assets/acceb57f-2979-43d0-9fc2-33e977bd2dd5
  
  
  ---
  
  ### Delay loading spinner / loading layer initial load briefly to avoid
  flickering
  
  There's cases in this overlay where loading takes a few milliseconds.
  The loading spinner gets annoying. This also happens elsewhere, so this
  could be considered a global fix. Separate PR? probably...
  
  ### Ingest loading state of dashboard child content to show more correct
  loading layer
  
  Each display had their own loading layer implementation, but this is
  already too deep (inside the scroll content) and doesn't display great
  when for instance, results don't take up the full screen height.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-04-07 14:14:49 +02:00
  c570db6c40
• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• Merge branch 'master' into tags-broken
  Dean Herbert · 2026-03-04 19:50:33 +09:00
  459d5e8a45
• Only show user tags above threshold by default
  Bartłomiej Dach · 2026-03-04 10:34:35 +01:00
  9b55e1dfdb
• Add bool flag for checking tag vote threshold & utilise as required

  Closes https://github.com/ppy/osu/issues/36453.
  
  My omission was in assuming that web was going to start filtering out
  the tags below the threshold from API responses, which is not the case.
  
  Whether or not the consumers want or not to display tags below threshold
  is subjective. I figured that the matchmaking card tooltip might want to
  display below threshold but I dunno.

  Bartłomiej Dach · 2026-03-03 13:03:33 +01:00
  d9e182230d
• Move constant closer to helper
  Bartłomiej Dach · 2026-03-03 13:03:33 +01:00
  65b49137ee
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Refactor UpdateableTeamFlag for use on team overlay (#36286)

  Part of #32584.
  
  Very much inspired by the respective component for displaying profile
  pictures on the user overlay
  
  * allow disabling interactivity/tooltips
  * add option to show placeholder on null team instead of hiding
  component entirely
  * move setting corner radius out to respective parent components to
  allow for easier overriding

  Krzysztof Gutkowski · 2026-02-10 23:18:36 +09:00
  50426eb3c8
• Add support for global rank parsing in /users/ batch lookups

  See https://github.com/ppy/osu-web/pull/12651 for web-side
  implementation.
  To be used to fix
  https://github.com/ppy/osu/pull/33649/changes#diff-32784a778b34c671e1f72c00e1f4161a5e774e849aae5631ee71b31fc32e5d42R218
  (have tested this works there).
  
  Use simple set-get rather than transforming to `APIUser.Statistics`

  Dean Herbert · 2026-01-09 16:19:52 +09:00
  23c68cbfea
• Show vote count in tag tooltip
  Dan Balasescu · 2025-12-29 17:47:35 +09:00
  2e324fe856
• Move top user tags enumeration to helper
  Dan Balasescu · 2025-12-29 15:43:43 +09:00
  60d9c358b8
• Fix test failures

  This is dodgy as hell but `ShortName` is completely derived from
  `OnlineID` anyway so there should be no valid reason to ever attempt to
  serialise it anyway.

  Bartłomiej Dach · 2025-11-24 12:52:57 +01:00
  9c981a52f8
• Fix incorrect handling of user verification failure response (#35629)

  `VerificationFailureResponse.RequiredSessionVerificationMethod` not
  being nullable means that if it was missing in the verification
  response, it would not be `null` but default to `TimedOneTimePassword`
  instead, therefore showing TOTP-related error messages to users that
  never enabled it rather than the user-facing message they were supposed
  to.
  
  Most easily tested on a local full-stack environment with
  
  ```diff
  diff --git a/app/Libraries/SessionVerification/MailState.php b/app/Libraries/SessionVerification/MailState.php
  index 305a2794ec0..3c2d15f335b 100644
  --- a/app/Libraries/SessionVerification/MailState.php
  +++ b/app/Libraries/SessionVerification/MailState.php
  @@ -14,7 +14,7 @@ use Carbon\CarbonImmutable;
  
   class MailState
   {
  -    private const KEY_VALID_DURATION = 600;
  +    private const KEY_VALID_DURATION = 10;
  
       public readonly CarbonImmutable $expiresAt;
       public readonly string $key;
  ```
  
  applied so that you don't have to wait 10 minutes to trigger the
  failure.

  Bartłomiej Dach · 2025-11-06 23:21:26 +09:00
  933fbd274d
• Implement request & response for fetching logged in user's favourite beatmap sets
  Bartłomiej Dach · 2025-10-24 08:36:13 +02:00
  b600860540
• Fix solo leaderboard sometimes not showing user position while it technically could

  The "partial" leaderboard logic in `SoloGameplayLeaderboardProvider`
  always assumed the online fetch would request 50 scores, which is no
  longer the case after https://github.com/ppy/osu/pull/33100.

  Bartłomiej Dach · 2025-10-23 08:53:29 +02:00
  ca8fc81a7e
• Add client-side support for TOTP authentication

  Closes https://github.com/ppy/osu/issues/34972.

  Bartłomiej Dach · 2025-09-16 10:36:34 +09:00
  37f58e5c80
• Store pause timestamps (rounded to ms) instead of general count
  Bartłomiej Dach · 2025-07-22 09:26:12 +02:00
  d8900defd3
• Merge branch 'master' into store-pause-count
  Bartłomiej Dach · 2025-07-22 08:44:16 +02:00
  b08ba3c9e4
• Adjust behavior of beatmap set with deleted author
  eyhn · 2025-07-14 20:58:03 +08:00
  3eca3897ed
• Use comment instead of xmldoc
  Dan Balasescu · 2025-07-14 16:04:43 +09:00
  64f6fce918
• Fix typo
  eyhn · 2025-07-12 23:35:54 +08:00
  2b26506c4c
• Fix failed to load beatmaps host by deleted user
  eyhn · 2025-07-12 21:51:10 +08:00
  39808970d3
• Pass along pause count when submitting score
  Bartłomiej Dach · 2025-07-07 11:00:31 +02:00
  4cdbe7e195
• Reword documentation
  Salman Alshamrani · 2025-06-20 20:21:44 +03:00
  b603a88043
• Fix beatmap set author information
  eyhn · 2025-06-20 16:23:18 +08:00
  4177dc395b
• Add support for reading release stream from assembly version
  Dean Herbert · 2025-06-13 18:52:22 +09:00
  3291a4cb7b
• Fix profile score display logic not matching website

  Reported via e-mails.
  
  The web-side change that wasn't ported here is
  https://github.com/ppy/osu-web/pull/11151. I wanted to port it at the
  time but then ran into issues because this logic should *ideally* also
  be applied to the beatmap set overlay leaderboards, but those are
  hard-glued to `ScoreInfo`, cannot be easily weaned off it to use
  `SoloScoreInfo` instead, and I did not want to make `ScoreInfo` even
  more of a mess than it already is.
  
  This time I'm just ignoring it and adding a TODO instead because I have
  no confidence I will get review eyes on any refactor of the beatmap set
  overlay. All I'll say that such refactors would have potentially
  beneficial effects on results screens too which also (ab)use
  `ScoreInfo`.

  Bartłomiej Dach · 2025-05-26 13:11:41 +02:00
  90bc8865c9
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Fetch more scores for supporter scope leaderboards

  Which are: global and team leaderboards with mods, and friends and
  country leaderboards.
  
  Only attempting this because of
  https://github.com/ppy/osu/issues/31056#issuecomment-2719787189. Not
  sure if this addresses the concern 🤷

  Bartłomiej Dach · 2025-05-12 09:54:56 +02:00
  934c2440cc
• Merge branch 'master' into feat/block-users
  Dean Herbert · 2025-04-23 13:55:18 +09:00
  c5748a0eae
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Update API beatmap model to include user play count
  Salman Alshamrani · 2025-04-11 02:24:38 +09:00
  6bb84e4364
• Update scores request to move away from old endpoint
  Bartłomiej Dach · 2025-04-10 09:46:46 +02:00
  17bcc28429
• Add support for ruleset-specific user tags

  Follow-up from https://github.com/ppy/osu-web/pull/12059

  Bartłomiej Dach · 2025-04-02 13:12:49 +02:00
  22f2c6f7b9
• Implement blocking users from context menu
  Zihad · 2025-03-27 22:37:37 +06:00
  afce72896f
• Show user tags on beatmap set overlay

  Resolves one part of
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928
  
  A few caveats:
  
  - Layout is slightly different than web intentionally. Web does things
    that I think will be difficult to reproduce or just plain look bad in
    client, such as:
  
    - On web, the metadata info box has 200px min height and 300px max
      height. I just hardcoded 300 units.
  
    - On web, user tags and mapper tags are individually scrollable, and
      the amount of space taken up by each is calculated in a way that
      is - as far as I can tell - indeterminate, and probably influenced
      by some flexbox magic. I just made the entire thing scrollable
      instead.
  
  - Because song select shares controls with the beatmap set overlay, now
    song select says "Mapper Tags" in the header instead of just "Tags"
    too. I think this is fine, because people asked for user tags to be
    shown in song select too.
  
  - Search query syntax lifted from
    https://github.com/ppy/osu-web/pull/12047.
  
  - Using hardcoded English strings for now, will update to the
    translations after the next osu-resources localisations update.

  Bartłomiej Dach · 2025-03-27 14:58:03 +01:00
  7bb97d5796
• Rename APIUser.IsOnline and add better documentation around online checks
  Dean Herbert · 2025-03-19 15:01:40 +09:00
  b17ec5e69d
• Merge branch 'master' into set-guest-update
  Bartłomiej Dach · 2025-03-17 12:26:41 +01:00
  05366c2397
• Fix tag add request using wrong method
  Dean Herbert · 2025-03-17 12:20:37 +09:00
  f9078b98dd
• Switch add beatmap tag request to using path paramx

  See https://github.com/ppy/osu-web/pull/11999.

  Bartłomiej Dach · 2025-03-13 12:07:19 +01:00
  607c83abd6
• Fix namespace
  Dean Herbert · 2025-03-08 22:18:08 +09:00
  2272ca1ae5
• Update property name in line with web changes
  Bartłomiej Dach · 2025-03-05 08:05:15 +01:00
  3661107e4f
• Add UI for assigning custom tags to beatmaps

  Visual part for https://github.com/ppy/osu/issues/31913. Opening
  separately for appropriate visual UI adjustments.
  
  Also mostly ready to be hooked up to the results screen, pending merge
  of https://github.com/ppy/osu-web/pull/11951.

  Bartłomiej Dach · 2025-03-04 13:08:02 +01:00
  c051ff84d2
• Fix unable to join multiplayer rooms with many users
  Dan Balasescu · 2025-03-04 12:34:11 +09:00
  3024a98658
• update guest difficulty display to consistent with the web page
  cdwcgt · 2025-02-20 21:49:30 +08:00
  9d7b01bcd4
• Send "notify on discussion replies" setting value in beatmap creation request
  Bartłomiej Dach · 2025-02-19 12:45:37 +01:00
  687c9d6e17