1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-08 13:47:52 +08:00
Commit Graph

56780 Commits

Author SHA1 Message Date
sw1tchbl4d3
f4db2c1ff4 Add test 2022-10-22 22:38:04 +02:00
cdwcgt
f14d871f97
let TaikoSpan show in timeline before placed 2022-10-23 01:32:22 +09:00
cdwcgt
a74e873b98
remove useless using 2022-10-23 01:13:29 +09:00
Dean Herbert
c195c13bcc
Merge pull request #20852 from peppy/update-framework
Update framework
2022-10-22 23:52:44 +09:00
Dean Herbert
9155fcf3cb Update framework 2022-10-22 23:25:08 +09:00
Dean Herbert
3d37a67590 Update framework 2022-10-22 14:15:17 +09:00
Salman Ahmed
b0a4cd4f30 Inline content creation in base add method 2022-10-22 03:43:14 +03:00
Salman Ahmed
90a9961a69 Add visual test case for report button
Makes it much easier to test button/popover design changes
2022-10-22 02:50:59 +03:00
Salman Ahmed
6c82bc36ed Encapsulate report logic inside button implementation
Avoids complicating the `DrawableComment` class, and allows for isolated
testability.
2022-10-22 02:48:27 +03:00
Salman Ahmed
9b5e35d599 Remove dependency on DrawableComment from report popover and simplify logic
Allows for testing the button and popover in isolation.
2022-10-22 02:47:33 +03:00
Salman Ahmed
081cf1cc47 Adjust comment report popover design 2022-10-22 02:45:31 +03:00
Bartłomiej Dach
9ca41b3054
Merge pull request #20855 from frenzibyte/ban-char-lower-upper
Ban `char.ToLower()`/`char.ToUpper()` as well for better safety
2022-10-21 23:20:16 +02:00
Bartłomiej Dach
2d00658bf1
Merge branch 'master' into ban-char-lower-upper 2022-10-21 22:08:29 +02:00
Salman Ahmed
0491b1fd18
Merge branch 'master' into update-framework 2022-10-21 22:39:56 +03:00
Salman Ahmed
0148f25171
Merge pull request #20848 from peppy/fix-settings-volume-sliders-double-samples
Fix adjusting volume via settings playing tick samples twice
2022-10-21 22:07:16 +03:00
Salman Ahmed
678bfb2caa Ban char.ToLower()/char.ToUpper() as well for better safety 2022-10-21 20:56:34 +03:00
Dean Herbert
c1ed775deb Update framework 2022-10-21 23:36:16 +09:00
Dean Herbert
f516e32949 Improve UI a bit 2022-10-21 23:35:53 +09:00
Dean Herbert
bb921ff9a7 Fix incorrect current DS value when inside a slider 2022-10-21 23:35:47 +09:00
ansel
15aeb4a137 Display text in buttons flow instead of toast 2022-10-21 17:25:41 +03:00
Dean Herbert
f6de366766 Combine display and button into one control 2022-10-21 23:21:07 +09:00
Dean Herbert
645a84b1d6 Display current distance snap and add button to update to use it 2022-10-21 22:58:36 +09:00
Dean Herbert
bace3df4ca Update test assertions in line with change 2022-10-21 22:58:10 +09:00
Dean Herbert
7dc03097ff Change distance snap to never account for slider velocity
This is a nuanced detail that was implemented incorrectly from the
outset. When mapping, generally a mapper chooses the distance spacing
with no regard to the SV. It has always been common to have a lower
or higher distance spacing than SV, but with the way the lazer editor
has worked, the SV was multiplied into the distance snap grid display,
incorectly changing its spacing depending on the "reference object"
(which is usually the previous hitobject chronologically).
2022-10-21 21:51:24 +09:00
Dean Herbert
447d420c99 Fix adjusting volume via settings playing tick samples twice 2022-10-21 21:03:39 +09:00
Dean Herbert
4803f606c2
Merge pull request #20845 from nekodex/settings-sidebar-sfx
Add unique hover/select samples to settings sidebar buttons
2022-10-21 20:56:58 +09:00
Dean Herbert
8b74b5807f Update resources 2022-10-21 20:53:37 +09:00
Dan Balasescu
bbdeec1630
Merge pull request #20846 from peppy/reduce-solo-scores-legacy-serialisation
Avoid serialising some more properties of `SoloScoreInfo` unless present
2022-10-21 20:38:49 +09:00
Dean Herbert
bcd65f3c3c
Merge pull request #20827 from goodtrailer/smoke-uncapped-v3
Remove smoke point maximum
2022-10-21 19:58:49 +09:00
Dean Herbert
1e09a21279 Remove unused using statement 2022-10-21 19:55:58 +09:00
Dean Herbert
af84f708b7 Avoid serialising some more properties of SoloScoreInfo unless present 2022-10-21 19:30:35 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons 2022-10-21 18:06:38 +09:00
Dean Herbert
ca91f9f716 Don't allow two momentary toggles at the same time to avoid edge cases 2022-10-21 17:16:55 +09:00
Dean Herbert
16f5c2a7c6 Apply same fix to osu!catch composer 2022-10-21 17:15:36 +09:00
Dean Herbert
ef990c55ca Handle distance/grid toggles based on key type, rathern than individual left/right 2022-10-21 16:11:19 +09:00
Dean Herbert
6cdfddea62 Always enable distance spacing when adusting distance space multiplier 2022-10-21 16:10:55 +09:00
Alden Wu
23b7b9013e Change smoke quadbatch growth factor to 2 from 1.5 2022-10-20 23:37:05 -07:00
Dean Herbert
d441e98af7 Adjust kiai flash period in line with stable 2022-10-21 15:34:25 +09:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
Dean Herbert
7dbd6e2469
Merge branch 'master' into taiko-kiai-flashing 2022-10-21 12:48:35 +09:00
Dean Herbert
39099e293d
Merge pull request #20840 from Joehuu/fix-skin-toolbox-component-button
Fix skin toolbox component button not playing hover/click sounds
2022-10-21 10:03:18 +09:00
Salman Ahmed
27ce3d8342 Fix input settings not displaying in visual test browser 2022-10-21 01:52:19 +03:00
Joseph Madamba
bf4a91f1f0 Fix skin toolbox component button not playing hover/click sounds 2022-10-20 13:16:03 -07:00
ansel
81bdf716ef Change test 2022-10-20 19:56:00 +03:00
ansel
0ef903230c Make report button a separate component 2022-10-20 18:47:42 +03:00
ansel
da4f04ace7 Make dropdown not resize 2022-10-20 18:22:55 +03:00
ansel
635900085c Disable button when there is no text 2022-10-20 18:12:20 +03:00
ansel
ed39481932 Use another string for title 2022-10-20 18:11:35 +03:00
Dean Herbert
5c13c443ff Fix incorrect fallback logic
Regressed when attempting to share implementation of binary search.
2022-10-20 23:08:44 +09:00
Dean Herbert
26860a903e Refactor implementation to support hitobjects nested multiple levels deep 2022-10-20 22:30:30 +09:00