1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-19 05:12:55 +08:00
Commit Graph

10 Commits

Author SHA1 Message Date
Dean Herbert
1eed2436e6 Clean up unused resolved properties 2021-12-03 18:49:49 +09:00
Dean Herbert
f283770f34 Update mock RulesetInfo usage to set OnlineID instead of ID 2021-11-24 15:50:26 +09:00
Bartłomiej Dach
15feb17da8
Change difficulty cache storage type to nullable
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
Bartłomiej Dach
43b3845970
Remove redundant string interpolation 2021-08-21 16:35:40 +02:00
Bartłomiej Dach
f642546d6a
Add failing test case 2021-08-21 15:50:33 +02:00
Bartłomiej Dach
479401e533
Add option to set own computation function in test 2021-08-21 15:50:32 +02:00
Salman Ahmed
73b40a6244 Switch to until step to account for asynchronous operations 2021-08-20 05:29:30 +03:00
Salman Ahmed
d98742522b Remove unused using directive 2021-08-20 04:40:03 +03:00
Salman Ahmed
4d9c415e73 Remove unnecessary queue in beatmap difficulty cache tests 2021-08-20 04:37:35 +03:00
Salman Ahmed
a329216ff3 Convert beatmap difficulty test into test scene and extend coverage 2021-08-17 05:46:11 +03:00