1211 Commits

• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Switch multiplayer to use song select v2 (#36747)

  Tests pass and seems to work. Need to do a bit more self-testing for
  higher confidence, but in theory..
  
  Closes https://github.com/ppy/osu/issues/34035.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-03 13:41:48 +09:00
  d27d0f40c1
• Refactor TestSceneScreenFooter to test entire OsuScreens (#36718)

  Part of the `ScreenFooter` refactor, which intends to move the footer
  content handling to `OsuScreen`. This commit updates the `ScreenFooter`
  test to operate on entire `OsuScreen`s, in order to better test the
  entire flow of pushing a screen, and having it create and add its own
  content to the footer.
  
  This should be 80-90% identical to the original test case structure
  wise, just that instead of manually manipulating the footer with
  `SetButtons()`, various screens with the appropriate buttons are being
  moved around the screen stack.
  
  Additionally this adds some more tests handling common use cases, as
  well as removes `TestLoadOverlayAfterFooterIsDisplayed()`, since as far
  as I understand the behaviour described in it doesn't actually happen in
  production code. From what I can see, Screens instantiate their overlays
  in `load()`, and then register them in `LoadComplete()`. There seems to
  be no case where a `ShearedOverlayContainer` is created in the middle of
  a screen's lifecycle.

  Krzysztof Gutkowski · 2026-03-01 22:36:07 +09:00
  b88cba0829
• Merge branch 'master' into cycle-skins
  Dean Herbert · 2026-01-29 02:19:36 +09:00
  487347dac6
• Add envvar to disble error reporting

  https://github.com/ppy/osu/discussions/31832#discussioncomment-15555080

  Dean Herbert · 2026-01-22 18:12:27 +09:00
  6693307064
• Add skin cycling with shortcuts for next and previous skin
  ArijanJ · 2026-01-19 12:59:21 +01:00
  65f7037e84
• Make error message string construction actually understandable
  Dean Herbert · 2026-01-13 16:10:57 +09:00
  d3ed93280a
• Localise notification in OsuGame
  Denis Titovets · 2026-01-11 16:53:44 +03:00
  8a21c6814c
• Isolate footer behaviour to ScreenStackFooter, support subscreens
  Dan Balasescu · 2025-10-17 19:01:28 +09:00
  db3cc583e6
• Adjust matchmaking naming, namespaces, xmldoc (#35123)

  * Adjust matchmaking naming, namespaces, xmldoc
  
  * Change partial filenames to use `.` instead of `_` separator

  Dean Herbert · 2025-09-26 12:17:28 +09:00
  e1ba1b45b0
• Add matchmaking
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  111b98ef8e
• Centralise logging of non-official builds
  Dan Balasescu · 2025-07-15 13:19:00 +09:00
  35a3186bf0
• Write only fixed release streams back to config
  Dan Balasescu · 2025-07-15 13:18:56 +09:00
  55befe9efb
• Fix potential leak from multiple games on the same host
  Dan Balasescu · 2025-07-09 03:37:02 +09:00
  2f374555dc
• Fix leak from no unbind from static event
  Dan Balasescu · 2025-07-08 00:23:38 +09:00
  d80e4b7960
• Fix potential test deadlock

  Disposal woes.

  Dean Herbert · 2025-07-01 20:19:46 +09:00
  01f5068535
• Fix mod select not being hidden when CloseAllOverlays is called
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  7fcbda6cd0
• Fix mod button still working after gameplay start if player is not fully loaded
  Dean Herbert · 2025-06-17 16:49:52 +09:00
  e74f687c30
• Transfer release stream setting from running build
  Dean Herbert · 2025-06-13 18:52:33 +09:00
  62ec0a15d8
• Add support for reading release stream from assembly version
  Dean Herbert · 2025-06-13 18:52:22 +09:00
  3291a4cb7b
• Add back test covering immediate exit song select
  Dean Herbert · 2025-06-04 17:59:08 +09:00
  7d8df1d8d4
• Add support for presenting beatmaps at song select v2
  Dean Herbert · 2025-05-27 19:33:11 +09:00
  7290f912d9
• Add comments around convoluted code that needs to be refactored
  Dean Herbert · 2025-05-27 02:16:48 +09:00
  b3ed1729c2
• Fix footer buttons not restoring when exiting an already displayed screen

  Closes https://github.com/ppy/osu/issues/33168.

  Dean Herbert · 2025-05-18 16:53:33 +09:00
  bec3450a44
• Fix line lost in merge resolution causing footer to disappear
  Dean Herbert · 2025-05-15 21:37:53 +09:00
  bc5c222953
• Fix screen footer buttons not having access to screen dependencies
  Dean Herbert · 2025-05-15 20:27:51 +09:00
  5a17d3c290
• Merge branch 'master' into tidy-screen-footer
  Bartłomiej Dach · 2025-05-15 12:55:28 +02:00
  0132b78eec
• Tidy up ScreenFooter and back button action flow
  Dean Herbert · 2025-05-15 18:37:42 +09:00
  087e054708
• Improve code quality
  Salman Alshamrani · 2025-05-15 12:26:28 +03:00
  60f56a0729
• Fix back button not displaying when transitoning to non-footer screen
  Salman Alshamrani · 2025-05-14 21:46:15 +03:00
  1829253b5a
• Allow falling back to opening multiplayer room history in browser if it's ended
  Bartłomiej Dach · 2025-05-07 09:40:10 +02:00
  9b3812210c
• Add support for opening multiplayer / playlist room links directly

  As in, `https://osu.ppy.sh/multiplayer/rooms/{id}` links, clicked from
  the chat overlay, now directly open in the client.
  
  Additionally, `osu://room/{id}` can be used in the same way to open a
  room from a third-party application or a browser.

  Bartłomiej Dach · 2025-04-28 11:40:00 +02:00
  09602097bd
• Fix code quality
  Bartłomiej Dach · 2025-04-24 08:54:10 +02:00
  72dd3513fc
• Fix presenting score potentially dying due to deleted beatmap

  - Closes https://github.com/ppy/osu/issues/27168
  - Closes https://github.com/ppy/osu/issues/32930
  
  It's a little manual (if you perform any of the scenarios in the issues
  above on this branch, the first click will re-import the beatmap but not
  start the replay, and only the second will play it), but maybe fine?

  Bartłomiej Dach · 2025-04-24 08:47:08 +02:00
  c52dce0f38
• Remove LeaderboardManager return value and simplify flow further

  The rationale for this change is that the return value was mostly
  useless, and at worst, misleading.
  
  When using `LeaderboardManager`, it's assumed that a consumer will bind
  to the global `Scores` list to ensure they receive updates for things
  like local score changes via the internal realm subscription. If one
  decides to instead use the return value of the task, it will be a static
  snapshot that potentially becomes stale in the future.
  
  I fell into this trap when refactoring the new leaderboard component
  (while attempting to assert correctness that the values we are
  displaying were in fact from the fetch operation we requested).
  
  In the interest of keeping things simple, removing the return value
  seems to be the best path forward.

  Dean Herbert · 2025-04-22 19:31:02 +09:00
  f7d1809cb7
• Add global screen margin for new screen designs
  Dean Herbert · 2025-04-16 19:41:49 +09:00
  1cca936e28
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Ensure correct global leaderboard state when presenting scores

  With `ReplayPlayer` now consuming the `LeaderboardManager`'s global
  state, flows such as presenting a score need to set the global state up
  correctly to avoid accidentally showing a leaderboard from a completely
  different score.
  
  This also incidentally closes https://github.com/ppy/osu/issues/27609.

  Bartłomiej Dach · 2025-04-10 10:19:04 +02:00
  31b98ac7b9
• Hook up LocalConfig functions in OsuGameBase to make work in tests
  Dean Herbert · 2025-04-08 14:15:42 +09:00
  5fc80dbddb
• Tidy up flow for retrieving key binding representations
  Dean Herbert · 2025-04-08 14:12:58 +09:00
  4b038c3762
• Rename localised string to something slightly more correct
  Dean Herbert · 2025-03-18 00:12:13 +09:00
  43d7918548
• Rename parameter
  GAMIS65 · 2025-03-14 10:06:28 +01:00
  c31fcb946b
• Change CopyUrlToClipboard to CopyStringToClipboard
  GAMIS65 · 2025-03-14 10:02:41 +01:00
  f72de39e4d
• Simplify code and don't set title if already correct
  Dean Herbert · 2025-03-06 15:48:36 +09:00
  975f4e4c7d
• Update window title changes to match osu! stable

  It shows beatmap metadata during gameplay, spectating, and watching replays but shows beatmap filename during editng

  Zihad · 2025-03-06 01:36:59 +06:00
  02d19eaa55
• Skip updating window title for protected mapsets
  Zihad · 2025-03-05 22:47:39 +06:00
  d33a8dfc3b
• Remove unnecessary comment
  Zihad · 2025-03-05 21:41:11 +06:00
  4ae5f239cb
• Revert "Update window title in input thread"

  This reverts commit 14b5c0bf10.
  This is not necessary as the title update is already scheduled on the correct thread by the framework.

  Zihad · 2025-03-05 21:40:29 +06:00
  5feddae6c7