h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-16 21:33:44 +08:00
Code Issues Releases Wiki Activity

Simplify code and don't set title if already correct

Browse Source
This commit is contained in:
Dean Herbert
2025-03-06 15:45:11 +09:00
Unverified
parent 02d19eaa55
commit 975f4e4c7d
1 changed files with 9 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/OsuGame.cs
+9 -17
View File
@@ -421,7 +421,7 @@ namespace osu.Game
SelectedMods.BindValueChanged(modsChanged);
Beatmap.BindValueChanged(beatmapChanged, true);
configUserActivity.BindValueChanged(userActivityChanged);
configUserActivity.BindValueChanged(_ => updateWindowTitle());
applySafeAreaConsiderations = LocalConfig.GetBindable<bool>(OsuSetting.SafeAreaConsiderations);
applySafeAreaConsiderations.BindValueChanged(apply => SafeAreaContainer.SafeAreaOverrideEdges = apply.NewValue ? SafeAreaOverrideEdges : Edges.All, true);
@@ -832,26 +832,19 @@ namespace osu.Game
updateWindowTitle();
}
private void userActivityChanged(ValueChangedEvent<UserActivity> userActivity)
{
updateWindowTitle();
}
private void updateWindowTitle()
{
if (Host.Window == null)
return;
if (Beatmap.Value?.BeatmapSetInfo?.Protected != false || Beatmap.Value is DummyWorkingBeatmap)
{
Host.Window.Title = Name;
return;
}
string newTitle = Name;
string newTitle;
switch (configUserActivity.Value)
{
default:
newTitle = Name;
break;
case UserActivity.InGame:
case UserActivity.TestingBeatmap:
case UserActivity.WatchingReplay:
@@ -859,13 +852,12 @@ namespace osu.Game
break;
case UserActivity.EditingBeatmap:
if (Beatmap.Value.BeatmapInfo.Path != null)
newTitle = $"{Name} - {Beatmap.Value.BeatmapInfo.Path}";
newTitle = $"{Name} - {Beatmap.Value.BeatmapInfo.Path ?? "new beatmap"}";
break;
}
Host.Window.Title = newTitle;
if (newTitle != Host.Window.Title)
Host.Window.Title = newTitle;
}
private void modsChanged(ValueChangedEvent<IReadOnlyList<Mod>> mods)