osu-lazer

Fix deselecting single item from a multiple selection not updating ternary states correctly

I'm not sure why this condition was written this obtusely, but
importantly it was also wrong. It fires when the selection contains
multiple items and only some are removed from it, like when
ctrl-click-unselecting an item from a multiple selection.

Bartłomiej Dach · 2025-04-24 09:25:36 +02:00

5a3ff11710

Reset sample ternary states on deselection

Closes https://github.com/ppy/osu/issues/32928.

Appears to match stable:

	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4137-L4143
	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L1615-L1618
	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4323

Bartłomiej Dach · 2025-04-24 09:25:27 +02:00

5c04f427a5

Change "Delete Difficulty" editor menu item type to destructive

schiavoanto · 2025-04-19 09:00:53 +02:00

d1f7afc8ed

Fix osu!mania beatmap objects getting corrupted when updating beatmap background

Closes https://github.com/ppy/osu/issues/32825.

Tested manually to fix the issue. Setting up test coverage for this is
going to likely take over an hour compared to the 30 second fix, so
please advise if required. I couldn't find any existing tests which
perform this flow.

Dean Herbert · 2025-04-17 16:11:03 +09:00

b71281bec8

Merge pull request #32729 from peppy/fix-mouse-down-leakage

Fix slider placement not working correctly with UI button clicks

Bartłomiej Dach · 2025-04-09 11:53:26 +02:00

110b124cb6

Fix editor click-through issues on bottom bar too

Bartłomiej Dach · 2025-04-09 10:28:06 +02:00

7ab428f18c

Block all mouse events at BeatDivisorControl and revert animated button change

Dean Herbert · 2025-04-09 14:56:30 +09:00

27edee477d

Merge pull request #32730 from peppy/fix-keyboard-steps

Fix editor setup screen sliders not having correct keyboard steps

Bartłomiej Dach · 2025-04-08 08:32:37 +02:00

99ee5767cb

Merge pull request #32665 from peppy/fix-editor-metadata-save-without-commit

Fix saving via ctrl+s while metadata textbox is focused not saving changes

Bartłomiej Dach · 2025-04-08 08:21:03 +02:00

5f168b9b9f

Fix editor setup screen sliders not having correct keyboard steps

Closes https://github.com/ppy/osu/issues/32691.

Fixes some extra cases of failure that aren't pointed out in the issue.

Dean Herbert · 2025-04-08 14:45:43 +09:00

f2088496c5

Fix mouse down actions being leaked through buttons

Dean Herbert · 2025-04-08 14:28:48 +09:00

e42301058f

Make dependency on editor optional

Bartłomiej Dach · 2025-04-07 15:00:47 +02:00

5db4f80e84

Fix code quality harder

Bartłomiej Dach · 2025-04-07 14:59:51 +02:00

f968f8ed68

Fix nullability inspection

Bartłomiej Dach · 2025-04-07 13:44:42 +02:00

d34a1fb448

Avoid saving a state when clearly not dirty

Dean Herbert · 2025-04-07 19:37:26 +09:00

3738d75202

Ensure a state is saved when committing metadata to trigger pending changes flow

Dean Herbert · 2025-04-03 18:49:18 +09:00

f19fa73fb2

Only show required number of decimal places (and fix final alpha levels)

Dean Herbert · 2025-04-03 18:17:26 +09:00

448573449c

Change editor to save metadata changes without explicit textbox commit

Closes https://github.com/ppy/osu/issues/32365.

Dean Herbert · 2025-04-03 15:31:24 +09:00

ce288023fe

Fix metronome BPM text not matching expectations due to custom rounding implementation

Dean Herbert · 2025-04-03 15:13:44 +09:00

11368b628b

Remove non-visible "beat snap" text in editor

Dean Herbert · 2025-03-20 15:46:09 +09:00

80ff974594

Move BeatmapVersion from BeatmapInfo to IBeatmap

Closes https://github.com/ppy/osu/issues/32420.

The failure cause here is that in editor the beatmap version for the
beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
probably a regression from https://github.com/ppy/osu/pull/32315, but
like... can we universally agree that calling that change "a regression"
in any capacity is dumb? Like what was that code *doing* playing dumb
reference games and copying stuff into an arbitrary instance that could
get or not get used later on? And now you have a 50/50 chance of
accessing the *correct* model's field, depending on whether you go via
`BeatmapInfo` or `Beatmap.BeatmapInfo`?

Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
and materialised" beatmap, fixes this issue.

I probably should have done this as part of
https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
for the better too because this change has rather large chances of
breaking stuff so maybe better to examine it in isolation (via diffcalc
runs or whatever).

For added humour points, you'd say that the field on `BeatmapInfo` was
not `[Ignore]`d, so this is a realm schema change, right? No. As far as
I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
a listed column` on `Beatmap` models.

I'm also not gonna get into the fact that I think `EditorBeatmap` doing
dumb games with juggling two `BeatmapInfo` references since
https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
have the mental capacity to hotfix this by going down that train of
thought.

Bartłomiej Dach · 2025-03-17 15:04:48 +01:00

91f3be5fea

Merge pull request #32346 from bdach/user-tags-on-results

Add ability to vote for beatmap user tags after completing a play

Dean Herbert · 2025-03-15 14:36:27 +09:00

d704adf5fa

Show user tag control only following local user gameplay

Bartłomiej Dach · 2025-03-12 12:19:33 +01:00

e70ad14647

Fix context menu not working when selection hasn't changed

Dean Herbert · 2025-03-12 18:25:56 +09:00

5b911ad8d0

Fix quick delete still propagating right click mouse input upwards

Dean Herbert · 2025-03-12 16:52:36 +09:00

db7d1f32d7

Merge branch 'master' into editor-right-click-as-people-expect

Dean Herbert · 2025-03-12 14:51:28 +09:00

083979e299

Merge pull request #32319 from 64ArthurAraujo/editor-darker-placement-blueprint

Adjust timeline placement display

Bartłomiej Dach · 2025-03-11 15:28:16 +01:00

3710d0ede5

Show border instead of adjusting dim

Dean Herbert · 2025-03-11 18:35:10 +09:00

770291b462

Disallow adjusting slider repeats with more lenient check condition

Dean Herbert · 2025-03-11 16:12:32 +09:00

d4f0fc0fde

Change amount from 0.9f to 0.6f

Arthur Araujo · 2025-03-10 16:09:18 -03:00

a78868712c

Merge pull request #32240 from bdach/discard-unsaved-changes

Add "discard unsaved changes" operation to beatmap editor

Dean Herbert · 2025-03-06 20:15:41 +09:00

1506037247

Move to file menu

Dean Herbert · 2025-03-06 19:34:20 +09:00

d9b7d034ba

Use localisation

Dean Herbert · 2025-03-06 18:51:32 +09:00

64830e2c31

Fix differential submission process crashing when no files have changed

Closes https://github.com/ppy/osu/issues/32247.

Bartłomiej Dach · 2025-03-06 09:45:44 +01:00

0f0dd58b69

Add "discard unsaved changes" operation to beatmap editor

Apparently useful in modding workflows when you want to test out a few
different variants of a thing.

Re-uses `Ctrl-L` binding from stable. Some folks may argue that the
dialog makes the hotkey pointless, but I really do want to protect
users from accidental data loss, and also if you want to power through
it quickly, you can hit the 1 key when the dialog shows, which will
bypass the hold-to-activate period (which wasn't intentional, but so
many people want a bypass at this point that we're probably keeping that
behaviour for power users).

Bartłomiej Dach · 2025-03-05 14:34:44 +01:00

3f461c0734

Merge pull request #32200 from andy840119/remove-handle-scale-base-method

Remove unused virtual method after refactor the scale handling.

Dan Balasescu · 2025-03-04 13:14:14 +09:00

8c13a86ad1

This method is not being used anymore.

see:
https://github.com/ppy/osu/pull/26643

andy840119 · 2025-03-03 22:10:41 +08:00

23a5d6dc40

Always zoom timeline to centre rather than focus point

Closes https://github.com/ppy/osu/issues/32183.

Dean Herbert · 2025-03-03 18:53:41 +09:00

52860def6c

Adjust preview time display to not conflict with bookmarks

Dean Herbert · 2025-02-28 14:05:49 +09:00

e1723ec1bb

Do not allow adding more than 8 combo colours in editor

Bartłomiej Dach · 2025-02-26 11:24:06 +01:00

6b76b8ccdd

Add back right-click-for-new-combo and right-click-delete when in compose mode

Requested too many times to count.

I'm not sure what to do about the code quality of this. It's a bit weird
that there's no way to check the current composition tool from a higher
level.

Also it was discussed IRL that there should be some kind of hinting that
existing notes will be deleted when they are hovered, but I'm not sure
how well this will work in normal mapping flows, since it will display
even in cases that users aren't intending to delete an object. Still
willing to explore this direction though (it's just non-trivial to
implement so I haven't yet).

Dean Herbert · 2025-02-26 17:52:33 +09:00

2738c1a807

Fix hash comparison being case sensitive when choosing files for partial beatmap submission

Noticed when investigating https://github.com/ppy/osu/issues/32059, and
also a likely cause for user reports like
https://discord.com/channels/188630481301012481/1097318920991559880/1342962553101357066.

Honestly I have no solid defence, Your Honour. I guess this just must
not have been tested on the client side, only relied on server-side
testing.

Bartłomiej Dach · 2025-02-24 12:30:37 +01:00

0312467c88

Adjust rounding tolerance in distance snap grid ring colour logic

Bartłomiej Dach · 2025-02-21 12:05:23 +01:00

a690b0bae9

Send "notify on discussion replies" setting value in beatmap creation request

Bartłomiej Dach · 2025-02-19 12:45:37 +01:00

687c9d6e17

Merge pull request #31928 from bdach/perform-on-selection-is-weird

Fix nudging objects in catch editor not changing their hyperdash state

Dean Herbert · 2025-02-18 21:17:10 +09:00

66f7f92469

Ensure EditorBeatmap.PerformOnSelection() marks objects in selection as updated

Closes https://github.com/ppy/osu/issues/28791.

The reason why nudging was not changing hyperdash state in catch was
that `EditorBeatmap.Update()` was not being called on the objects that
were being modified, therefore postprocessing was not performed,
therefore hyperdash state was not being recomputed.

Looking at the usage sites of `EditorBeatmap.PerformOnSelection()`,
about two-thirds of callers called `Update()` themselves on the objects
they mutated, and the rest didn't. I'd say that's the failure of the
abstraction and it should be `PerformOnSelection()`'s responsibility to
call `Update()` there. Yes in some of the cases here this will cause
extraneous calls that weren't done before, but the method is already
heavily disclaimed as 'expensive', so I'd say usability should come
first.

Bartłomiej Dach · 2025-02-18 12:06:42 +01:00

e6174f195c

Add missing early return

As spotted in testing with production. Would cause submission to proceed
even if the export did, with an empty archive.

Bartłomiej Dach · 2025-02-18 11:35:29 +01:00

b3aba537b5

Merge pull request #31917 from bdach/nudge-fix

Fix nudge operations incurring FP error from coordinate space conversions

Dan Balasescu · 2025-02-18 12:19:14 +09:00

3b8b8ae87f

Fix nudge operations incurring FP error from coordinate space conversions

Closes https://github.com/ppy/osu/issues/31915.

Reproduction of aforementioned issue requires 1280x720 resolution, which
should also be a good way to confirm that this does anything.

To me this is also equal-parts-bugfix, equal-parts-code-quality PR,
because tell me: what on earth was this code ever doing at
`ComposeBlueprintContainer` level? Nudging by one playfield-space-unit
doesn't even *make sense* in something like taiko or mania.

Bartłomiej Dach · 2025-02-17 15:21:07 +01:00

f37a56c307

Merge pull request #31912 from bdach/more-snap-grid

Fix some more visual issues with osu! distance snap grid

Dean Herbert · 2025-02-17 21:11:17 +09:00

42fb544218

3374 Commits