16647 Commits

• Fix one more test failure
  Bartłomiej Dach · 2025-04-25 08:14:12 +02:00
  ae8fb2ce08
• Fix code quality
  Bartłomiej Dach · 2025-04-24 13:18:35 +02:00
  330f213460
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Fix deselecting single item from a multiple selection not updating ternary states correctly

  I'm not sure why this condition was written this obtusely, but
  importantly it was also wrong. It fires when the selection contains
  multiple items and only some are removed from it, like when
  ctrl-click-unselecting an item from a multiple selection.

  Bartłomiej Dach · 2025-04-24 09:25:36 +02:00
  5a3ff11710
• Reset sample ternary states on deselection

  Closes https://github.com/ppy/osu/issues/32928.
  
  Appears to match stable:
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4137-L4143
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L1615-L1618
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4323

  Bartłomiej Dach · 2025-04-24 09:25:27 +02:00
  5c04f427a5
• Merge pull request #32915 from peppy/carousel-update-handling

  Add basic support for beatmap updates in `BeatmapCarousel`

  Bartłomiej Dach · 2025-04-23 13:10:25 +02:00
  7cf8207e6e
• Merge pull request #32924 from smoogipoo/fix-mp-results-background

  Show true beatmap background when viewing historical multiplayer results

  Bartłomiej Dach · 2025-04-23 12:42:00 +02:00
  212e7a1170
• Move implementation to base class
  Dan Balasescu · 2025-04-23 18:27:59 +09:00
  655861752d
• Ensure online ID has a valid online value before preferring it
  Dean Herbert · 2025-04-23 18:21:17 +09:00
  1488a49dae
• Remove online ID equality TODO and add explanation as to why it's not required
  Dean Herbert · 2025-04-23 18:13:13 +09:00
  73773aa69a
• Maintain selection using OnlineID as a priority
  Dean Herbert · 2025-04-23 18:01:49 +09:00
  414150e9e0
• Merge pull request #32842 from frenzibyte/song-select-v2-wedges-title

  Add song select beatmap title wedge

  Dean Herbert · 2025-04-23 17:39:03 +09:00
  ddb4c0e24f
• Merge pull request #32843 from frenzibyte/song-select-v2-wedges-metadata

  Add song select beatmap metadata wedge

  Dean Herbert · 2025-04-23 17:36:12 +09:00
  f945298bde
• Fix "mapped by" line showing stupid display when switching to default beatmap
  Dean Herbert · 2025-04-23 17:34:59 +09:00
  5ad28a792b
• Simplify and fix naming of statistic class
  Dean Herbert · 2025-04-23 17:32:18 +09:00
  4290f2d4fd
• Fix animations and alignment of tiny statistics
  Dean Herbert · 2025-04-23 17:20:52 +09:00
  9372ba02d1
• Remove silly bindable flow that only exists for testing purposes
  Dean Herbert · 2025-04-23 17:08:48 +09:00
  c11220df9b
• Improve star rating colour animations to match
  Dean Herbert · 2025-04-23 17:04:53 +09:00
  f6d7e29396
• Define constant for difficulty colour cutoff
  Dean Herbert · 2025-04-23 16:57:41 +09:00
  3f719125e6
• Merge pull request #32923 from smoogipoo/keep-settings-on-room-update

  Keep multiplayer settings open during room updates

  Bartłomiej Dach · 2025-04-23 09:47:56 +02:00
  059f6ef35c
• Show true beatmap background when viewing historical multiplayer results
  Dan Balasescu · 2025-04-23 16:28:44 +09:00
  65cf1a4b7c
• Merge pull request #32913 from peppy/leaderboard-fetch-refactor

  Remove `LeaderboardManager` return value and simplify flow further

  Bartłomiej Dach · 2025-04-23 09:27:12 +02:00
  7636573e21
• Adjust tests and transitions
  Dean Herbert · 2025-04-23 16:23:37 +09:00
  883df07ff6
• Keep multiplayer settings open during room updates
  Dan Balasescu · 2025-04-23 16:05:35 +09:00
  5ea408f3a1
• Always refresh leaderboard for now
  Dean Herbert · 2025-04-23 14:51:00 +09:00
  f945abb72e
• Ensure selection is retained over beatmap update
  Dean Herbert · 2025-04-22 21:01:56 +09:00
  615c7b29b5
• Add basic support for beatmap updates in BeatmapCarousel
  Dean Herbert · 2025-04-22 20:03:07 +09:00
  6f97667889
• Change equality to allow non-reference comparisons

  This is required to hold selection when beatmaps are updates, as one
  important case.

  Dean Herbert · 2025-04-22 20:03:07 +09:00
  ac67473433
• Remove LeaderboardManager return value and simplify flow further

  The rationale for this change is that the return value was mostly
  useless, and at worst, misleading.
  
  When using `LeaderboardManager`, it's assumed that a consumer will bind
  to the global `Scores` list to ensure they receive updates for things
  like local score changes via the internal realm subscription. If one
  decides to instead use the return value of the task, it will be a static
  snapshot that potentially becomes stale in the future.
  
  I fell into this trap when refactoring the new leaderboard component
  (while attempting to assert correctness that the values we are
  displaying were in fact from the fetch operation we requested).
  
  In the interest of keeping things simple, removing the return value
  seems to be the best path forward.

  Dean Herbert · 2025-04-22 19:31:02 +09:00
  f7d1809cb7
• Avoid clearing global cache on entering song select
  Dean Herbert · 2025-04-22 19:29:09 +09:00
  7e6e082bac
• Fix free mod selection sub-button being clickable even if the main button isn't

  Noticed in passing when testing https://github.com/ppy/osu/pull/32674.

  Bartłomiej Dach · 2025-04-22 11:25:09 +02:00
  fea1b73c17
• Merge branch 'master' into song-select-v2-wedges-title
  Dean Herbert · 2025-04-22 17:35:01 +09:00
  ace5f26c0f
• Merge branch 'master' into song-select-v2-wedges-metadata
  Dean Herbert · 2025-04-22 17:34:57 +09:00
  35d01ad124
• Merge pull request #32849 from frenzibyte/song-select-v2-collection-dropdown

  Add sheared collection dropdown

  Dean Herbert · 2025-04-22 17:31:01 +09:00
  bb5c8c85d7
• Adjust namespaces and naming
  Dean Herbert · 2025-04-22 17:03:28 +09:00
  ec854f7b7f
• Merge pull request #32840 from frenzibyte/song-select-v2-constants

  Prerequisite changes for song select v2 design work

  Dean Herbert · 2025-04-22 16:39:05 +09:00
  a0698be6c2
• Merge pull request #32839 from frenzibyte/song-select-v2-panel-metrics

  Use new font specifications in beatmap panels and apply minor adjustments

  Dean Herbert · 2025-04-22 16:35:11 +09:00
  3ba3f3ace7
• Merge pull request #32822 from bdach/leaderboards/gameplay-provider

  Separate gameplay leaderboard data management from display

  Dean Herbert · 2025-04-22 03:10:53 +09:00
  178063f79e
• Merge pull request #32838 from peppy/carousel-group-counts

  Add accounting of nested group items for group panel display purposes

  Bartłomiej Dach · 2025-04-21 14:05:21 +02:00
  930c56e713
• Bring back reading from config value
  Bartłomiej Dach · 2025-04-21 09:15:44 +02:00
  da1fc1013e
• Move bindable list population to load complete to fix threading woes
  Bartłomiej Dach · 2025-04-21 09:05:54 +02:00
  4d08c81e8d
• Merge branch 'master' into leaderboards/gameplay-provider
  Bartłomiej Dach · 2025-04-21 09:03:24 +02:00
  6b0567e882
• Allow toggling leaderboard visibility in replays

  Closes https://github.com/ppy/osu/issues/31744 I guess.
  
  This isn't the resolution that I had in mind for this but my hand has
  been basically forced by user feedback to do this, at least in the
  short-term.

  Bartłomiej Dach · 2025-04-21 08:51:34 +02:00
  d8df499e72
• Merge pull request #32863 from bdach/leaderboard-manager-handles-errors

  Fix gameplay leaderboard showing scores from wrong beatmaps

  Dean Herbert · 2025-04-19 22:55:00 +09:00
  b9afecea7f
• Change "Delete Difficulty" editor menu item type to destructive
  schiavoanto · 2025-04-19 09:00:53 +02:00
  d1f7afc8ed
• Fix gameplay leaderboard showing scores from wrong beatmaps

  Kind of a big oversight this. In wanting to get the leaderboard
  refactors to move forward I sort of didn't realise the fact that all of
  the error handling related to online status and such in
  `BeatmapLeaderboard` kind of... can't stay there...
  
  It's also an all-or-nothing business too - moving this stuff can't
  really be done only in part.
  
  Not sure whether tests are warranted if it's more or less moving logic
  across?

  Bartłomiej Dach · 2025-04-18 20:37:02 +02:00
  c29f59fcdb
• Add beatmap metadata wedge
  Salman Alshamrani · 2025-04-18 06:43:36 -04:00
  856f907c86
• Add beatmap title wedge
  Salman Alshamrani · 2025-04-18 06:41:51 -04:00
  04fa95d924
• Add beatmap title wedge difficulty statistics
  Salman Alshamrani · 2025-04-18 06:32:31 -04:00
  a870a71b4b
• Add beatmap title wedge statistic display
  Salman Alshamrani · 2025-04-18 06:32:31 -04:00
  dfd226394d