osu-lazer

Merge pull request #32922 from peppy/fix-tablet-adjust-precision

Fix tablet settings adjusting with too much precision

Dean Herbert · 2025-04-24 15:23:56 +09:00

4a95973b6e

Merge pull request #32909 from bdach/fix-daily-challenge-marker

Fix daily challenge marker text spacing

Dean Herbert · 2025-04-23 18:24:56 +09:00

0adda23988

Fix tablet settings adjusting with too much precision

Closes https://github.com/ppy/osu/issues/32920.

I don't know if there's going to be other cases of breakage, but from
what I can tell these settings *not* showing infinite precision
representations was a bug with the previous implementation of number
formatting.

Dean Herbert · 2025-04-23 15:40:41 +09:00

8d4d9b7bef

Merge branch 'master' into song-select-v2-wedges-title

Dean Herbert · 2025-04-22 17:35:01 +09:00

ace5f26c0f

Merge pull request #32849 from frenzibyte/song-select-v2-collection-dropdown

Add sheared collection dropdown

Dean Herbert · 2025-04-22 17:31:01 +09:00

bb5c8c85d7

Adjust namespaces and naming

Dean Herbert · 2025-04-22 17:03:28 +09:00

ec854f7b7f

Fix daily challenge marker text spacing

Closes https://github.com/ppy/osu/issues/32908.

Have you ever been in a situation wherein you find out you fixed a bug
that you didn't know existed, but that makes *another* bug appear
because it was relying on the other bug? This is where I'm at right now.

But, to start from the top.

`TextFlowContainer.Text` (the setter) is a convenience property that you
use to set the text in one go. Internally it uses `AddText()`:

	https://github.com/ppy/osu-framework/blob/681900ffb70adfeede4e3fa32a69da66252691ee/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L81-L94

`AddText()`'s xmldoc says:

	The \n character will create a new paragraph, not just a line break.
	If you need \n to be a line break, use <see cref="AddParagraph{TSpriteText}(LocalisableString, Action{TSpriteText})"/> instead.

	https://github.com/ppy/osu-framework/blob/681900ffb70adfeede4e3fa32a69da66252691ee/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L226-L239

That's right. This portion of xmldoc was *straight up false* and
*silently broken* before https://github.com/ppy/osu-framework/pull/6556.
If you want to check that out yourself, apply the following patch to
framework:

diff --git a/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs b/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
index 464f47c2c..e1ad521a7 100644
--- a/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
+++ b/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
@@ -180,6 +180,22 @@ public void TestAlignmentIsCorrectWhenLineBreaksAtLastWordOfParagraph(Anchor tex
             });
         }

+        [Test]
+        public void TestSetTextWithNewLine()
+        {
+            AddStep("set text", () => textContainer.Text = "this text\nhas a newline");
+            AddStep("clear and add text", () =>
+            {
+                textContainer.Clear();
+                textContainer.AddText("this text\nhas a newline");
+            });
+            AddStep("clear and add paragraph", () =>
+            {
+                textContainer.Clear();
+                textContainer.AddParagraph("this text\nhas a newline");
+            });
+        }
+
         private void assertSpriteTextCount(int count)
             => AddAssert($"text flow has {count} sprite texts", () => textContainer.ChildrenOfType<SpriteText>().Count() == count);

On `master`, there will be a difference between the first two steps, and
the third. On 2025.321.0, *there will be none*.

My working theory as to why this was always busted is that the
corresponding code that was there before in

	https://github.com/bdach/osu-framework/blob/c31a48178889ca2f9b4d257d2d64915eee90338a/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L454-L458

just straight up ran too late. *The height of the container is being
changed after the flow has laid itself out, without adjusting subsequent
children in any way.*

There is potentially a discussion to be had as to whether the emergent
behaviour of `TextFlowContainer.Text` with respect to `\n` character is
correct, but I'm just going to start with this diff and see what the
reaction is.

Bartłomiej Dach · 2025-04-22 08:52:01 +02:00

5895a8ac49

Add beatmap title wedge

Salman Alshamrani · 2025-04-18 06:41:51 -04:00

04fa95d924

Merge pull request #32820 from peppy/global-audio-offset-control-fixes

Fix global offset adjust control showing adjustment available when it shouldn't

Dean Herbert · 2025-04-18 18:04:18 +09:00

21fd4e857f

Move number formatting to extension method and reuse for AudioOffsetAdjustmentControl

Also adds some basic test coverage.

Dean Herbert · 2025-04-18 17:30:31 +09:00

e44b134552

Fix global offset adjust control showing adjustment available when it shouldn't

Audio offset is integer based in configuration, so let's make sure not
to show that there's an applicable offset when the value difference is
too low.

I've also fixed rounding to match expectations (`AudioOffset` is
precision limited to integer), and handled the case where a user adjusts
the slider but also has a suggested offset – previously it would not
enable the button after slider adjustments but now it will work as
expected.

Dean Herbert · 2025-04-16 20:21:50 +09:00

51ad6289ca

Add keywords for converted setting

Dean Herbert · 2025-04-16 19:41:48 +09:00

6021d85e63

Change global shear definition to be a Vector2

Saves having this defined in 20+ places. If we ever make any changes to
shear, it's 100% going to need to be applied to every usage (there will
never be a case of multiple different shears in the game).

Also fixes a mismatching definition in `ShearedNub`.

Dean Herbert · 2025-04-16 18:01:08 +09:00

7a8e96f322

Merge pull request #32799 from peppy/middle-click-closes-channels

Add support for closing chat channels with middle click

Bartłomiej Dach · 2025-04-14 09:17:52 +02:00

b214539929

Add support for closing chat channels with middle click

Closes https://github.com/ppy/osu/issues/32797.

Dean Herbert · 2025-04-14 15:30:40 +09:00

f4cb3a7fb3

Fix status pill animating from zero height

Dean Herbert · 2025-04-10 20:11:04 +09:00

69035ef48f

Fix success rate / points of failure not showing for unranked beatmaps on beatmap info overlay

Joseph Madamba · 2025-04-09 11:41:20 -07:00

bfc6d61e5d

Move key binding string retrieval to RealmKeyBindingStore

Dean Herbert · 2025-04-09 15:23:55 +09:00

9e90f80ab5

Merge pull request #32679 from bdach/playlist-hacksawing

Remove filtering & rearranging controls from now playing overlay

Dean Herbert · 2025-04-07 23:07:39 +09:00

10abd55a15

Merge pull request #32678 from bdach/prev-next-weirdness

Fix weird behaviour when skipping back and forth with shuffle enabled

Dan Balasescu · 2025-04-07 21:11:16 +09:00

19f761b125

Animate scroll back to zero

Dean Herbert · 2025-04-07 20:55:39 +09:00

c42d7aa4fa

Don't delay scroll on hover of playlist items

Dean Herbert · 2025-04-07 20:51:32 +09:00

60e6b56b66

Don't use bindables when binding isn't happening

Dean Herbert · 2025-04-07 20:51:22 +09:00

881785900a

Terminate scrolling immediately on unhovering

Bartłomiej Dach · 2025-04-07 12:47:24 +02:00

0d9cff487b

Apply review suggestions

Bartłomiej Dach · 2025-04-07 09:36:53 +02:00

2d619a3692

Only scroll overflowing playlist items if they've been hovered

Bartłomiej Dach · 2025-04-07 09:18:16 +02:00

b8360a19dd

Rename class to avoid miconceptions

Dean Herbert · 2025-04-05 23:34:16 +09:00

a039bfe1d1

Prevent future misuse

Dan Balasescu · 2025-04-04 22:48:33 +09:00

6d51888896

Fix thread-race leading to OnScreenDisplay crash

Dan Balasescu · 2025-04-04 22:48:33 +09:00

abfda9cbcd

Make overflowing playlist items scroll

Bartłomiej Dach · 2025-04-04 13:16:28 +02:00

52d71d7f6e

Remove filtering & rearranging controls from now playing overlay

Bartłomiej Dach · 2025-04-04 13:16:12 +02:00

f5b849b4f3

Fix weird behaviour when skipping back and forth with shuffle enabled

Closes https://github.com/ppy/osu/issues/32590

I didn't think there would come a day where I'd unironically use a
linked list, but here we are.

Bartłomiej Dach · 2025-04-04 13:12:30 +02:00

228d439fce

Fix potential crashes due to asynchronous BindableList usage

Band-aid fix for https://github.com/ppy/osu/issues/32671.

Removes all `BindableList.BindTo` from `load()` methods (except one
editor one which looks safe and is kinda hard to fix without moving
drawable load to a blocking operation).

Dean Herbert · 2025-04-04 19:54:47 +09:00

04f8fcd04f

Remove unused local

Dean Herbert · 2025-03-31 23:43:04 +09:00

005b204f0a

Fix skin editor anchor/origin context menu ternary states not updating properly

- Closes https://github.com/ppy/osu/issues/31797
- Supersedes / closes https://github.com/ppy/osu/pull/32611

Bartłomiej Dach · 2025-03-31 14:25:35 +02:00

736f2af1e0

Merge pull request #32610 from bdach/user-tags-on-beatmap-set-overlay

Show user tags on beatmap set overlay

Dean Herbert · 2025-03-28 17:10:57 +09:00

f4c96ecb54

Show user tags on beatmap set overlay

Resolves one part of
https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928

A few caveats:

- Layout is slightly different than web intentionally. Web does things
  that I think will be difficult to reproduce or just plain look bad in
  client, such as:

  - On web, the metadata info box has 200px min height and 300px max
    height. I just hardcoded 300 units.

  - On web, user tags and mapper tags are individually scrollable, and
    the amount of space taken up by each is calculated in a way that
    is - as far as I can tell - indeterminate, and probably influenced
    by some flexbox magic. I just made the entire thing scrollable
    instead.

- Because song select shares controls with the beatmap set overlay, now
  song select says "Mapper Tags" in the header instead of just "Tags"
  too. I think this is fine, because people asked for user tags to be
  shown in song select too.

- Search query syntax lifted from
  https://github.com/ppy/osu-web/pull/12047.

- Using hardcoded English strings for now, will update to the
  translations after the next osu-resources localisations update.

Bartłomiej Dach · 2025-03-27 14:58:03 +01:00

7bb97d5796

Refresh mod panel active states when recreated

Dan Balasescu · 2025-03-27 19:05:26 +09:00

dcb5389ab7

Merge pull request #32567 from peppy/fix-christmas-music-oh-no

Fix christmas menu track potentially playing out of season

Dan Balasescu · 2025-03-26 14:41:31 +09:00

a14623a4ab

Inline method calls to make multiple enumerations explicit

Dean Herbert · 2025-03-25 22:25:56 +09:00

f36bc51520

Remove unnecessary conditionals

Dean Herbert · 2025-03-25 17:13:13 +09:00

68cdb60bee

Merge pull request #32540 from frenzibyte/mod-rich-tooltip

Display mod tooltips in rich form

Dean Herbert · 2025-03-25 16:44:43 +09:00

6dbd6a7e7b

Remove pointless left-over code

Dean Herbert · 2025-03-25 16:43:22 +09:00

1bb85bab89

Fix christmas menu track potentially playing out of season

Closes https://github.com/ppy/osu/issues/32502.

Dean Herbert · 2025-03-25 14:48:51 +09:00

0d8f328fe6

Fix overlapping placeholders in beatmap info leaderboard

Closes https://github.com/ppy/osu/issues/32508.

Dean Herbert · 2025-03-25 14:27:24 +09:00

9630002a68

Add extra margin below description text

Salman Alshamrani · 2025-03-23 13:46:19 -04:00

54eb0b33b0

Update mod preset tooltip design accordingly

Salman Alshamrani · 2025-03-23 13:43:38 -04:00

623e705704

Avoid using invalidation / transforms for settings toolbox header hiding

This was causing a performance issue due to transforms bunching up for
off-screen toolboxes. It's much simpler to just update these values
every frame.

Closes https://github.com/ppy/osu/issues/32474.

Dean Herbert · 2025-03-20 15:46:08 +09:00

84cc2e6d77

Merge pull request #32446 from GioSDA/chat-right-click-functionality

Add more functionality to right clicking in the chat window

Bartłomiej Dach · 2025-03-19 12:34:21 +01:00

8b566d2955

Remove online state check altogether

Dean Herbert · 2025-03-19 16:18:23 +09:00

67b48fd0ac

10407 Commits