73281 Commits

This Branch

This Branch

All Branches

• Remove unnecessary replay recorder depth hack

  Addresses https://github.com/ppy/osu/pull/33102#discussion_r2087963889.

  Bartłomiej Dach · 2025-05-14 11:25:31 +02:00
  acebf3e95e
• Add baseline test coverage of replay recording in all rulesets

  Nothing fancy, just basics to ensure the subsequent commit doesn't break
  anything.

  Bartłomiej Dach · 2025-05-14 11:25:14 +02:00
  168c3cf018
• Merge pull request #33120 from frenzibyte/ssv2-cache-class

  SongSelectV2: Fix `SongSelect` not cached for subcomponents

  Dean Herbert · 2025-05-14 10:47:01 +09:00
  93fda73062
• Merge pull request #33119 from frenzibyte/ssv2-mod-audio

  SongSelectV2: Apply mod adjustments to beatmap track

  Dean Herbert · 2025-05-14 01:36:57 +09:00
  7b93351197
• Fix SongSelect not cached for subcomponents
  Salman Alshamrani · 2025-05-13 15:32:44 +03:00
  74d10e2a62
• Apply mod adjustments to beatmap track
  Salman Alshamrani · 2025-05-13 15:24:18 +03:00
  bd136b88c6
• Merge pull request #32972 from bdach/multiplayer-position-indicator

  Add non-skinnable position indicator to multiplayer player

  Dean Herbert · 2025-05-13 20:53:15 +09:00
  3ce5389558
• Merge pull request #33117 from frenzibyte/ssv2-volume-keybinds

  SongSelectV2: Allow adjusting volume by scrolling

  Dean Herbert · 2025-05-13 20:34:33 +09:00
  366e0deefe
• Allow scrolling to adjust volume
  Salman Alshamrani · 2025-05-13 14:08:12 +03:00
  0b6e36d61e
• Fix multiplayer position display not hiding on user change
  Bartłomiej Dach · 2025-05-13 11:47:01 +02:00
  1d3f4ac02b
• Merge pull request #33056 from frenzibyte/fix-difficulty-sorting

  Display separate design for beatmap panels on difficulty sort mode

  Dean Herbert · 2025-05-13 18:43:57 +09:00
  2dceee8ba9
• Fix code inspection
  Bartłomiej Dach · 2025-05-13 11:37:52 +02:00
  79f88528ae
• Merge pull request #33111 from peppy/fix-letterbox-rewind

  Fix letterbox overlay potentially fading incorrectly during seeks

  Bartłomiej Dach · 2025-05-13 11:18:38 +02:00
  464ad4ec77
• Update existing test coverage

  Add test coverage

  Salman Alshamrani · 2025-05-13 17:59:07 +09:00
  b26fe702ba
• Display separate design for beatmap panels on difficulty sort mode
  Salman Alshamrani · 2025-05-13 17:58:18 +09:00
  f58cf8e971
• Merge pull request #33114 from bdach/solo-results-dont-show-best-if-beat

  Do not show previous best score on solo results screen if the local user just beat it

  Dean Herbert · 2025-05-13 17:50:45 +09:00
  a360f153f7
• Fix exceptions being hidden by async task usage
  Dean Herbert · 2025-05-13 17:43:57 +09:00
  36317bc459
• Merge pull request #33106 from frenzibyte/ssv2-rate-adjust-keybinds

  SongSelectV2: Add rate adjustment keybinds

  Dean Herbert · 2025-05-13 17:33:53 +09:00
  7c5e146bbe
• Add rate adjustment keybinds

  Add test coverage

  Salman Alshamrani · 2025-05-13 17:30:38 +09:00
  1b2054c49d
• Remove completely pointless test scene
  Dean Herbert · 2025-05-13 17:30:32 +09:00
  538e5aed19
• Merge pull request #33107 from frenzibyte/ssv2-ctrl-tab

  SongSelectV2: Allow switching between details and rankings page via keyboard

  Dean Herbert · 2025-05-13 17:24:31 +09:00
  a6fc700cd5
• Merge pull request #33105 from frenzibyte/ssv2-refactor-tests

  SongSelectV2: Refactor test scenes to have a place for non-filtering tests

  Dean Herbert · 2025-05-13 17:22:55 +09:00
  74a3ac4622
• Move "local" test to "navigation" namespace
  Dean Herbert · 2025-05-13 17:22:01 +09:00
  238855c4cc
• Do not show previous best score on solo results screen if the local user just beat it

  Closes https://github.com/ppy/osu/issues/33109.

  Bartłomiej Dach · 2025-05-13 10:17:09 +02:00
  a5ea24e37b
• Add failing test coverage for expected behaviour
  Bartłomiej Dach · 2025-05-13 10:15:54 +02:00
  3c219a799b
• Fix letterbox overlay potentially fading incorrectly during seeks

  Pushing this out with zero testing as a "probably fixes"
  https://github.com/ppy/osu/issues/33108.
  
  Previous logic would mean that the start value of the fade-in may not be
  zero depending on current state, leaving the final alpha state incorrect
  after a rewind beyond the start time.

  Dean Herbert · 2025-05-13 17:09:20 +09:00
  83891b104d
• Roll the rank counter instead of immediate updates
  Dean Herbert · 2025-05-13 17:04:47 +09:00
  eaa7af58d5
• Improve transition fade in/out
  Dean Herbert · 2025-05-13 16:45:12 +09:00
  e7d26669c0
• Add bar display
  Dean Herbert · 2025-05-13 16:30:38 +09:00
  91b9b41d58
• Fix test not showing immediately useful state

  Also standardises the testing leaderboard provider component for
  (immediate) future use.

  Dean Herbert · 2025-05-13 15:53:47 +09:00
  1d7f922068
• Merge pull request #33011 from fredzio2006/perfect-feat

  Add "Require perfect hits" option for Mania Perfect mod

  Dean Herbert · 2025-05-13 15:14:23 +09:00
  7d596a5565
• Merge pull request #33104 from frenzibyte/adjust-pitch-tooltip

  Fix rate adjust / time ramp mods not showing "Adjust pitch" in tooltip

  Dean Herbert · 2025-05-13 15:11:26 +09:00
  cb59e5acbf
• Merge pull request #33103 from frenzibyte/mod-tooltip-fix

  Fix mod tooltip not handling settings changes to same mod instance

  Bartłomiej Dach · 2025-05-13 08:11:12 +02:00
  05019c775b
• Change implementation to match other implementations

  The previous version was confusing to read.

  Dean Herbert · 2025-05-13 15:10:59 +09:00
  7918685c4e
• Allow switching between details and rankings page via Ctrl-Tab
  Salman Alshamrani · 2025-05-12 16:25:53 +03:00
  39645e5941
• Refactor song select test scenes and add non-filtering area
  Salman Alshamrani · 2025-05-12 15:57:10 +03:00
  168a43a3ae
• Fix rate adjust / time ramp mods not showing "Adjust pitch" in tooltip
  Salman Alshamrani · 2025-05-12 15:14:26 +03:00
  9c77a3e74f
• Fix mod tooltip not handling settings changes to same mod instance
  Salman Alshamrani · 2025-05-12 15:04:51 +03:00
  d5be4bf8d4
• Add failing test case
  Salman Alshamrani · 2025-05-12 15:04:51 +03:00
  62a8c8dfc9
• Merge pull request #33099 from frenzibyte/ssv2-skin

  SongSelectV2: Add back skinning support

  Dean Herbert · 2025-05-12 18:41:02 +09:00
  759ff6301e
• Merge pull request #33101 from peppy/update-framework

  Update framework

  Bartłomiej Dach · 2025-05-12 11:13:28 +02:00
  9b151de89a
• Update framework
  Dean Herbert · 2025-05-12 17:28:20 +09:00
  b31e685380
• Merge pull request #33100 from bdach/fetch-more-scores-for-supporter-leaderboards

  Fetch more scores for supporter scope leaderboards

  Dean Herbert · 2025-05-12 17:24:41 +09:00
  cee0f67417
• Fetch more scores for supporter scope leaderboards

  Which are: global and team leaderboards with mods, and friends and
  country leaderboards.
  
  Only attempting this because of
  https://github.com/ppy/osu/issues/31056#issuecomment-2719787189. Not
  sure if this addresses the concern 🤷

  Bartłomiej Dach · 2025-05-12 09:54:56 +02:00
  934c2440cc
• Add back skinning support
  Salman Alshamrani · 2025-05-12 10:36:14 +03:00
  c3524176a7
• Merge pull request #33090 from smoogipoo/use-fast-invert

  Use fast invert helper in hot path

  Dean Herbert · 2025-05-11 20:46:02 +09:00
  ab60920269
• Use fast invert helper in hot path
  Dan Balasescu · 2025-05-11 13:05:15 +09:00
  ff0a80751a
• Merge pull request #33057 from frenzibyte/star-diff-group

  Display unique group panel for difficulty grouping

  Dean Herbert · 2025-05-09 22:54:28 +09:00
  6d8c457c81
• Merge pull request #33075 from bdach/do-not-allow-reading-garbage-from-hitwindows

  Fix `HitWindows.WindowFor()` returning values for invalid results

  Dean Herbert · 2025-05-09 22:24:26 +09:00
  afe8ab842d
• Merge branch 'master' into perfect-feat
  Krystian Ptach-Żurakowski · 2025-05-09 13:47:58 +02:00
  7b86a3519b