osu-lazer

Update lots of packages (#36996 )

It's been a while.

Notes:

- `SharpCompress` usages changed a bit. Manually adjusted these, mostly
just renames or adjusted parameters.
- nUnit 3 -> 4 migrated using
https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
a mode in this script to update to the newer `Assert.That` syntax but it
requires fixes and couldn't really be bothered.
- DeepEqual nuked as the only usage was on a disabled test. The reason
it's disabled has been merged upstream, but it's failing for other
(realm) reasons which I don't think is worthwhile to investigate for
now.
- This bumps Moq. I think the author is back in a sensible headspace and
the new version has the stupid shit removed, so probably okay? Nice to
be on a level playing field with packages for once in a long time.
- Automapper is silly, but we've discussed this elsewhere.
- `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
a more standardised testing method. Dunno why, don't care.

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-03-17 03:58:02 +09:00

a996261304

Ignore more potentially incorrect data from BASS

This is still a workaround but arguably it's something we could leave in
place without much loss. I think this at least feels better than the
previous code.

Notably, you could argue the test coverage of the fail case is lower
since made it implicit that all tests will avoid the "backwards seek"
detections.  But we never really had tests correctly- fail on the original
so I don't see any loss of value.

Dean Herbert · 2025-08-14 19:20:30 +09:00

82906300b4

Refactor hit windows class structure to reduce rigidity

This change pulls back a significant degree of overspecialisation and
rigidity in the class structure of `HitWindows` to make subsequent
changes to hit windows, whose purpose is to improve replay playback
accuracy, possible to do cleanly.

Notably:

- `HitWindows` is full abstract now. In a few use cases, and as a
  reference for ruleset implementors, `DefaultHitWindows` is provided as
  a separate class instead.

  This fixes the weirdness wherein `HitWindows` always declared 6 fields
  for result types but some of them would never be set to a non-zero
  value or read.

- `HitWindow.GetRanges()` is deleted because it is overspecialised and
  prevents being able to adjust hitwindows by ±0.5ms cleanly which will
  be required later.

  The fallout of this is that the assertion that used `GetRanges()` in
  the `HitWindows` ctor must use something else now, and the closest
  thing to it was `GetAllAvailableWindows()`, which didn't return
  the miss window - so I made it return the miss window and fixed the
  one consumer that didn't want it (bar hit error meter) to skip it.

- Diff also contains some clean-up around `DifficultyRange` to unify
  handling of it.

Bartłomiej Dach · 2025-06-25 08:40:12 +02:00

8b542e5442

Fix test compile failures

Bartłomiej Dach · 2024-10-21 13:57:34 +02:00

1e03bd11a3

Add flag to allow backwards seeks in tests

Dean Herbert · 2024-02-29 23:05:28 +08:00

4184a5c1ef

Fix test compile failures from Audio hoisting

Bartłomiej Dach · 2023-02-21 21:03:00 +01:00

d59d153654

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Add messages to all InvalidOperationExceptions

Without this, they can be very non-descript and hard to track down

Dean Herbert · 2022-06-28 01:34:25 +09:00

569fde4b47

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Replace pragma with add/remove => throw

Salman Ahmed · 2021-11-05 09:10:38 +03:00

b723975767

Remove hacky code with explicit pragma disable

Salman Ahmed · 2021-11-05 03:49:35 +03:00

af6ae1cce5

Fix remaining incorrect filename

Dean Herbert · 2021-07-05 18:56:59 +09:00

cd2916f778

Fix incorrect filename

Dean Herbert · 2021-07-05 18:20:04 +09:00

7645da7d37

13 Commits