8 Commits

• Calculate clock time when creating difficulty hit objects (#36962)

  This change removes `clockRate` precalculation from
  `DifficultyCalculator`.
  
  The idea is that clock rate should be calculated in-place (ideally for
  every object) since we store and access it using DHOs. This also
  prevents anyone from accidentally passing clock rate to skills
  
  Unfortunately osu uses clock rate to calculate OD for the whole map in
  `CreateDifficultyAttributes` so we can't make it completely DHO-based,
  but I think one single in-place call to `ModUtils.CalculateRateWithMods`
  in `CreateDifficultyAttributes` is fine
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  StanR · 2026-03-16 21:17:49 +00:00
  fadb1c3f2c
• Fix tests
  Bartłomiej Dach · 2024-11-21 13:06:01 +01:00
  42f2ad2423
• Fix test
  Bartłomiej Dach · 2024-11-01 18:26:49 +01:00
  03fc744e92
• Merge branch 'master' into bat-max-performance
  Bartłomiej Dach · 2024-11-01 13:13:20 +01:00
  3dc2408965
• Fix ruleset not being reset correctly in tests
  Dan Balasescu · 2024-10-22 14:20:10 +09:00
  17702ead0b
• Add test
  Dan Balasescu · 2024-10-17 22:03:53 +09:00
  03094533b4
• Add mod-related tests
  Dan Balasescu · 2024-10-17 22:01:55 +09:00
  c0eda3606c
• Add test scene
  Dan Balasescu · 2024-10-17 21:18:44 +09:00
  f3178b1fef