Salman Alshamrani
86b240d131
Add failing test cases
2024-10-13 11:01:17 -04:00
Dean Herbert
868a7db9e9
Start preparing player earlier when quick retrying
...
Should help with https://github.com/ppy/osu/issues/9039 .
2024-10-13 22:29:00 +09:00
Dan Balasescu
9681e3ac46
Overwrite downloaded data packages
...
In https://github.com/ppy/osu/actions/runs/11311858931/job/31458581002 , I cancelled the run during the download from `data.ppy.sh`.
In https://github.com/ppy/osu/actions/runs/11313128285/job/31461534857 , `wget` skipped downloading the file due to the `-nc` option (no-clobber), i.e.: if the file exists, don't re-download.
The only way I'm aware of to resolve this with wget is to either use `-c` (continue), which may lead to broken files, or to explicitly specify the output file via `-O`. Thought I'd clean up a few pieces in the process.
Why not curl? Mostly historical - some distros don't come with curl. It may be okay now but there's probably no point changing this at the moment...
2024-10-13 18:43:02 +09:00
Dan Balasescu
9abca53829
Merge pull request #30246 from Joehuu/recommend-csdevkit-instead
...
Recommend C# Dev Kit extension on VSCode
2024-10-13 15:02:03 +09:00
finadoggie
6bcfed8963
Revert "remove score debugging code I accidentally left in"
...
This reverts commit 5192599543
2024-10-12 16:53:32 -07:00
finadoggie
5192599543
remove score debugging code I accidentally left in
2024-10-12 16:45:34 -07:00
finadoggie
88af57818c
only assign countLargeTickMiss for slider accuracy scores
...
helps indicate it should only be used for slider acc scores
2024-10-12 15:36:42 -07:00
finadoggie
29b1697a70
consolidated if statements for getting effectiveMissCount and countSliderEndsDropped
2024-10-12 15:34:04 -07:00
finadoggie
3ac6a9f0ae
Join variable assignments with declarations
2024-10-12 15:30:02 -07:00
Jonas Brandstötter
dcd3e5194e
Group HitResults with the same name into one column in beatmap ranking
...
Closes #29911
2024-10-12 22:53:08 +02:00
Joseph Madamba
e1e8e39a89
Recommend C# Dev Kit extension on VSCode
2024-10-12 12:12:40 -07:00
Artemis Rosman
e4f9c861ba
Add functionality to mass reset offsets
2024-10-13 00:50:45 +11:00
Dan Balasescu
2de1955892
Merge pull request #30218 from bdach/daily-challenge-conclusion-offline
...
Do not show daily challenge conclusion notification on disconnection
2024-10-12 18:14:22 +09:00
finadoggie
3b517e03aa
Convert estimateSliderEndsDropped assignment into '?:' expression
...
I would just like to say that I don't know why anyone would ever want this but github told me to do it
2024-10-12 01:08:39 -07:00
finadoggie
b921424461
Update to use variable usingClassicSliderAccuracy
2024-10-12 01:00:15 -07:00
Fina
3d7f4aec99
Merge branch 'ppy:master' into estimation-removal
2024-10-12 00:44:13 -07:00
Joseph Madamba
71b08b54c1
Make TernaryStateRadioMenuItem localisable
2024-10-11 18:48:04 -07:00
schiavoanto
fc1ebfdf64
Fix layers dropdown localised entries
2024-10-12 02:00:51 +02:00
schiavoanto
9cd7f2b5d4
Use LocalisableDescription for skin editor layers dropdown
2024-10-12 01:38:52 +02:00
schiavoanto
1e7e2e0b1c
Add more localisation in skin editor
2024-10-12 00:55:33 +02:00
OliBomby
9f73a45580
Explicitly assert specific grid type
2024-10-11 23:57:26 +02:00
Dean Herbert
8b046f60f0
Update test
2024-10-12 02:23:43 +09:00
Dean Herbert
b62d9f8696
Fix bindings being clobbered
2024-10-12 02:19:02 +09:00
Dean Herbert
05c8b3cbce
Simplify cycle logic
2024-10-12 02:18:36 +09:00
Dean Herbert
d07a2fbb57
Change shortcut to Shift+G
2024-10-12 02:18:08 +09:00
Dean Herbert
3a8ed889b5
Merge pull request #30215 from bdach/fix-music-controller
...
Fix track restarting when trying to switch track change direction with shuffle active
2024-10-12 01:41:44 +09:00
Bartłomiej Dach
4e8e4a34bd
Fix scale popover doing things when both scale axes are turned off
...
Spotted in passing when reviewing https://github.com/ppy/osu/pull/30080 .
The popover would very arbitrarily revert to scaling by Y axis if both
checkboxes were checked off.
Not sure how this passed review.
2024-10-11 15:18:43 +02:00
Bartłomiej Dach
5db1f05953
Merge branch 'master' into clamp-scale2
2024-10-11 15:13:54 +02:00
Bartłomiej Dach
d1da1d4079
Rename methods to fit new changes better
2024-10-11 15:03:30 +02:00
Bartłomiej Dach
07d15cc35a
Add positive assertion for conclusion notification being present too
2024-10-11 14:31:30 +02:00
Bartłomiej Dach
968835bb44
Do not show daily challenge conclusion notification on disconnection
...
Closes https://github.com/ppy/osu/issues/30194 .
2024-10-11 14:18:19 +02:00
Bartłomiej Dach
9d1eb842a7
Add failing test
2024-10-11 14:16:24 +02:00
OliBomby
550e575221
Rename "Cycle grid display mode" to "Cycle grid spacing"
...
The "display mode" is easy to confuse with grid type, so I renamed it to literally the grid property it affects.
2024-10-11 14:09:50 +02:00
OliBomby
56bfcde446
Update grid placement tool test
...
I somehow missed this test when splitting up PRs so here it is now
2024-10-11 14:09:50 +02:00
OliBomby
ada20d230a
Fix grid type cycling not taking into account the radio button selection
2024-10-11 14:09:50 +02:00
OliBomby
b93bc21e45
Add back the old keybind for cycling grid spacing
2024-10-11 14:09:50 +02:00
OliBomby
e56a9d2ad4
Add TestGridFromPoints
2024-10-11 14:09:50 +02:00
OliBomby
bfe78ff3a0
fix grid test
2024-10-11 14:09:50 +02:00
OliBomby
d98cc7fe66
use G to change grid type
2024-10-11 14:09:50 +02:00
Bartłomiej Dach
4a16341a94
Fix crash when switching tracks back and forth with shuffle on
2024-10-11 12:45:14 +02:00
Bartłomiej Dach
1a25e9d179
Add another failing test case for crash
2024-10-11 12:45:03 +02:00
Bartłomiej Dach
47cb696b69
Fix switching direction when changing tracks with shuffle on restarting the same track
...
Closes https://github.com/ppy/osu/issues/30190 .
2024-10-11 12:40:45 +02:00
Bartłomiej Dach
0882f1bb70
Add failing test case
2024-10-11 12:33:43 +02:00
WitherFlower
da376c534b
Filter out unranked/unsubmitted beatmaps when using the ranked/submitted search filters
2024-10-11 09:49:47 +02:00
Dan Balasescu
616c2aeefc
Merge pull request #30206 from minetoblend/fix/selection-box-buttons-stuck
...
Fix SelectionBox buttons freezing when button is triggered via key event
2024-10-11 12:02:58 +09:00
Marvin Schürz
af55585dc8
Make TriggerAction public
2024-10-10 20:50:47 +02:00
Marvin Schürz
fc7ad96fcd
Move circle flash to TriggerAction
2024-10-10 20:20:02 +02:00
Marvin Schürz
9cc6ee2ebc
Fix SelectionBox buttons freezing when button is triggered via key event
2024-10-10 20:14:11 +02:00
Dan Balasescu
c545269eec
Merge pull request #30198 from bdach/thank-you-discord-once-more
...
Fix discord RPC complaining yet again if given a single space character as activity state / details
2024-10-11 01:15:56 +09:00
Dean Herbert
14ecd56913
Merge pull request #30195 from bdach/advanced-stats-stupid-shenanigans
...
Fix crashes when attempting to change from a custom ruleset with mods selected to another
2024-10-11 00:57:28 +09:00
