73303 Commits

This Branch

This Branch

All Branches

• Emit important replay frames on every judgement

  - Closes https://github.com/ppy/osu/issues/4287
  - Probably closes https://github.com/ppy/osu/issues/25405 (but not
    retroactively)
  
  Up until now, whether or not a replay frame is emitted depended solely
  on the user's input, i.e. mouse movement or key presses/releases. This,
  intersected with the replay playback system which is given allowance to
  perform interpolation between replay frames, leads to potential
  situations wherein a replay can play inaccurately when a judgement takes
  place without user input meaningfully changing. One such case is slider
  ends with their 36ms of judgement leniency; see
  https://github.com/ppy/osu/issues/25405#issuecomment-2879031106 for
  details on that.
  
  To that end, this commit aims to counteract that issue by *forcing* an
  important replay frame to be emitted on every new judgement recorded
  during gameplay. This will only benefit rulesets wherein judgements can
  occur that are not inherently tied to user input changing, which are
  going to be osu! as mentioned above, and maybe possibly catch. I don't
  foresee this doing anything relevant for taiko or mania.

  Bartłomiej Dach · 2025-05-15 11:43:09 +02:00
  9f91c2e25c
• Merge pull request #33067 from frenzibyte/full-sorting-support

  Implement complete sorting mode support

  Dean Herbert · 2025-05-15 03:44:26 +09:00
  5939f51558
• Merge pull request #33133 from frenzibyte/ssv2-management-interface

  SongSelectV2: Expose method for opening editor and clearing local scores

  Dean Herbert · 2025-05-15 01:56:49 +09:00
  2035db6ab6
• Move dependency to correct class and use more appropriate name
  Dean Herbert · 2025-05-15 01:55:49 +09:00
  5eb14a5b26
• Merge pull request #33130 from bdach/fix-slider-extend-handle-crash

  Fix crashes when attempting to adjust length of slider whose maximum path length is less than the current beat snap

  Dean Herbert · 2025-05-14 23:20:31 +09:00
  4e27f495ab
• Expose general song select operations
  Salman Alshamrani · 2025-05-14 15:43:44 +03:00
  8fe422c35a
• Merge branch 'master' into full-sorting-support
  Bartłomiej Dach · 2025-05-14 14:42:29 +02:00
  a57ca72ccf
• Fix test failure
  Bartłomiej Dach · 2025-05-14 14:41:44 +02:00
  9899541fbb
• Fix some botched assertions
  Bartłomiej Dach · 2025-05-14 14:25:38 +02:00
  81e6d6a2de
• Merge pull request #33128 from peppy/carousel-user-scroll-accounting

  Fix new (beatmap) carousel not correctly accounting for user scroll overrides

  Bartłomiej Dach · 2025-05-14 13:57:41 +02:00
  a881498333
• Merge pull request #33127 from peppy/ssv2-backdoor

  Allow accessing song select v2 by holding control while entering song select

  Bartłomiej Dach · 2025-05-14 13:52:56 +02:00
  abd92200d9
• Merge branch 'master' into ssv2-backdoor
  Salman Alshamrani · 2025-05-14 14:43:58 +03:00
  650675e96a
• Fix crashes when attempting to adjust length of slider whose maximum path length is less than the current beat snap

  Closes https://github.com/ppy/osu/issues/32289.
  
  There are two possible choices here: either pulling the lower bound of
  the clamp down to `HitObject.Path.CalculatedDistance`, or pulling the
  higher bound up to `minDistance`, if it happens to be larger than the
  path's calculated distance.
  
  Both options are a bit weird; pulling down can result in unsnapped
  sliders when attempting to drag a slider's end when on a lower beat
  divisor than was used to place the slider, and pulling up can result in
  weird sliders wherein they get extended beyond their path's definition
  with a weird linear section at the end without an anchor that is tangent
  to the slider shape's end. I decided the first one was less weird, but
  I'm open to discuss further.

  Bartłomiej Dach · 2025-05-14 13:34:12 +02:00
  9b2f25cb93
• Merge pull request #33129 from bdach/remove-replay-recorder-depth-hack
  Dean Herbert · 2025-05-14 20:32:23 +09:00
  5d898525c6
• Make class partial
  Bartłomiej Dach · 2025-05-14 12:40:40 +02:00
  c7bfd2a52e
• Rename one more test
  Bartłomiej Dach · 2025-05-14 12:36:26 +02:00
  81689f7c69
• Fix test naming
  Dean Herbert · 2025-05-14 19:30:45 +09:00
  35e2094ed4
• Implement complete sorting mode support
  Salman Alshamrani · 2025-05-14 19:21:57 +09:00
  1a02e3266b
• Add test coverage for beatmap carousel v2 sort support
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  073b1810b3
• Allow tests to accedss CarouselItems post filter operation
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  8e15af2b2d
• Remove unnecessary replay recorder depth hack

  Addresses https://github.com/ppy/osu/pull/33102#discussion_r2087963889.

  Bartłomiej Dach · 2025-05-14 11:25:31 +02:00
  acebf3e95e
• Add baseline test coverage of replay recording in all rulesets

  Nothing fancy, just basics to ensure the subsequent commit doesn't break
  anything.

  Bartłomiej Dach · 2025-05-14 11:25:14 +02:00
  168c3cf018
• Fix new (beatmap) carousel not correctly accounting for user scroll overrides

  The new carousel implementation was lacking some scroll related
  behaviours. This makes sure that post-filter, the selection is
  re-centered *unless* the user has scrolled away manually.
  
  This matches the old carousel's behaviour. See
  https://github.com/ppy/osu/pull/16647 for original implementation.
  
  Closes https://github.com/ppy/osu/issues/33052.

  Dean Herbert · 2025-05-14 17:32:44 +09:00
  a8d8d2d84c
• Allow accessing song select v2 by holding control while entering song select
  Dean Herbert · 2025-05-14 17:06:18 +09:00
  0a3f05c52b
• Merge pull request #33120 from frenzibyte/ssv2-cache-class

  SongSelectV2: Fix `SongSelect` not cached for subcomponents

  Dean Herbert · 2025-05-14 10:47:01 +09:00
  93fda73062
• Merge pull request #33119 from frenzibyte/ssv2-mod-audio

  SongSelectV2: Apply mod adjustments to beatmap track

  Dean Herbert · 2025-05-14 01:36:57 +09:00
  7b93351197
• Fix SongSelect not cached for subcomponents
  Salman Alshamrani · 2025-05-13 15:32:44 +03:00
  74d10e2a62
• Apply mod adjustments to beatmap track
  Salman Alshamrani · 2025-05-13 15:24:18 +03:00
  bd136b88c6
• Merge pull request #32972 from bdach/multiplayer-position-indicator

  Add non-skinnable position indicator to multiplayer player

  Dean Herbert · 2025-05-13 20:53:15 +09:00
  3ce5389558
• Merge pull request #33117 from frenzibyte/ssv2-volume-keybinds

  SongSelectV2: Allow adjusting volume by scrolling

  Dean Herbert · 2025-05-13 20:34:33 +09:00
  366e0deefe
• Allow scrolling to adjust volume
  Salman Alshamrani · 2025-05-13 14:08:12 +03:00
  0b6e36d61e
• Fix multiplayer position display not hiding on user change
  Bartłomiej Dach · 2025-05-13 11:47:01 +02:00
  1d3f4ac02b
• Merge pull request #33056 from frenzibyte/fix-difficulty-sorting

  Display separate design for beatmap panels on difficulty sort mode

  Dean Herbert · 2025-05-13 18:43:57 +09:00
  2dceee8ba9
• Fix code inspection
  Bartłomiej Dach · 2025-05-13 11:37:52 +02:00
  79f88528ae
• Merge pull request #33111 from peppy/fix-letterbox-rewind

  Fix letterbox overlay potentially fading incorrectly during seeks

  Bartłomiej Dach · 2025-05-13 11:18:38 +02:00
  464ad4ec77
• Update existing test coverage

  Add test coverage

  Salman Alshamrani · 2025-05-13 17:59:07 +09:00
  b26fe702ba
• Display separate design for beatmap panels on difficulty sort mode
  Salman Alshamrani · 2025-05-13 17:58:18 +09:00
  f58cf8e971
• Merge pull request #33114 from bdach/solo-results-dont-show-best-if-beat

  Do not show previous best score on solo results screen if the local user just beat it

  Dean Herbert · 2025-05-13 17:50:45 +09:00
  a360f153f7
• Fix exceptions being hidden by async task usage
  Dean Herbert · 2025-05-13 17:43:57 +09:00
  36317bc459
• Merge pull request #33106 from frenzibyte/ssv2-rate-adjust-keybinds

  SongSelectV2: Add rate adjustment keybinds

  Dean Herbert · 2025-05-13 17:33:53 +09:00
  7c5e146bbe
• Add rate adjustment keybinds

  Add test coverage

  Salman Alshamrani · 2025-05-13 17:30:38 +09:00
  1b2054c49d
• Remove completely pointless test scene
  Dean Herbert · 2025-05-13 17:30:32 +09:00
  538e5aed19
• Merge pull request #33107 from frenzibyte/ssv2-ctrl-tab

  SongSelectV2: Allow switching between details and rankings page via keyboard

  Dean Herbert · 2025-05-13 17:24:31 +09:00
  a6fc700cd5
• Merge pull request #33105 from frenzibyte/ssv2-refactor-tests

  SongSelectV2: Refactor test scenes to have a place for non-filtering tests

  Dean Herbert · 2025-05-13 17:22:55 +09:00
  74a3ac4622
• Move "local" test to "navigation" namespace
  Dean Herbert · 2025-05-13 17:22:01 +09:00
  238855c4cc
• Do not show previous best score on solo results screen if the local user just beat it

  Closes https://github.com/ppy/osu/issues/33109.

  Bartłomiej Dach · 2025-05-13 10:17:09 +02:00
  a5ea24e37b
• Add failing test coverage for expected behaviour
  Bartłomiej Dach · 2025-05-13 10:15:54 +02:00
  3c219a799b
• Fix letterbox overlay potentially fading incorrectly during seeks

  Pushing this out with zero testing as a "probably fixes"
  https://github.com/ppy/osu/issues/33108.
  
  Previous logic would mean that the start value of the fade-in may not be
  zero depending on current state, leaving the final alpha state incorrect
  after a rewind beyond the start time.

  Dean Herbert · 2025-05-13 17:09:20 +09:00
  83891b104d
• Roll the rank counter instead of immediate updates
  Dean Herbert · 2025-05-13 17:04:47 +09:00
  eaa7af58d5
• Improve transition fade in/out
  Dean Herbert · 2025-05-13 16:45:12 +09:00
  e7d26669c0