osu-lazer

Merge pull request #34087 from peppy/song-select-v2-deletion-handling

Improve song select's automatic selection behaviour when current selection is no longer valid

Dean Herbert · 2025-07-10 21:52:29 +09:00

8ff2100560

Simplify post-hide selection

Dean Herbert · 2025-07-10 21:08:57 +09:00

acdd246518

Add test coverage of ruleset changes, ensuring same beatmap is preferred if possible

Dean Herbert · 2025-07-10 18:13:38 +09:00

5bc1dd1415

Disallow hiding beatmap difficulties if only one difficulty remains

Dean Herbert · 2025-07-10 17:57:45 +09:00

789ddcf395

Ensure adjacent selection when currently selected beatmap is hidden

Dean Herbert · 2025-07-10 17:46:10 +09:00

44bbb7f029

Ensure adjacent selection when currently selected beatmap(set) is deleted

Dean Herbert · 2025-07-10 17:46:09 +09:00

994bd4abfe

Merge pull request #33889 from frenzibyte/source-grouping

Add mode for grouping beatmaps by their source

Dean Herbert · 2025-07-08 17:09:45 +09:00

3406303060

Merge pull request #33818 from diquoks/ssv2-localisation-overlap

Define separate strings for song select's difficulty statistics display (and add a maximum width limit)

Dean Herbert · 2025-07-07 12:25:19 +09:00

3becc61c53

Update existing tests to work with Song Select v2

Dean Herbert · 2025-07-01 17:25:38 +09:00

397b9b3994

Update TestGroupingByDifficulty to account for floored star rating

Chris Ehmann · 2025-06-30 19:52:40 -07:00

8ae8d847d5

Add test coverage

Salman Alshamrani · 2025-06-26 10:05:21 +03:00

7a1c7fbd7d

Fix flaky carousel test due to out of range async filter operation

See
https://github.com/ppy/osu/actions/runs/15868654672/job/44740248052?pr=33873#step:5:49.

Dean Herbert · 2025-06-25 15:45:41 +09:00

f1e23595e7

Merge pull request #33773 from peppy/fix-carousel-random-not-respecting-group

SongSelectV2: Refine random selection to currently open group (and support difficulty split panels better)

Bartłomiej Dach · 2025-06-24 14:37:09 +02:00

a797c46d75

Expand test even further to cover even more potential weirdness

Bartłomiej Dach · 2025-06-24 13:32:42 +02:00

0de964b10b

Expand test to cover more potential weirdness and fix said weirdness

Dean Herbert · 2025-06-24 19:21:04 +09:00

7b6ecbd10b

Fix potential crash when attempting random selection after changing grouping mode

Dean Herbert · 2025-06-24 17:48:38 +09:00

a1ec71e677

Merge pull request #33664 from peppy/footer-metrics

Remove fade from footer display transition

Bartłomiej Dach · 2025-06-24 07:45:29 +02:00

02ce399150

Add maximum limit to wedge difficulty statistics

Salman Alshamrani · 2025-06-23 03:34:19 +03:00

4203f2cdeb

Fix tests

Dean Herbert · 2025-06-20 20:37:58 +09:00

3af0ce7e5e

Merge branch 'master' into fix-another-case-of-keyboard-weird

Dean Herbert · 2025-06-20 02:16:54 +09:00

0e34752e5f

Merge pull request #33668 from peppy/ssv2-group-key-bindings

Bartłomiej Dach · 2025-06-19 17:35:28 +02:00

267a6a0ac7

SongSelectV2: Fix pressing multiple traversal keys in same frame causing weirdness

Closes #33453.

Dean Herbert · 2025-06-19 18:30:57 +09:00

6350e6d1a7

SongSelectV2: Fix random selection not working as expected when displaying individual difficulties

Previously, random selection would always be done at a *set* level. The
final operation of a random action would be "select the user's
recommended difficulty from this randomly selected set".

This makes no sense when sets are not grouped together at song select.
In fact, it is completely broken with the previous commit which adds
group-isolated random support – if we're grouping by difficulty and the
user's recommendation is not in the current group it would throw the
user into another group unexpectedly.

This fixes the issue by splitting out the random implementation into two
separate pathways depending on the carousel display mode.

Dean Herbert · 2025-06-19 17:29:41 +09:00

f676206331

SongSelectV2: Fix random button not respecting open group

Closes https://github.com/ppy/osu/issues/33569.

Dean Herbert · 2025-06-19 17:29:41 +09:00

d200a59902

Adjust rank formatting logic to avoid getting cut in score

Salman Alshamrani · 2025-06-18 01:52:26 +03:00

1ceb59d78e

Fix group selection acting weirdly when only one group is present

Dean Herbert · 2025-06-17 22:39:51 +09:00

27d4ad7991

Merge pull request #33737 from peppy/fix-mods-button-after-start

Fix mod button still working after gameplay start if player is not fully loaded

Dan Balasescu · 2025-06-17 17:43:47 +09:00

019b37285c

Fix mod button still working after gameplay start if player is not fully loaded

Dean Herbert · 2025-06-17 16:49:52 +09:00

e74f687c30

Add specific cases to visual test

Joseph Madamba · 2025-06-16 22:46:10 -07:00

bd1002c620

Fix crash when random and rewind are run on the same frame

Dean Herbert · 2025-06-16 20:17:07 +09:00

10c07fdf50

Add back random button tests

Dean Herbert · 2025-06-16 19:59:30 +09:00

05a50f523c

Add localisation support to difficulty range slider

Salman Alshamrani · 2025-06-14 15:05:05 +03:00

977c26d02f

Add support for toggling current group expansion using shift-enter

Closes https://github.com/ppy/osu/issues/33617.

Dean Herbert · 2025-06-12 20:36:02 +09:00

52ba22ca1f

Add support for traversing between groups using shift-left/right

Closes https://github.com/ppy/osu/issues/33599.

Dean Herbert · 2025-06-12 20:36:02 +09:00

3816c5d95f

Ensure filtering is always waited on after a sort/filter change in tests

Dean Herbert · 2025-06-12 19:45:06 +09:00

d592b984e3

Add all beatmaps in one go in tests to avoid hundreds of callbacks

Just makes debugging easier.

Dean Herbert · 2025-06-12 19:45:06 +09:00

054544818c

Give better feedback from test assertion

There's a flaky test and currently the fail output it not really
helpful. This makes it slightly more relevant.

Dean Herbert · 2025-06-12 19:45:06 +09:00

7dba17f6b8

Move and rename next/previous "group" selection keybindings to make way for group-specific bindings

Dean Herbert · 2025-06-11 21:02:52 +09:00

b9e1b6969e

Merge pull request #33598 from peppy/ssv2-difficulty-traversal-selection

Allow changing difficulties using up and down arrows when sets are grouped

Bartłomiej Dach · 2025-06-11 08:34:10 +02:00

932ba3d590

Remove shear on update button to match non-sheared panel design

Dean Herbert · 2025-06-10 14:01:49 +09:00

8afac6a00d

Allow changing difficulties using up and down arrows when sets are grouped

Dean Herbert · 2025-06-10 13:06:30 +09:00

cc150faf81

SongSelectV2: Add back highlighting friend scores on the leaderboard

Bartłomiej Dach · 2025-06-06 13:53:32 +02:00

90084e27e5

Fix several issues with leaderboard score display

- Enforces minimum width on accuracy / max combo displays which could
  previously look broken in CJK languages, thus fixing
  https://github.com/ppy/osu/issues/33434. Minimum sizes were chosen to
  accomodate what could be considered reasonably possible with some
  leeway on top.

- Fixes hilariously broken logic that was supposed to highlight perfect
  / FC / max combo scores in green but instead did nothing due to two
  disparate bugs in a single line of code.

- Extends the highlighting logic to also apply to 100% accuracy because
  web does this and I think it's nice.

Bartłomiej Dach · 2025-06-06 11:25:02 +02:00

b61688596b

Add failing test showing recommended selection occurring on already selected set

Dean Herbert · 2025-06-04 21:19:51 +09:00

7e922763c1

Add failing test coverage showing bad selection logic

Dean Herbert · 2025-06-04 15:45:36 +09:00

b42b8ba0de

Store input padding adjustments in CarouselItem to allow more reliable inflation

Dean Herbert · 2025-06-02 19:11:47 +09:00

90b9fb0809

Merge branch 'master' into song-select-v2-fix-random-difficulty-filtered