1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-21 08:32:54 +08:00
Commit Graph

54423 Commits

Author SHA1 Message Date
Bartłomiej Dach
298efa5391
Fix broken ShearedButton autosizing logic 2022-08-01 22:04:16 +02:00
Bartłomiej Dach
923d9a4e5f
Add failing assertions to demonstrate autosize failure 2022-08-01 22:04:14 +02:00
NaiPofo
3356909026
Merge branch 'master' into overlay-filter-rank 2022-08-01 21:54:44 +02:00
Salman Ahmed
7354f9e6ba Remove localisation for now 2022-08-01 22:05:52 +03:00
Dean Herbert
c0e5f11c90
Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability
Fix newly imported beatmaps not using correct comparer for sorting
2022-08-02 02:20:51 +09:00
Salman Ahmed
7e9d11ee24 Enable NRT on playlists settings overlay 2022-08-01 20:15:08 +03:00
Salman Ahmed
c851e3d8f3 Fix playlist settings reference leak due to unsafe callback binding 2022-08-01 20:08:18 +03:00
notmyname
6686b09549 Hide F rank from beatmap overlay 2022-08-01 18:54:00 +02:00
andy840119
b1d320bf67 Use non-nullable instead in the taiko ruleset. 2022-08-02 00:48:23 +08:00
andy840119
1fe7e4d19a Use non-nullable instead in the catch ruleset. 2022-08-02 00:45:47 +08:00
Salman Ahmed
fc7fc3d673 Fix newly imported beatmaps not using correct comparer for sorting 2022-08-01 19:13:57 +03:00
Dean Herbert
0fcae08d38 Show "locally modified" pill when local modifications have been made 2022-08-02 00:52:38 +09:00
Dean Herbert
01cc9bd7ef
Merge pull request #19479 from frenzibyte/carousel-update-on-resume
Fix song select not updating selected beatmap card on editor resume
2022-08-02 00:48:18 +09:00
Salman Ahmed
682192dbd7 Add failing test case 2022-08-01 18:43:01 +03:00
Dean Herbert
c53a4f1c45
Merge pull request #16589 from mk56-spn/Wiggle-strength-duration
Add strength setting for wiggle mod
2022-08-02 00:03:53 +09:00
Dean Herbert
a5fac70c3b Rename variable to not include mode name itself 2022-08-01 23:30:00 +09:00
Dean Herbert
d09976bb39 Merge branch 'master' into Wiggle-strength-duration 2022-08-01 23:29:03 +09:00
Salman Ahmed
49ee78babb
Merge pull request #19500 from andy840119/remove-nullable-disable-in-the-audio-namespace
Remove nullable disable annotation in audio namespace
2022-08-01 15:59:19 +03:00
Salman Ahmed
7c9f8648a5
Merge branch 'master' into remove-nullable-disable-in-the-audio-namespace 2022-08-01 15:25:12 +03:00
Dean Herbert
8ef777405d
Merge pull request #19262 from goodtrailer/stable-slider-tick-anims
Imitate stable's slider followcircle tick-based behavior
2022-08-01 21:11:33 +09:00
Salman Ahmed
03eccc2f7e
Merge branch 'master' into stable-slider-tick-anims 2022-08-01 15:01:09 +03:00
andy840119
6cccb6b848 Remove canBeNull: true. 2022-08-01 19:45:15 +08:00
Salman Ahmed
3ff0327d91 Display readable message when reaching download limit 2022-08-01 14:22:54 +03:00
Salman Ahmed
2465e8ed68
Merge pull request #19508 from gutyina70/fix-tags-overflow
Prevent tags overflowing on beatmap info overlay
2022-08-01 13:16:04 +03:00
Salman Ahmed
2a127c6ef8
Merge branch 'master' into fix-tags-overflow 2022-08-01 12:40:43 +03:00
Dan Balasescu
d4eec9122f
Merge pull request #19516 from peppy/fix-editor-track-disposal-crash
Fix editor potentially playing a track post-disposal
2022-08-01 18:12:21 +09:00
Dean Herbert
e0940c6c22 Update animations to final versions 2022-08-01 18:03:32 +09:00
Dean Herbert
0b8d3cbce9 Merge branch 'master' into stable-slider-tick-anims 2022-08-01 18:03:22 +09:00
Dan Balasescu
225033c3b2
Merge pull request #19517 from peppy/add-more-missing-realm-refreshres
Add more missing realm `Refresh()` calls to new beatmap import tests
2022-08-01 17:54:51 +09:00
Dean Herbert
14c2348df7
Merge pull request #19514 from peppy/dont-throw-copy-failure-migration
Fix migration failing on single file copy failure
2022-08-01 17:43:05 +09:00
Dean Herbert
0d9edcfa24
Merge branch 'master' into stable-slider-tick-anims 2022-08-01 17:40:16 +09:00
Gutyina Gergő
c65747d1b8 Use masking instead of scrollable container to prevent tags overflow 2022-08-01 10:36:53 +02:00
Dan Balasescu
5f9c3b42e8
Merge pull request #19513 from peppy/isolate-development-storage
Isolate development builds' storage from release builds
2022-08-01 17:30:25 +09:00
Dan Balasescu
1d27c4f020
Merge pull request #19504 from peppy/skin-serialisation-test-coverfage
Add test coverage of deserialisation of skin layouts
2022-08-01 17:17:16 +09:00
Dean Herbert
e0aaacc419
Merge pull request #19467 from frenzibyte/taiko-samples-priority
Allow osu!taiko hitsounds to fall back to classic skin rather than use non-taiko samples
2022-08-01 17:10:50 +09:00
Dean Herbert
ee68113913 Add more missing realm Refresh() calls to new beatmap import tests
As noticed at https://github.com/ppy/osu/runs/7605101313?check_suite_focus=true
2022-08-01 17:06:46 +09:00
Dean Herbert
cc8a71b65d Re-query file existence before failing a recursive copy operation during migration 2022-08-01 17:01:19 +09:00
Dean Herbert
59210ecc9d Revert "Fix migration failing on single file copy failure"
This reverts commit fc8835d43a.
2022-08-01 16:57:50 +09:00
Dean Herbert
6e7c298aaf Fix changes to audio / background not triggering an editor state change 2022-08-01 16:53:49 +09:00
Dean Herbert
2f60f91a0e Fix editor potentially using a track post-disposal
This changes the editor to track the current track as it is *loaded* by
`MusicController`, rather than haphazardly following the current global
`WorkingBeatmap` (with a potentially unloaded track) or relying on local
immediate-load behaviour (as implemented in `ResourcesSection`).
2022-08-01 16:53:49 +09:00
Dean Herbert
2519706ad6 Add test coverage of editor crash 2022-08-01 16:53:49 +09:00
Dan Balasescu
47860bb966
Remove unused using 2022-08-01 16:33:59 +09:00
Dean Herbert
fc8835d43a Fix migration failing on single file copy failure
No longer throw if copying of single files fails during data migration.

Aiming to fix https://github.com/ppy/osu/runs/7601653833?check_suite_focus=true, which could also affect end users. I've left a limit before an exception is still thrown, to handle cases like the user running out of disk space (where we probably *do* want to bail, so they can continue to use their still-intact original storage location).

If this isn't seen as a good direction, an alternative will be to make the migration code aware of the structure of the temporary files created by `Storage` (but doesn't guarantee this will cover all cases of such temporary files – there could for isntance be metadata files created by the host operating system).

Another option would be to mark those temporary files as hidden and skip any hidden files during iteration.
2022-08-01 15:02:39 +09:00
Dan Balasescu
5335d60748
Merge pull request #19407 from andy840119/remove-nullable-disable-in-the-mods-for-osu-ruleset
Remove nullable disable annotation in mods for osu ruleset.
2022-08-01 14:51:48 +09:00
Dean Herbert
8ee4f1e60b
Merge pull request #19510 from bdach/mod-overlay/presets-persistence
Add persistence of mod presets to realm
2022-08-01 14:43:52 +09:00
Dean Herbert
a5f48e336a Isolate development builds' storage from release builds 2022-08-01 14:38:02 +09:00
Dean Herbert
3b6349a145 Add test coverage of remaining components which weren't already included 2022-08-01 14:16:26 +09:00
Dean Herbert
d112743cea Improve test coverage of skin serialisation to ensure full coverage
Will fail when new skinnable components are added until they have
coverage in resources.
2022-08-01 14:04:12 +09:00
Dean Herbert
5b98a73edc Apply nullability to SkinComponentToolbox and split out reflection method to get all skinnable components 2022-08-01 14:04:08 +09:00
Dan Balasescu
415d6def2d Remove unnecessary AsNonNull() 2022-08-01 13:22:58 +09:00