73488 Commits

This Branch

This Branch

All Branches

• Merge pull request #33241 from bdach/participant-list-transform-spam

  Implement list virtualisation in multiplayer participants list

  Dean Herbert · 2025-05-26 23:58:27 +09:00
  7cc89dfd4e
• Merge pull request #33264 from peppy/song-select-v2-hookup

  SongSelectV2: Hook up screen to carousel and move selection logic up one level

  Dean Herbert · 2025-05-26 23:49:54 +09:00
  dc09d170f3
• Merge pull request #33259 from LumpBloom7/ruleset-agnostic-concurrent-check

  Make concurrent object check ruleset specific

  Bartłomiej Dach · 2025-05-26 14:33:41 +02:00
  f043a95dbd
• Merge branch 'master' into song-select-v2-hookup
  Bartłomiej Dach · 2025-05-26 14:09:05 +02:00
  590194b525
• Fix grammar in comment
  Bartłomiej Dach · 2025-05-26 14:08:56 +02:00
  72bd8b2203
• Merge pull request #33263 from bdach/extensive-bss-logging

  Add even more logging to beatmap submission process

  Dean Herbert · 2025-05-26 19:52:32 +09:00
  998972fc85
• Ensure protected beatmap is reselected on entering screen
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  5212c27a71
• Fix beatmap background not being used at new song select
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  d0a1b40a84
• Update tests to no longer require local selection
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  e33b92fa5c
• Add basic "eager" selection to ensure something is selected at song select after import
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  4a03240ee6
• Hook up carousel to song select to global beatmap
  Dean Herbert · 2025-05-26 19:32:31 +09:00
  c1e1bfde0a
• Fix BeatmapSetInfo missing GetHashCode implentation

  Causing dictionary lookups to fail when expecting equality
  implementation to work.

  Dean Herbert · 2025-05-26 19:32:31 +09:00
  f3782acddd
• Add test coverage of eager selection behaviours
  Dean Herbert · 2025-05-26 19:32:31 +09:00
  0c76c5297d
• Add even more logging to beatmap submission process

  Every now and again someone will report having done something horrible
  to their beatmap via lazer submission, always claim having done
  "nothing" while invariably having done *something*, will not provide me
  with a workable reproduction scenario, and even if they attempt to do
  so, I will be unable to reproduce the issue anyway. So this change is
  just desperation mostly. It's logging pretty much all that it is
  possible to log of client-side state.

  Bartłomiej Dach · 2025-05-26 11:33:59 +02:00
  c7404cb81d
• Make CheckConcurrentObjects.Run virtual

  And let implementers copy-paste common code.

  Derrick Timmermans · 2025-05-26 10:59:57 +02:00
  0495a03607
• Rename ConcurrentCondition to ConcurrencyPrecondition

  Better describes the intent of the method.

  Derrick Timmermans · 2025-05-26 10:59:17 +02:00
  257767b311
• Use null coalesce wherever possible

  Rider EAP being noisy about this one now.

  Dean Herbert · 2025-05-26 17:15:35 +09:00
  5450298468
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Apply review suggestions
  Bartłomiej Dach · 2025-05-26 09:57:37 +02:00
  ea8ad6b637
• Merge pull request #33256 from peppy/beatmap-title-wedge-fixes

  SongSelectV2: Change beatmap title wedge to use debounced difficulty retrieval

  Dean Herbert · 2025-05-26 16:12:30 +09:00
  5af3921dde
• Merge pull request #33193 from peppy/song-select-v2-context-menus

  Add context menus to new carousel panels

  Dean Herbert · 2025-05-26 15:50:04 +09:00
  598f6c0053
• Adjust BeatmapMetadataDisplay to account for stars always being available now
  Dean Herbert · 2025-05-26 15:34:32 +09:00
  ed51f2345a
• Use more consistent ordering between beatmap & beatmapset panels
  Bartłomiej Dach · 2025-05-26 07:54:25 +02:00
  2d9cc382c8
• Merge branch 'master' into song-select-v2-context-menus
  Bartłomiej Dach · 2025-05-26 07:45:02 +02:00
  c6954fd55d
• Move concurrent hold note tests to mania tests

  The general check no longer considers mania.

  Derrick Timmermans · 2025-05-25 17:33:48 +02:00
  9a254afa0a
• Change BeatmapTitleWedge to use debounced bindable rather than custom flow
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  19f8096dc9
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Flip equality in CheckManiaConcurrentObjects

  Bad copy and paste.

  Derrick Timmermans · 2025-05-25 14:35:59 +02:00
  53340fe4b7
• Make CheckConcurrentObject ruleset specific
  Derrick Timmermans · 2025-05-25 14:19:23 +02:00
  0065696248
• Improve general code quality of beatmap title wedge's difficulty stats updating
  Dean Herbert · 2025-05-25 20:42:13 +09:00
  4e29c59be4
• Fix mod change tracker not being hooked up if mods are present on load
  Dean Herbert · 2025-05-25 20:42:13 +09:00
  bd71c2ce52
• Add back missing using statement
  Dean Herbert · 2025-05-25 20:41:36 +09:00
  48fe2a6723
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Merge pull request #33175 from frenzibyte/carousel-grouping

  Add support for most grouping modes

  Dean Herbert · 2025-05-25 01:31:55 +09:00
  77953aaee4
• Add back two missing actions for beatmap set headers
  Dean Herbert · 2025-05-24 11:28:12 +09:00
  a1426eb8be
• Remove obsoleted flow by using a new configuration variable

  The old one wasn't used anyway.

  Dean Herbert · 2025-05-24 01:01:17 +09:00
  cd44cab3ff
• Handle star difficulty grouping in a way which doesn't require arbitrary nullable data
  Dean Herbert · 2025-05-23 19:49:24 +09:00
  dc519441f9
• Fix weird todo comments..
  Dean Herbert · 2025-05-23 19:43:05 +09:00
  6555e45367
• Fix typo in comment
  Dean Herbert · 2025-05-23 19:37:22 +09:00
  ff48c4a047
• Merge branch 'master' into carousel-grouping
  Dean Herbert · 2025-05-23 19:03:09 +09:00
  0a5fbb35c5
• Fix nasty bug associated with reusing a single panel wrong
  Bartłomiej Dach · 2025-05-23 11:45:25 +02:00
  9742f48437
• Merge pull request #33239 from bdach/analysis-container-test-failure

  Attempt to fix test failures in osu! replay analysis container test

  Dean Herbert · 2025-05-23 18:11:55 +09:00
  faa73f5d04
• Add extra test coverage for multiplayer participants list in team versus
  Bartłomiej Dach · 2025-05-23 10:47:50 +02:00
  fea50ee432
• Refactor team display to fit with pooling better
  Bartłomiej Dach · 2025-05-23 10:47:36 +02:00
  17cf5df668
• Fix tests post-pooling implementation
  Bartłomiej Dach · 2025-05-23 10:47:23 +02:00
  231afbf463
• Implement pooling in multiplayer participants list
  Bartłomiej Dach · 2025-05-23 10:47:07 +02:00
  61e8c25a92
• Modify many users tests to stress it & demonstrate transform overhead
  Bartłomiej Dach · 2025-05-23 10:46:50 +02:00
  40a4129776
• Merge pull request #33209 from bdach/mania-combo-accounting-rewind

  Fix combo accounting when rewinding mania replays

  Dean Herbert · 2025-05-23 16:47:36 +09:00
  fa92fbb9d1
• Add context menus to new carousel panels

  This changes the flow of actions (yet again.. sorry) to standardise what
  is shown on the beatmap options button in the footer and the context
  menus.
  
  This is something I wanted from the start – for devices where right
  click is not available, it's always preferable to have a second method
  of accessing actions which isn't the context menu.
  
  Collection actions are missing for now, as they will come in a second
  pass which includes tidying things up further.
  
  Fix formatting
  
  Duplicate menu items between implementations

  Dean Herbert · 2025-05-23 16:02:13 +09:00
  891f0c469f
• Add icon specification to OsuMenuItem

  This isn't used visually for context menus, but is handy to have when
  using this class to convey more general information about actions,
  including usages outside of context menus where an icon is relevant to
  have.

  Dean Herbert · 2025-05-23 15:46:52 +09:00
  1cf4636d31