12372 Commits

• Add failing test case
  Bartłomiej Dach · 2025-03-18 12:02:12 +01:00
  85076081d2
• Merge pull request #32376 from nekodex/better-kiai-fountain-sfx

  Improve SFX playback behaviour of rapid kiai/star fountain activations

  Dean Herbert · 2025-03-18 17:49:21 +09:00
  aa6d644f70
• Allow testing fountain sound effects in tests
  Dean Herbert · 2025-03-18 16:35:11 +09:00
  533b0e0f88
• Make freestyle not bypass ruleset filter once more
  Dan Balasescu · 2025-03-18 14:32:07 +09:00
  bf3caacf51
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Add the most basic (yet failing) test possible
  Bartłomiej Dach · 2025-03-17 14:52:09 +01:00
  613c46d375
• Merge branch 'master' into set-guest-update
  Bartłomiej Dach · 2025-03-17 12:26:41 +01:00
  05366c2397
• Fix one more test (sorry)
  Dean Herbert · 2025-03-16 14:10:57 +09:00
  4d54f98c55
• Fix failing test
  Dean Herbert · 2025-03-16 13:28:57 +09:00
  3e36820117
• Merge pull request #32346 from bdach/user-tags-on-results

  Add ability to vote for beatmap user tags after completing a play

  Dean Herbert · 2025-03-15 14:36:27 +09:00
  d704adf5fa
• Add failing test
  Dan Balasescu · 2025-03-14 19:11:15 +09:00
  7715a3dd9f
• Fix test
  Bartłomiej Dach · 2025-03-13 12:06:27 +01:00
  723a22130d
• Require high enough score rank for tagging beatmap
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  5b1a4c8ed1
• Simplify boolean flags
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  f78e371b1b
• Merge pull request #32360 from peppy/add-team-beatmap-leaderboards

  Add team beatmap leaderboards

  Bartłomiej Dach · 2025-03-13 10:04:53 +01:00
  0f74f7eed5
• Merge pull request #32352 from smoogipoo/friend-display-user-presence

  Make friends display respond to realtime user presence

  Dean Herbert · 2025-03-13 17:24:57 +09:00
  dc1674105e
• Add support for team beatmap leaderboards
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  b0cf5e8bff
• Merge pull request #31148 from peppy/editor-right-click-as-people-expect

  Add back right-click-for-new-combo and right-click-delete when in object placement mode

  Bartłomiej Dach · 2025-03-13 08:24:08 +01:00
  61ed52eb69
• Add test coverage of friend going offline
  Dean Herbert · 2025-03-13 15:28:04 +09:00
  829dfedfdc
• Fix tests
  Dan Balasescu · 2025-03-13 12:57:29 +09:00
  f00d2cbfa2
• Merge pull request #31882 from smoogipoo/room-subscreen-split

  Rewrite playlists to not inherit `RoomSubScreen`

  Dean Herbert · 2025-03-13 12:29:48 +09:00
  d9f7d13894
• Fix no display if friends already loaded
  Dan Balasescu · 2025-03-13 01:54:36 +09:00
  bfdc7c1688
• Update tests
  Dan Balasescu · 2025-03-13 01:36:32 +09:00
  4b54b8c0d8
• Add visual test coverage of user tag control on results
  Bartłomiej Dach · 2025-03-12 12:20:37 +01:00
  6f74d8ad50
• Add user tag control to results screen's statistics panel
  Bartłomiej Dach · 2025-03-12 12:19:21 +01:00
  d1ce64b3f6
• Remove inheritance in StatisticsPanel
  Bartłomiej Dach · 2025-03-12 12:17:38 +01:00
  5f0451eb79
• Rewrite OverallRanking to interface directly with UserStatisticsWatcher
  Bartłomiej Dach · 2025-03-12 12:17:02 +01:00
  0ffb233796
• Merge pull request #32342 from peppy/move-letterbox-under-hud

  Fix storyboard letterbox hiding HUD elements

  Bartłomiej Dach · 2025-03-12 10:44:52 +01:00
  4633f635a4
• Fix LetterboxOverlay not handling its own visibility
  Dean Herbert · 2025-03-12 17:46:18 +09:00
  77aac2922f
• Add failing test cases that came up in review
  Dean Herbert · 2025-03-12 16:52:35 +09:00
  a492e070fb
• Merge branch 'master' into editor-right-click-as-people-expect
  Dean Herbert · 2025-03-12 14:51:28 +09:00
  083979e299
• Fix storyboard letterbox hiding HUD elements

  Addresses https://github.com/ppy/osu/discussions/29788.

  Dean Herbert · 2025-03-12 14:20:16 +09:00
  72854d0ae6
• Fix default beatmap not being correctly set after aborting new beatmap creation

  Closes https://github.com/ppy/osu/issues/32337.

  Dean Herbert · 2025-03-12 14:01:11 +09:00
  65cdcb4696
• Merge pull request #32221 from bdach/user-tags-visual

  Add visual component for assigning user tags to beatmaps

  Dean Herbert · 2025-03-12 11:37:47 +09:00
  ad04b5b1af
• Fix silly test failures
  Dean Herbert · 2025-03-11 21:28:35 +09:00
  c994489392
• Initial rework of FriendDisplay to use presence

  It's at a very simple stage for now:
  - Tab control is no longer recreated when friends change, counts are
    updated as bindables.
  - All async logic removed temporarily.
  - Sort and filtering happens in realtime without panel reload.
  - Display modes removed for now. Need to think about this one a bit more,
    and whether to retry the async path or look for a separate solution.
  - Real time user presence is now considered. Not considered for sorting
    by last visit time yet.

  Dan Balasescu · 2025-03-11 19:13:11 +09:00
  1f4cfa74dc
• Fix compile failure
  Bartłomiej Dach · 2025-03-11 10:52:03 +01:00
  61e1234e0a
• Disable user customisation of spectator list font / colour

  It's all a bit weird so let's just disable it for now. For instance,
  this is exposed as "text" font / colour but only affects the header.
  Also, no other headers are cusotmisable in similar components.

  Dean Herbert · 2025-03-10 15:19:34 +09:00
  3cb32c38ad
• Merge branch 'master' into user-tags-visual
  Dean Herbert · 2025-03-08 22:07:47 +09:00
  5359455c23
• Fix typo
  Dan Balasescu · 2025-03-08 00:32:56 +09:00
  e69ad86799
• Add failing test
  Dan Balasescu · 2025-03-08 00:09:20 +09:00
  d220c19885
• Add visual test coverage
  Bartłomiej Dach · 2025-03-07 08:51:55 +01:00
  33dccfcec8
• Merge pull request #32245 from smoogipoo/fix-intermittent-test

  Fix intermittent playlists results screen tests

  Bartłomiej Dach · 2025-03-06 14:13:40 +01:00
  30fb2c3f2b
• Merge pull request #32220 from peppy/song-select-flows

  Add ability to start gameplay from carousel v2

  Bartłomiej Dach · 2025-03-06 10:47:55 +01:00
  62e0ad7be8
• Add a slew of tests
  Dan Balasescu · 2025-03-06 16:09:49 +09:00
  ba3d6ddc43
• Fix intermittent playlists results screen tests
  Dan Balasescu · 2025-03-06 12:55:59 +09:00
  50c4f90983
• Add forgotten partials
  Dan Balasescu · 2025-03-05 23:25:22 +09:00
  26daf085d7
• Reset mods when exiting to lounge

  To be hoenst, this is all quite abusive but I'm not sure how to do it in
  any better way. I especially dislike the fact that the screen's
  bindables are disabled yet the screen itself is allowed to set their
  value because they're `LeasedBindable`s.
  
  But I feel better doing this in a central location like this
  `ScreenStack` than in the rooms... Otherwise this specific behaviour
  would have to be replicated in the multiplayer screen when it goes
  through the same refactoring.

  Dan Balasescu · 2025-03-05 21:45:51 +09:00
  f887846311
• Try to fix test
  Bartłomiej Dach · 2025-03-05 12:32:58 +01:00
  7975c301a8
• Add another failing test
  Bartłomiej Dach · 2025-03-05 09:39:52 +01:00
  097dd70139