Bartłomiej Dach
6dc0f6af50
Disable setting apply button for duration of operation
2020-12-28 22:48:03 +01:00
Bartłomiej Dach
af66e45311
Disable create room button after triggering join
2020-12-28 22:48:03 +01:00
Bartłomiej Dach
47ab7c9fd6
Disable ready button after host click
2020-12-28 22:48:03 +01:00
Bartłomiej Dach
9e6994166c
Add helper to track ongoing operations in UI
2020-12-28 22:48:03 +01:00
Dean Herbert
9155671557
Merge pull request #11341 from peppy/fix-leaderboard-user-handling
...
Fix incorrect null handling in GameplayLeaderboard
2020-12-28 22:44:55 +09:00
Dean Herbert
2e88036f39
Merge pull request #11342 from bdach/fix-beatmap-not-reverting
...
Fix user changes in multi song select not reverting on exit without confirmation
2020-12-28 21:56:07 +09:00
Bartłomiej Dach
a376a23ed7
Merge branch 'master' into fix-leaderboard-user-handling
2020-12-28 13:43:53 +01:00
Bartłomiej Dach
a9822800fc
Add more null hinting in GameplayLeaderboard
2020-12-28 13:00:05 +01:00
Dean Herbert
92d74a9343
Fix potential nullref in test scene
2020-12-28 20:48:14 +09:00
Dean Herbert
1ea42d1e4d
Merge pull request #11338 from peppy/fix-user-lookup-failure-crashes
...
Allow null users to still be displayed in the participant list
2020-12-28 20:44:36 +09:00
Bartłomiej Dach
f16b516e58
Revert user changes if no selection was made
2020-12-28 12:35:17 +01:00
Bartłomiej Dach
fb21b7c016
Add failing test cases
2020-12-28 12:35:16 +01:00
Dean Herbert
6254907ef9
Move multiplayer leaderboard test to correct namespace
2020-12-28 20:31:08 +09:00
Dean Herbert
8f0413472c
Add test coverage of null users in scoreboard
2020-12-28 20:30:08 +09:00
Dean Herbert
447a55ce11
Fix incorrect null handling in GameplayLeaderboard
2020-12-28 20:16:53 +09:00
Bartłomiej Dach
20ae84a466
Merge branch 'master' into fix-user-lookup-failure-crashes
2020-12-28 12:15:06 +01:00
Dean Herbert
545dcac4ec
Add null hinting on UserLookupCache query method
2020-12-28 20:13:24 +09:00
Dean Herbert
5ca9a6a980
Add xmldoc on UserLookupCache's lookup method
2020-12-28 20:05:48 +09:00
Bartłomiej Dach
cf29d0c5ef
Merge pull request #11339 from peppy/update-fastlane
2020-12-28 11:06:55 +01:00
Bartłomiej Dach
d5b02e6f27
Merge branch 'master' into update-fastlane
2020-12-28 10:32:43 +01:00
Bartłomiej Dach
e33dd04282
Merge pull request #11340 from peppy/update-framework
...
Update framework
2020-12-28 10:09:23 +01:00
Dean Herbert
2e3537e966
Update framework
2020-12-28 16:52:54 +09:00
Dean Herbert
bdbc210f6d
Update fastlane and dependencies
2020-12-28 16:51:45 +09:00
Dean Herbert
046a76cb1d
Allow null users to still be displayed in the participant list
...
The fix here is correcting the access of `user.Country`. The deicision
to have null users display is because this is the best we can do (if
osu-web could not resolve the user). We still want the users in the
lobby to be aware of this user's presence, rather than hiding them from
view.
osu-stable does a similar thing, showing these users as `[Loading]`. I
decided to go with blank names instead because having *any* text there
causes confusion. We can iterate on this in future design updates.
2020-12-28 15:03:44 +09:00
Dean Herbert
4d61c143db
Fix lookup cache throwing a null reference if no matches were successful
2020-12-28 15:03:44 +09:00
Dean Herbert
69fab7de77
Merge pull request #11307 from bdach/fix-account-creation-overlay-after-logout
...
Fix account creation overlay not showing up the first time after a log-out
2020-12-28 11:52:48 +09:00
Dean Herbert
092b22708a
Merge pull request #11314 from bdach/changelog-refactor
...
Refactor changelog code after migrating away from production web instance
2020-12-28 11:39:48 +09:00
Dean Herbert
1b7c72f03b
Merge branch 'master' into changelog-refactor
2020-12-28 11:00:14 +09:00
Bartłomiej Dach
70a2ab824a
Merge pull request #11320 from peppy/fix-quit-user-showing-in-leaderboard
2020-12-27 13:35:28 +01:00
Bartłomiej Dach
2ff49f4758
Merge branch 'master' into fix-quit-user-showing-in-leaderboard
2020-12-27 13:02:40 +01:00
Bartłomiej Dach
f75dccc9e4
Explicitly use discard in value changed callback
2020-12-27 13:00:27 +01:00
Bartłomiej Dach
6b6b1514e2
Rename method to be less misleading
...
As it doesn't only change colour, but also width.
2020-12-27 12:58:37 +01:00
Dean Herbert
7dd572fe9e
Merge pull request #11323 from bdach/fix-gameplay-leaderboard-clickable-avatars
...
Fix gameplay leaderboard avatars being clickable
2020-12-27 20:40:47 +09:00
Dean Herbert
3b5260fd67
Merge branch 'master' into fix-gameplay-leaderboard-clickable-avatars
2020-12-27 19:00:38 +09:00
Dean Herbert
1b34f2115f
Remove dignostics using
2020-12-27 16:57:23 +09:00
Dean Herbert
d14a8d24b5
Remove assert for now
2020-12-27 16:42:20 +09:00
Dean Herbert
fa0576f47f
Move quit colour change implementation to updateColour for better coverage
2020-12-27 13:40:02 +09:00
Bartłomiej Dach
15948de2f0
Fix gameplay leaderboard avatars being clickable
2020-12-26 14:35:14 +01:00
Bartłomiej Dach
8ec7970b6a
Move load-complete fade specification inside
2020-12-26 14:35:14 +01:00
Bartłomiej Dach
e8f96b2401
Bring back DrawableAvatar as a simple sprite
2020-12-26 14:35:14 +01:00
Bartłomiej Dach
0b42b4b955
Rename {Drawable -> Clickable}Avatar
2020-12-26 14:35:11 +01:00
Bartłomiej Dach
6849eabf2c
Merge pull request #11319 from Neuheit/patch/11310
2020-12-26 13:57:59 +01:00
Bartłomiej Dach
a1af749b4b
Merge branch 'master' into patch/11310
2020-12-26 13:19:13 +01:00
Bartłomiej Dach
3e06f592a1
Merge pull request #11318 from peppy/fix-ready-button-crash
2020-12-26 13:18:40 +01:00
Bartłomiej Dach
b059b5d616
Merge branch 'master' into fix-ready-button-crash
2020-12-26 12:41:47 +01:00
Dean Herbert
36dfff64c8
Merge pull request #11316 from peppy/multiplayer-client-threading-fixes
...
Fix join room failures on large lobbies
2020-12-26 20:38:47 +09:00
Dean Herbert
b9d725ab49
Don't copy spotlight category
2020-12-26 20:13:28 +09:00
Bartłomiej Dach
04d54c40db
Allow all StatefulMultiplayerClient schedules to run inline
...
Fixes test failures due to not allowing to do so, therefore inverting
execution order in some cases - for example, calling
JoinRoom(room);
LeaveRoom();
on the update thread would invert execution order due to the first being
unscheduled but the second being scheduled.
2020-12-26 12:04:10 +01:00
Bartłomiej Dach
dae27fefe4
Run user list copy inline if possible
...
`getRoomUsers()` was not safe to call from the update thread, as
evidenced by the test failures. This was due to the fact that the added
reset event could never actually be set from within the method, as the
wait was blocking the scheduled set from ever proceeding.
Resolve by allowing the scheduled copy & set to run inline if on the
update thread already.
2020-12-26 12:03:03 +01:00
Dean Herbert
966a2151e3
Ensure the previous leaderboard is removed
2020-12-26 17:55:24 +09:00
