22 Commits

• Move osu!catch movement diffcalc to an evaluator (#32655)

  * Move osu!catch movement state into `CatchDifficultyHitObject`
  
  In order to port `Movement` to an evaluator, the state has to be either
  moved elsewhere or calculated inside the evaluator. The latter requires
  backtracking for every hit object, which in the worst case is continued
  until the beginning of the map is reached. Limiting backtracking can
  lead to difficulty value changes.
  
  Thus, the first option was chosen for its simplicity.
  
  * Move osu!catch movement difficulty calculation to an evaluator
  
  Makes the code more in line with the other game modes.
  
  * Add documentation for `CatchDifficultyHitObject` fields
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  wulpine · 2025-04-10 15:47:11 +00:00
  7a9d31adb6
• Fix osu!catch SR buzz slider detection (#32412)

  * Use `normalized_hitobject_radius` during osu!catch buzz slider detection
  
  Currently the algorithm considers some buzz sliders as standstills when
  in reality they require movement. This happens because `HalfCatcherWidth`
  isn't normalized while `exactDistanceMoved` is, leading to an inaccurate
  comparison.
  
  `normalized_hitobject_radius` is the normalized value of `HalfCatcherWidth`
  and replacing one with the other fixes the problem.
  
  * Rename `normalized_hitobject_radius` to `normalized_half_catcher_width`
  
  The current name is confusing because hit objects have no radius in the
  context of osu!catch difficulty calculation. The new name conveys the
  actual purpose of the value.
  
  * Only set `normalized_half_catcher_width` in `CatchDifficultyHitObject`
  
  Prevents potential bugs if the value were to be changed in one of the
  classes but not in both.
  
  * Use `CatchDifficultyHitObject.NORMALIZED_HALF_CATCHER_WIDTH` directly
  
  Requested during code review.
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  wulpine · 2025-03-24 20:04:40 +03:00
  0c3ee1938e
• Remove #nullable disable from Catch.Difficulty
  ekrctb · 2023-01-15 17:29:32 +09:00
  3ab3f556ae
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Rename Position -> Index
  Dan Balasescu · 2022-06-09 18:49:11 +09:00
  6d2a2ba7d6
• Pass object position to the object
  apollo-dw · 2022-05-26 19:26:14 +01:00
  66a6467403
• Use object list size for object position
  apollo-dw · 2022-05-24 16:30:25 +01:00
  30b9e0e7ab
• Store hitobject history in the hitobject
  apollo-dw · 2022-05-22 16:26:22 +01:00
  26985ca8af
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Refactor catch Movement skill to not require explicit clockrate usage

  In catch, rate adjustment mods do not only affect the timings of hitobjects, but also the speed of the player's catcher.
  
  This catcher speed change has an impact on difficulty which is currently accounted for by using the clockrate directly in calculations.
  
  Semantically this is a bad idea because clockrate adjustments are supposed to be fully accounted for in DifficultyHitObjects, but passing clockrate here for the purpose of being used as catcher speed doesn't make much sense, especially since it is copied in every DifficultyHitObject despite being the same value.
  
  It makes more sense to account for this catch specific impact by handling rate adjustment mods in a catch specific way, or more specifically in a Movement skill specific way.

  Samuel Cattini-Schultz · 2021-02-21 18:24:30 +11:00
  323e4ac26b
• Replace CatchHitObject.X usage to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:14 +09:00
  96f3e0dad8
• Move members to PalpableCatchHitObject
  ekrctb · 2020-11-24 19:57:37 +09:00
  ab7251d742
• Standardize osu!catch coordinate system

  There were two coordinate systems used:
  - 0..512 (used in osu!stable)
  - 0..1 (relative coordinate)
  
  This commit replaces the usage of
  the relative coordinate system to
  the coordinate system of 0..512.

  ekrctb · 2020-07-02 00:21:45 +09:00
  3278a1d7d8
• Fix post-merge errors
  smoogipoo · 2020-04-08 12:19:09 +09:00
  c5aae9b757
• General fixes
  smoogipoo · 2019-04-02 07:28:04 +09:00
  21e62c37d8
• Change edge dashes to scale linearly once again
  smoogipoo · 2019-04-01 10:58:26 +09:00
  b2396b82a5
• Adjust edge bonuses to consider clock rate
  smoogipoo · 2019-03-23 16:01:14 +09:00
  be5ffdbf22
• Implement sorcerer's diffcalc changes
  smoogipoo · 2019-03-06 14:36:30 +09:00
  b51a457e5a
• Fix position not being set for the first hitobject
  smoogipoo · 2019-02-20 14:14:45 +09:00
  d25d10d8fc
• Update with PopulateAttributes() removal
  smoogipoo · 2019-02-19 17:42:24 +09:00
  2765ffa190
• Rewrite catch diffcalc for readability + attempt to fix
  smoogipoo · 2019-02-18 14:50:47 +09:00
  f6b13ca79d
• Implement new difficulty calculator for Rulesets.Catch
  smoogipoo · 2019-02-18 14:50:47 +09:00
  8eba94e8c9