60 Commits

• More tooling updates & fixes (#37177)

  ## [Adjust CI test reporting to upstream action
  changes](https://github.com/ppy/osu/commit/f736337b1acf311bf48fb8c39cae67c3f172608d)
  
  It's been semi-broken since I bumped it a few weeks ago. Paper trail for
  this is at https://github.com/dorny/test-reporter/issues/750, but to
  TL;DR it: `dorny/test-reporter@>=v2.0.0` migrated from [creating new
  check runs via the GitHub
  API](https://docs.github.com/en/rest/checks/runs) to [job
  summaries](https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands#adding-a-job-summary)
  by default.
  
  The main difference is that compared to check runs, job summaries do not
  *appear to* require extra `GITHUB_TOKEN` permissions, but in exchange
  are limited to the job that called it. This broke visibility of the test
  reports because due to `GITHUB_TOKEN` permissions foibles the test
  reporter was running in a separate workflow.
  
  I see migrating as a plus here, since:
  
  - The visibility of results is comparable-to-better (example available
  for preview at https://github.com/bdach/osu/actions/runs/23892493152)
  - No longer required to have a completely separate workflow for test
  result reporting
  - No longer required to give `checks: write` permissions to the action
  (I'd hope, we'll see, untested on a public repository with PRs involved)
  
  One downside is there'll be no in-code annotations for failing tests
  anymore but that's whatever IMO. Half the time they weren't even very
  helpful, test results pretty much require maintainer interpretation
  anyway.
  
  This needs to be applied to a few other repos but I'm starting here
  because this is the one where the traffic is highest and therefore
  unbreaking the report is of most value (and also the one where I'll see
  if it works with public PRs the fastest).
  
  Side note, I was hoping to remove the artifact upload/download games by
  just attaching the summary inside each individual test job in the
  matrix, but [it looks like
  crap](https://github.com/bdach/osu-framework/actions/runs/23888384309)
  because only the first three summaries are loaded by default, so if
  there are more, you have to click each remaining one to see its output.
  Wow. Awesome.
  
  Also updates the action to `v3.0.0` to resolve node deprecation
  warnings.
  
  ## [Update inspectcode version to resolve deprecation
  warnings](https://github.com/ppy/osu/commit/496cf6890ecb6571e6361731d46f53cceb7cb584)
  
  More node deprecation warning fixes.

  Bartłomiej Dach · 2026-04-03 00:19:46 +09:00
  5b6d215583
• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• No longer download iOS simulator

  https://github.com/actions/runner-images/issues/12862#issuecomment-3209787203

  Dan Balasescu · 2025-08-22 13:29:46 +09:00
  0756c45d70
• Force Xcode 16.4 on CI
  Dan Balasescu · 2025-08-16 15:52:27 +09:00
  1306f56fba
• Use macOS-15 for iOS builds
  Dan Balasescu · 2025-07-22 18:14:09 +09:00
  4daa900a19
• Remove iOS workload rollbacks
  Dan Balasescu · 2025-07-22 17:27:26 +09:00
  d3701f4659
• Fix osu.Game.Tests tests running twice
  Dan Balasescu · 2025-03-22 02:28:06 +09:00
  aacb5d86c8
• Build iOS tests project
  Dan Balasescu · 2025-03-18 16:19:52 +09:00
  2630d9437c
• Fix android build again

  Another month, another freak android build failure.
  
  From what I can tell, this time the build is broken because the second-
  -to-last workaround applied to fix it, namely explicitly specifying
  the version of workloads to install, stopped working, presumably because
  github pushed a new .NET SDK version to runners, and microsoft didn't
  actually put up a set of workload packages whose version matches the
  .NET SDK version 1:1.
  
  Thankfully, the fix to the *last* android build breakage (which caused
  the workload installation to completely and irrecoverably fail), appears
  to be rolling out this week, and *also* fix that same second-last issue,
  so both workarounds of specifying the workload version and pinning the
  image to `windows-2019` appear to no longer be required.
  
  Note that the newest image version, 20250209.1.0, is still not fully
  rolled out yet, thus rather than just fix all builds, this will fix like
  20% of builds until the newest image is fully rolled out. But I guess
  a 20% passing build is better than a 0% passing build, in a sense...?

  Bartłomiej Dach · 2025-02-12 14:18:03 +01:00
  ee6dcbd808
• Roll back windows build image to 2019 on android build job

  Per workaround suggested in
  https://github.com/actions/runner-images/issues/11402#issuecomment-2596473501.
  
  Applying this now as my hopes for a swift resolution without changes on
  our side are slim to none (read thread linked above in full to learn
  why).

  Bartłomiej Dach · 2025-01-23 10:12:30 +01:00
  b4e8a17f03
• Fix android workflow not installing .NET 8 version
  Salman Alshamrani · 2024-11-27 23:46:21 -05:00
  19e396f878
• Make android build on non-maui workflow
  Dan Balasescu · 2024-11-18 17:20:11 +09:00
  02deb39335
• Update GHA
  Dan Balasescu · 2024-11-06 14:02:01 +09:00
  4b9f9b9be5
• Rollback iOS workload to last known working version
  Dan Balasescu · 2024-10-05 23:00:04 +09:00
  232381c9fb
• Fix iOS CI build
  Dan Balasescu · 2024-09-27 16:26:11 +09:00
  cb51e12d13
• Remove macOS/Xcode version pinning in iOS workflow
  Salman Ahmed · 2024-08-08 13:03:09 +03:00
  e12dba24ae
• Disable macOS test runs for now

  We are seeing update frames run as little as [once per
  second](https://github.com/ppy/osu/blob/aa4d16bdb873d7296b899cee7b7491ffdf5cd6ab/osu.Game/Overlays/BeatmapListingOverlay.cs#L141).
  Until we can ascertain why this is happening, let's reduce developer
  stress by not running macOS tests for now.

  Dean Herbert · 2024-07-25 09:05:58 +09:00
  4cc07badbd
• Raise workflow timeout time

  https://github.com/ppy/osu/actions/runs/9985890747/job/27597500883

  Dan Balasescu · 2024-07-18 16:26:40 +09:00
  7bb680a8a4
• Update github actions to resolve most node deprecation warnings

  As is github tradition, workflows started yelling about running on a
  node version that was getting sunset, so here we go again.
  
  Relevant bumps:
  
  - https://github.com/actions/checkout/releases/tag/v4.0.0
  - https://github.com/actions/setup-dotnet/releases/tag/v4.0.0
  - https://github.com/actions/cache/releases/tag/v4.0.0
  - https://github.com/actions/setup-java/releases/tag/v4.0.0
  - https://github.com/peter-evans/create-pull-request/releases/tag/v6.0.0
  - https://github.com/dorny/test-reporter/releases/tag/v1.8.0
  
  Notably, `actions/upload-artifact` is _not_ bumped to v4, although it
  should be to resolve the node deprecation warnings, because it has more
  breaking changes and bumping would break `dorny/test-reporter`
  (see https://github.com/dorny/test-reporter/issues/363).

  Bartłomiej Dach · 2024-02-22 17:18:10 +01:00
  99bbbf810b
• Use Xcode 15.2
  Dan Balasescu · 2024-02-02 21:28:52 +09:00
  ec4f3577c0
• Adjust CI workflows
  Dan Balasescu · 2024-02-02 21:28:51 +09:00
  a217a7f8cf
• Remove manual changes to Xcode versions in CI
  Rowe Wilson Frederisk Holme · 2023-11-23 01:18:55 +08:00
  9fd0641238
• Fix android compile failures due to invalid java version

  See https://github.com/ppy/osu-framework/pull/6057.

  Bartłomiej Dach · 2023-11-22 07:55:41 +09:00
  aa72407065
• Fix iOS build workflow failing

  A new version of `Microsoft.iOS.Sdk` was released on
  2023-05-09T17:28:41.7300000. This version requires Xcode 14.3, which is
  not currently available on `macos-latest` runners (which currently alias
  to `macos-12`).
  
  To fix, migrate to `macos-13`, which is currently in beta, and
  explicitly use Xcode 14.3 (because even on the `macos-13` image, Xcode
  14.3 is not yet the default).

  Bartłomiej Dach · 2023-05-09 21:59:24 +02:00
  745341ca6b
• fixup! revert formatting changes
  Mohammed Keyvanzadeh · 2023-03-27 18:37:01 +03:30
  433f9e5367
• github: update workflows and make tweaks

  - Update the GitHub Actions workflows to their latest versions.
  - Replace the usage of the deprecated `set-output` command with the
  new recommended way to set the output.
  - Format the YAML files.

  Mohammed Keyvanzadeh · 2023-03-27 18:10:32 +03:30
  3d032d0024
• Fix iOS workflow still targeting old Xcode version
  Salman Ahmed · 2023-01-25 02:15:08 +03:00
  4d4dfd9e8b
• Use maui-android
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  d3995693a0
• Cherry-picked android changes from #17462
  Dean Herbert · 2022-12-19 15:46:54 +09:00
  877413524f
• Manually use Xcode 14.1
  Salman Ahmed · 2022-12-17 03:30:25 +03:00
  4dbc1c3cb0
• Pin workflow to macOS 12
  Salman Ahmed · 2022-12-17 03:00:59 +03:00
  d74478ce3b
• Update workflows in line with framework changes
  Salman Ahmed · 2022-12-16 00:22:11 +03:00
  2c78fed5e4
• Attempt to remove console output
  Dean Herbert · 2022-10-07 23:25:20 +09:00
  cff38e532a
• build: harden ci.yml permissions

  Signed-off-by: Alex <aleksandrosansan@gmail.com>

  Alex · 2022-09-25 18:00:28 +02:00
  38f0524e88
• Cancel in progress CI runs when new commits are pushed

  Same as https://github.com/ppy/osu-web/pull/9268.
  
  Should hopefully help with organisation concurrent limits.

  Dean Herbert · 2022-09-12 19:09:46 +09:00
  431e84f992
• Remove iOS build CI workaround
  Salman Ahmed · 2022-07-01 11:21:52 +03:00
  0cfaef3605
• Work around macOS agent regression affecting iOS CI builds
  Salman Ahmed · 2022-06-20 06:54:15 +03:00
  5e594e4de0
• Cache bust on more files
  Dan Balasescu · 2022-06-17 17:55:58 +09:00
  42c97baa97
• Revert Xamarin regression workaround in Android CI build definition

  This commit is a revert of 53e52d2c4b.
  Partially done because the workaround is no longer needed, partially
  because macOS images have begun to fail after a new image rollout with
  bumped NuGet versions.

  Bartłomiej Dach · 2022-06-16 21:03:29 +02:00
  9141a7a907
• Run template tests on CI
  Dan Balasescu · 2022-06-16 13:47:30 +09:00
  88376da2cf
• Remove redundant installation of libavformat in Linux CI runs

  Linux `libavformat` native libraries are now packaged with framework.

  Jai Sharma · 2022-05-23 21:52:29 +01:00
  e990a24723
• Bust CI cache on CodeAnalysis ruleset changes
  Dan Balasescu · 2022-05-19 09:44:11 +09:00
  3bca014b52
• Bust CI cache on more files
  Dan Balasescu · 2022-05-11 18:27:57 +09:00
  a46894b613
• Remove dotnet-format
  Huo Yaoyuan · 2022-05-06 01:28:30 +08:00
  30ffc7b23f
• Only enable EnforceCodeStyleInBuild in CI
  Huo Yaoyuan · 2022-05-06 01:24:19 +08:00
  aafb363a34
• Disable EnforceCodeStyleInBuild in Xamarin CI run
  Huo Yaoyuan · 2022-05-04 14:06:01 +08:00
  a17bbd62b7
• Move Code Quality check to top of checks list
  Dan Balasescu · 2022-04-21 15:34:01 +09:00
  b4c208be63
• Add inspectcode CI cache
  Dan Balasescu · 2022-04-14 14:34:43 +09:00
  46cce94a75
• Upgrade to Resharper 2022.1.0-EAP10
  Dan Balasescu · 2022-04-14 11:52:05 +09:00
  9c28c5b847
• Update CI runs to target net6.0
  Dean Herbert · 2022-02-14 22:35:08 +09:00
  c5019fefb0