3399 Commits

• Add even more logging to beatmap submission process

  Every now and again someone will report having done something horrible
  to their beatmap via lazer submission, always claim having done
  "nothing" while invariably having done *something*, will not provide me
  with a workable reproduction scenario, and even if they attempt to do
  so, I will be unable to reproduce the issue anyway. So this change is
  just desperation mostly. It's logging pretty much all that it is
  possible to log of client-side state.

  Bartłomiej Dach · 2025-05-26 11:33:59 +02:00
  c7404cb81d
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Merge pull request #33232 from bdach/editor-playback-speed-application-safer

  Improve reliability of unapplying speed adjustment on exiting editor

  Dan Balasescu · 2025-05-22 19:19:11 +09:00
  99e342043a
• Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

  Closes https://github.com/ppy/osu/issues/33231.
  
  I'm not sure how to reproduce the instances of this reported to sentry
  with `Drawable{Slider,Spinner}`, but this bug is about to be made worse
  by `DrawableHoldNote` in mania getting its own `JudgementResult` subtype
  in https://github.com/ppy/osu/pull/33194 - for that one to reproduce
  just start gameplay test while editor is seeked to a time instant where
  a hold note is mid-hold.
  
  There's possibly an argument here that `CreateResult()` should live on
  `HitObject` and not `DrawableHitObject`, and I'd even be partial to such
  an argument, but doing that would be a rather hard ruleset API break
  (albeit trivial one to resolve), and also may dredge up past
  conversations about `Judgement` and `JudgementResult` (cf.
  https://github.com/ppy/osu/pull/26563) that I would rather not get into
  again.
  
  Notably this is not source-breaking for rulesets. It may be
  binary-breaking, I haven't tested.

  Bartłomiej Dach · 2025-05-22 10:20:39 +02:00
  70c6ddbe30
• Improve reliability of unapplying speed adjustment on exiting editor

  Probably closes https://github.com/ppy/osu/issues/33230.
  
  I say "probably" because I couldn't reproduce this myself using the
  scenario provided in the issue but looking at the code involved I can
  see why it would happen. Long and short of it is that the speed
  adjustment cleanup code was much too reliant on disposal executing
  quickly, which as we've learned on several occasions before, cannot be
  relied upon.

  Bartłomiej Dach · 2025-05-22 09:28:47 +02:00
  b7c695b47c
• Merge branch 'master' into iss32064
  Nuno Pelágio · 2025-05-19 21:17:23 +01:00
  7893b885c5
• Fix ppy#32064: Fixed Formatting.
  Nuno Pelagio · 2025-05-19 20:00:24 +01:00
  dc86b77f80
• Use better error messaging in case of beatmap ID mismatch

  Should maybe give users a better idea of what's wrong.

  Bartłomiej Dach · 2025-05-07 12:53:40 +02:00
  ad586cb5dd
• Fix #32064: Inconsistent angle display when rotation objects.

  The normalization formula didn't handle the 180° boundary consistently,
  and produced asymmetric results for top vs. bottom rotation points.
  Changes made: replaced the angle normalization with symmetric normalization,
  and forced 180º to be the displayed angle across all rotation points.

  Nuno Pelagio · 2025-05-02 11:58:43 +01:00
  7af17a5d94
• Fix ID3 metadata half-applying on audio file switch

  Should be self-explanatory (feedback loop between `reloadMetadata()`
  changing text box current, and text box current changing calling
  `applyMetadata()`).

  Bartłomiej Dach · 2025-04-28 09:41:38 +02:00
  8ea89b9d52
• Use another property when reading artist as fallback

  I was testing with mp3s ripped via Apple Music and for whatever reason
  the artist was in `JoinedPerformers` rather than `JoinedAlbumArtist`.
  I'm not about to go down and do research on id3 so I'm just going to try
  this and see if anyone complains.

  Bartłomiej Dach · 2025-04-28 09:40:34 +02:00
  16b658b322
• Fix missing disposal of TagLib.File in ChangeAudioTrack
  Dean Herbert · 2025-04-28 15:52:55 +09:00
  aab2df1704
• Simplify taglib interactions further
  Dean Herbert · 2025-04-28 15:52:31 +09:00
  40faa3fc99
• Add manual MIME type resolution for TagLib file creation
  Stedoss · 2025-04-28 13:38:38 +09:00
  c2efda20d7
• Merge pull request #32946 from bdach/new-combo-collapsed
  Dean Herbert · 2025-04-25 17:40:08 +09:00
  3cbdf2b890
• Merge pull request #32845 from nekodex/bss-audio-feedback

  Add audio feedback to the BSS process

  Dean Herbert · 2025-04-25 17:25:12 +09:00
  85a5033454
• Remove unnecessary try-finally usage
  Dean Herbert · 2025-04-25 17:22:25 +09:00
  c6a11a56a3
• Attempt to improve appearance of new combo toggle / combo colour control when contracted

  Follow-up to
  https://discord.com/channels/188630481301012481/188630652340404224/1364909125812617258.
  
  Not sure if better, but an attempt was made?

  Bartłomiej Dach · 2025-04-25 08:52:59 +02:00
  bc03a2a930
• Rework logic to use a looping sample for progress instead
  Jamie Taylor · 2025-04-24 20:38:15 +09:00
  9c56ee3e19
• Fix deselecting single item from a multiple selection not updating ternary states correctly

  I'm not sure why this condition was written this obtusely, but
  importantly it was also wrong. It fires when the selection contains
  multiple items and only some are removed from it, like when
  ctrl-click-unselecting an item from a multiple selection.

  Bartłomiej Dach · 2025-04-24 09:25:36 +02:00
  5a3ff11710
• Reset sample ternary states on deselection

  Closes https://github.com/ppy/osu/issues/32928.
  
  Appears to match stable:
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4137-L4143
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L1615-L1618
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4323

  Bartłomiej Dach · 2025-04-24 09:25:27 +02:00
  5c04f427a5
• Change samples to be declared nullable
  Jamie Taylor · 2025-04-24 11:31:02 +09:00
  15a4ffe344
• Move playback logic to Update()
  Jamie Taylor · 2025-04-24 10:48:32 +09:00
  f6f098a0dc
• Fix renamed translation keys
  Jamie Taylor · 2025-04-23 15:30:41 +09:00
  3b80c0af0a
• Merge branch 'master' into bss-audio-feedback
  Jamie Taylor · 2025-04-23 14:31:51 +09:00
  4e7ed0e819
• Change "Delete Difficulty" editor menu item type to destructive
  schiavoanto · 2025-04-19 09:00:53 +02:00
  d1f7afc8ed
• More explicitly define arithmatic precedence
  Jamie Taylor · 2025-04-18 20:42:49 +09:00
  e5940a41b9
• Add audio feedback to BSS process
  Jamie Taylor · 2025-04-18 20:30:38 +09:00
  5208d8a0b2
• Fix osu!mania beatmap objects getting corrupted when updating beatmap background

  Closes https://github.com/ppy/osu/issues/32825.
  
  Tested manually to fix the issue. Setting up test coverage for this is
  going to likely take over an hour compared to the 30 second fix, so
  please advise if required. I couldn't find any existing tests which
  perform this flow.

  Dean Herbert · 2025-04-17 16:11:03 +09:00
  b71281bec8
• Merge pull request #32729 from peppy/fix-mouse-down-leakage

  Fix slider placement not working correctly with UI button clicks

  Bartłomiej Dach · 2025-04-09 11:53:26 +02:00
  110b124cb6
• Fix editor click-through issues on bottom bar too
  Bartłomiej Dach · 2025-04-09 10:28:06 +02:00
  7ab428f18c
• Block all mouse events at BeatDivisorControl and revert animated button change
  Dean Herbert · 2025-04-09 14:56:30 +09:00
  27edee477d
• Merge pull request #32730 from peppy/fix-keyboard-steps

  Fix editor setup screen sliders not having correct keyboard steps

  Bartłomiej Dach · 2025-04-08 08:32:37 +02:00
  99ee5767cb
• Merge pull request #32665 from peppy/fix-editor-metadata-save-without-commit

  Fix saving via ctrl+s while metadata textbox is focused not saving changes

  Bartłomiej Dach · 2025-04-08 08:21:03 +02:00
  5f168b9b9f
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Fix mouse down actions being leaked through buttons
  Dean Herbert · 2025-04-08 14:28:48 +09:00
  e42301058f
• Make dependency on editor optional
  Bartłomiej Dach · 2025-04-07 15:00:47 +02:00
  5db4f80e84
• Fix code quality harder
  Bartłomiej Dach · 2025-04-07 14:59:51 +02:00
  f968f8ed68
• Fix nullability inspection
  Bartłomiej Dach · 2025-04-07 13:44:42 +02:00
  d34a1fb448
• Avoid saving a state when clearly not dirty
  Dean Herbert · 2025-04-07 19:37:26 +09:00
  3738d75202
• Ensure a state is saved when committing metadata to trigger pending changes flow
  Dean Herbert · 2025-04-03 18:49:18 +09:00
  f19fa73fb2
• Only show required number of decimal places (and fix final alpha levels)
  Dean Herbert · 2025-04-03 18:17:26 +09:00
  448573449c
• Change editor to save metadata changes without explicit textbox commit

  Closes https://github.com/ppy/osu/issues/32365.

  Dean Herbert · 2025-04-03 15:31:24 +09:00
  ce288023fe
• Fix metronome BPM text not matching expectations due to custom rounding implementation
  Dean Herbert · 2025-04-03 15:13:44 +09:00
  11368b628b
• Remove non-visible "beat snap" text in editor
  Dean Herbert · 2025-03-20 15:46:09 +09:00
  80ff974594
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Merge pull request #32346 from bdach/user-tags-on-results

  Add ability to vote for beatmap user tags after completing a play

  Dean Herbert · 2025-03-15 14:36:27 +09:00
  d704adf5fa
• Show user tag control only following local user gameplay
  Bartłomiej Dach · 2025-03-12 12:19:33 +01:00
  e70ad14647
• Fix context menu not working when selection hasn't changed
  Dean Herbert · 2025-03-12 18:25:56 +09:00
  5b911ad8d0
• Fix quick delete still propagating right click mouse input upwards
  Dean Herbert · 2025-03-12 16:52:36 +09:00
  db7d1f32d7