826 Commits

• Change implementation to match other implementations

  The previous version was confusing to read.

  Dean Herbert · 2025-05-13 15:10:59 +09:00
  7918685c4e
• Fix rate adjust / time ramp mods not showing "Adjust pitch" in tooltip
  Salman Alshamrani · 2025-05-12 15:14:26 +03:00
  9c77a3e74f
• Move UserAdjustedSettingsCount local to ModDifficultyAdjust in absence of other usages
  Dean Herbert · 2025-04-30 16:04:26 +09:00
  a397737476
• Don't bother with localised implementation of AdjustedSettingsCount

  I was avoiding using reflection to save on overheads, but it's probably
  not worth it.

  Dean Herbert · 2025-04-30 12:58:40 +09:00
  babccca2bb
• Add xmldoc note explaining new flag is instantaneous state
  Dean Herbert · 2025-04-30 12:49:39 +09:00
  14d0565194
• Show marker when settings are adjusted
  Dean Herbert · 2025-04-28 18:14:14 +09:00
  1e8d9b3482
• Show singular difficulty adjust modifications inline in mod icons
  Dean Herbert · 2025-04-28 16:58:16 +09:00
  c16514274d
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717
• Fix rate adjust no longer showing the rate if custom

  "Accidentally" removed in 6e635f124a
  apparently.

  Bartłomiej Dach · 2025-04-18 14:03:32 +02:00
  5791375b38
• Improve IMod documentation
  Dan Balasescu · 2025-04-17 18:32:35 +09:00
  92267c8bb3
• Use IMod documentation where present
  Dan Balasescu · 2025-04-17 18:32:26 +09:00
  95cf4887e1
• Apply changes from reviews
  Dan Balasescu · 2025-04-17 02:19:31 +09:00
  64aafa4e4c
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Only apply freestyle validation to required mods
  Dan Balasescu · 2025-04-14 19:34:21 +09:00
  b4c7d7f498
• Allow classic mod in freestyle
  Dan Balasescu · 2025-04-10 13:05:17 +09:00
  c6e368d3ea
• Allow more mods in freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  3a56f59749
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

  - Closes https://github.com/ppy/osu/issues/31888
  - Supersedes / closes https://github.com/ppy/osu/pull/32060

  Bartłomiej Dach · 2025-02-25 07:40:55 +01:00
  1f562ab47d
• Update for suggestions
  Huo Yaoyuan · 2024-12-03 00:03:59 +08:00
  7ece8ec1dc
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Make empty hitwindows readonly static and slightly improve comparison performance
  Dean Herbert · 2024-11-25 19:17:32 +09:00
  605fe71f46
• Fixes cursor rotating along with playfield when using Barrel Roll in standard
  jhk2601 · 2024-10-17 14:38:13 -04:00
  7416106321
• Fix similar Bindable-related crashes
  Dan Balasescu · 2024-09-25 20:59:35 +09:00
  fd4891cf31
• Fix replay analysis overlay not rotating with Barrel Roll enabled

  Closes https://github.com/ppy/osu/issues/29839.

  Bartłomiej Dach · 2024-09-11 15:54:30 +02:00
  4a39873e2a
• Fix Flashlight not appearing on top of bubbles from Bubbles mod

  Inadvertently regressed in 44d0dc6113.

  Bartłomiej Dach · 2024-09-11 15:54:07 +02:00
  b78ef81bf1
• Fix incorrect DifficultyBindable logic
  Bartłomiej Dach · 2024-07-30 08:39:20 +02:00
  6813f5ee0a
• Annotate ControlPoint and Mod for AOT trimming support
  Dan Balasescu · 2024-06-17 16:19:33 +09:00
  41446a08b6
• Fix cinema mod not hiding playfield skin layer
  Dean Herbert · 2024-05-27 14:52:28 +09:00
  11c3d11db9
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Fix DifficultyBindable bound desync between maxValue and CurrentNumber.MaxValue
  Bartłomiej Dach · 2024-04-23 18:58:40 +02:00
  cbbf2dd158
• Fix 1px flashlight gaps when gameplay scaling mode is active

  Closes https://github.com/ppy/osu/issues/27522.
  
  Concerns mostly taiko and catch.
  
  Not much of a proper fix rather than a workaround but it is what it is.
  I tried a few other things, including setting `MaskingSmoothness = 0` on
  the scaling container itself, to no avail.

  Bartłomiej Dach · 2024-03-08 11:07:30 +01:00
  44d0dc6113
• Merge branch 'master' into flashlight-playfield-based-size-
  Bartłomiej Dach · 2024-02-26 10:55:06 +01:00
  353485a707
• Assert proportional scaling rather than assume average

  Because if scaling is ever actually non-proportional then this should be
  somewhat loud.
  
  Also use the absolute value to prevent funny things happening if/when
  someone does negative scale.

  Bartłomiej Dach · 2024-02-26 10:53:04 +01:00
  115d82664b
• Merge pull request #27144 from cdwcgt/allow-muted-ranked

  Allow pp for muted mod for any combination of settings

  Dan Balasescu · 2024-02-25 00:31:37 +09:00
  006416057b
• Merge pull request #27068 from smoogipoo/mania-hd-fi-progression

  Add progressive coverage for mania's Hidden and FadeIn mods

  Dean Herbert · 2024-02-16 01:00:53 +08:00
  c1d9f53ab4
• Add inline documentation as to why classic mod is not ranked

  See https://github.com/ppy/osu/pull/27149#issuecomment-1939509941.

  Dean Herbert · 2024-02-15 13:22:54 +08:00
  9e9297bfb3
• allow ModMuted to ranked when setting adjusted
  cdwcgt · 2024-02-12 21:18:31 +09:00
  1944a12634
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e
• Add progressive cover to mania HD and FI mods
  Dan Balasescu · 2024-02-06 23:47:20 +09:00
  5bc7befbd4
• Allow pp for No Scope

  Deemed as not affecting difficulty or pp in
  https://github.com/ppy/osu/pull/26935#issuecomment-1925644008,
  so can be treated pretty much as nomod.

  Bartłomiej Dach · 2024-02-06 13:04:19 +01:00
  8df593a8e6
• Allow pp for Double/Half Time's "adjust pitch" setting
  Bartłomiej Dach · 2024-02-01 22:33:49 +01:00
  ea76f7a5d8
• Allow pp for Accuracy Challenge

  Addresses https://github.com/ppy/osu/discussions/26919.

  Bartłomiej Dach · 2024-02-01 22:30:26 +01:00
  96f66aaa2e
• Allow pp for Sudden Death and Perfect regardless of "restart on fail" setting

  Closes https://github.com/ppy/osu/issues/26844.

  Bartłomiej Dach · 2024-02-01 22:28:49 +01:00
  c114fd8f89
• Annotate mods that give pp
  Bartłomiej Dach · 2024-01-31 14:59:35 +01:00
  f89923aeae
• Reintroduce IMod.Ranked

  What goes around, comes around.

  Bartłomiej Dach · 2024-01-31 14:48:35 +01:00
  e71c95f1fe
• Fix Cinema mod being compatible with mods that can force failure

  Addresses
  https://github.com/ppy/osu/pull/26080#issuecomment-1868833214.

  Bartłomiej Dach · 2024-01-08 22:34:41 +01:00
  aa83b84bb2
• Make ScoreProcessor.Rank read-only
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  705f25e4b9
• Expose Mod.UsesDefaultConfiguration
  Dan Balasescu · 2023-12-29 17:16:16 +09:00
  a6313c4ee8