12 Commits

• Unify order of displaying map attributes on mod overlay with SongSelectV2
  Bartłomiej Dach · 2025-05-29 11:28:11 +02:00
  b20139e9dd
• Update AdjustedAttributesTooltip.cs

  Mods don't necessarily have to change speed, to change beatmap attributes. Also, speed mods don't affect beatmap attributes in mania, making the text misleading.

  Marvefect · 2025-04-30 13:01:23 +03:00
  3f17d7227a
• Add beatmap title wedge
  Salman Alshamrani · 2025-04-18 06:41:51 -04:00
  04fa95d924
• Fix AdjustedAttributesTooltip being broken by design

  Fixes issue described in the following comment:
  https://github.com/ppy/osu/pull/25759#issuecomment-1855954637
  
  That is just not how the tooltip system is supposed to be used.
  
  To name the individual sins:
  
  - Caching and returning a tooltip instance like the classes that used
    tooltips is incorrect. The lifetime of tooltip instances is managed by
    the tooltip container. `GetCustomTooltip()` is called by it
    exclusively. It should return a fresh instance every time.
  
  - Not putting actual data in `IHasCustomTooltip.TooltipContent` is
    wrong.
  
  - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly*
    wrong.
  
  I'm not even sure which particular combination of the above
  transgressions caused the issue as it presented itself, but at this time
  I frankly do not care.

  Bartłomiej Dach · 2023-12-14 16:15:56 +01:00
  9e5b6b97ff
• Update AdjustedAttributesTooltip.cs
  Givikap120 · 2023-12-14 14:38:01 +02:00
  23c427cd3e
• change the order of attributes

  + simplifying the bug fix

  Givikap120 · 2023-12-14 14:31:19 +02:00
  c2373bb37b
• Refactor everything for sanity
  Dean Herbert · 2023-12-13 17:33:39 +09:00
  5062c53e36
• Fix various code quality and visual issues with AdjustedAttributesTooltip
  Dean Herbert · 2023-12-13 16:57:31 +09:00
  9433180ffe
• Update AdjustedAttributesTooltip.cs
  Givikap120 · 2023-12-10 00:51:50 +02:00
  f5b93121f1
• fixed test errors
  Givikap120 · 2023-12-10 00:40:05 +02:00
  1d0c37e138
• slight format changes
  Givikap120 · 2023-11-24 01:07:37 +02:00
  93e3156868
• Made custom tooltip
  Givikap120 · 2023-11-23 23:30:18 +02:00
  c2a44cf118