3455 Commits

• Fix profile score display logic not matching website

  Reported via e-mails.
  
  The web-side change that wasn't ported here is
  https://github.com/ppy/osu-web/pull/11151. I wanted to port it at the
  time but then ran into issues because this logic should *ideally* also
  be applied to the beatmap set overlay leaderboards, but those are
  hard-glued to `ScoreInfo`, cannot be easily weaned off it to use
  `SoloScoreInfo` instead, and I did not want to make `ScoreInfo` even
  more of a mess than it already is.
  
  This time I'm just ignoring it and adding a TODO instead because I have
  no confidence I will get review eyes on any refactor of the beatmap set
  overlay. All I'll say that such refactors would have potentially
  beneficial effects on results screens too which also (ab)use
  `ScoreInfo`.

  Bartłomiej Dach · 2025-05-26 13:11:41 +02:00
  90bc8865c9
• Use null coalesce wherever possible

  Rider EAP being noisy about this one now.

  Dean Herbert · 2025-05-26 17:15:35 +09:00
  5450298468
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Add matching comment in SpectatorClient for clarity
  Dean Herbert · 2025-05-17 23:33:46 +09:00
  7c44883042
• Also perform time-based frame de-duplication at frame bundle level

  See https://github.com/ppy/osu/pull/33148#discussion_r2092467082

  Bartłomiej Dach · 2025-05-16 09:39:29 +02:00
  baf069ccf7
• Fetch more scores for supporter scope leaderboards

  Which are: global and team leaderboards with mods, and friends and
  country leaderboards.
  
  Only attempting this because of
  https://github.com/ppy/osu/issues/31056#issuecomment-2719787189. Not
  sure if this addresses the concern 🤷

  Bartłomiej Dach · 2025-05-12 09:54:56 +02:00
  934c2440cc
• Merge branch 'master' into open-playlist-link
  Bartłomiej Dach · 2025-05-07 09:31:58 +02:00
  810346ab34
• Cache local user supporter status between game executions

  Fixes startup sounds from potentially being fetched from the wrong
  source if API connection establishment takes longer than the intro
  screen takes to load.
  
  Closes https://github.com/ppy/osu/issues/22492.

  Dean Herbert · 2025-05-07 14:02:09 +09:00
  84f44eb3ad
• Merge pull request #32947 from bdach/use-actual-score-positions-in-gameplay-leaderboard

  Use actual score positions in gameplay leaderboard

  Dean Herbert · 2025-04-30 17:20:12 +09:00
  1b5553a2d8
• Add support for opening multiplayer / playlist room links directly

  As in, `https://osu.ppy.sh/multiplayer/rooms/{id}` links, clicked from
  the chat overlay, now directly open in the client.
  
  Additionally, `osu://room/{id}` can be used in the same way to open a
  room from a third-party application or a browser.

  Bartłomiej Dach · 2025-04-28 11:40:00 +02:00
  09602097bd
• Add raw prefixes in link handling code
  Bartłomiej Dach · 2025-04-28 10:35:09 +02:00
  a0d32c6605
• Use actual score positions in gameplay leaderboard

  Intends to close https://github.com/ppy/osu/issues/32859.
  
  The difference between this and https://github.com/ppy/osu/pull/32942 is
  that this PR takes the approach of completely moving the score sorting
  behaviour to `IGameplayLeaderboardProvider` implementations.
  
  This is going to be helpful for further work - to be precise, I am
  looking to add a leaderboard position indicator in the bottom right of
  multiplayer player to match stable, and having the position in the
  provider will make the implementation of that *much* easier.

  Bartłomiej Dach · 2025-04-25 12:40:55 +02:00
  06dc4235f0
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717
• Merge pull request #32913 from peppy/leaderboard-fetch-refactor

  Remove `LeaderboardManager` return value and simplify flow further

  Bartłomiej Dach · 2025-04-23 09:27:12 +02:00
  7636573e21
• Always refresh leaderboard for now
  Dean Herbert · 2025-04-23 14:51:00 +09:00
  f945abb72e
• Merge branch 'master' into feat/block-users
  Dean Herbert · 2025-04-23 13:55:18 +09:00
  c5748a0eae
• Simplify even further by removing all of the superfluous task completion sources
  Bartłomiej Dach · 2025-04-22 13:28:42 +02:00
  4979dd86af
• Remove LeaderboardManager return value and simplify flow further

  The rationale for this change is that the return value was mostly
  useless, and at worst, misleading.
  
  When using `LeaderboardManager`, it's assumed that a consumer will bind
  to the global `Scores` list to ensure they receive updates for things
  like local score changes via the internal realm subscription. If one
  decides to instead use the return value of the task, it will be a static
  snapshot that potentially becomes stale in the future.
  
  I fell into this trap when refactoring the new leaderboard component
  (while attempting to assert correctness that the values we are
  displaying were in fact from the fetch operation we requested).
  
  In the interest of keeping things simple, removing the return value
  seems to be the best path forward.

  Dean Herbert · 2025-04-22 19:31:02 +09:00
  f7d1809cb7
• Merge branch 'master' into leaderboards/gameplay-provider
  Bartłomiej Dach · 2025-04-21 09:03:24 +02:00
  6b0567e882
• Fix gameplay leaderboard showing scores from wrong beatmaps

  Kind of a big oversight this. In wanting to get the leaderboard
  refactors to move forward I sort of didn't realise the fact that all of
  the error handling related to online status and such in
  `BeatmapLeaderboard` kind of... can't stay there...
  
  It's also an all-or-nothing business too - moving this stuff can't
  really be done only in part.
  
  Not sure whether tests are warranted if it's more or less moving logic
  across?

  Bartłomiej Dach · 2025-04-18 20:37:02 +02:00
  c29f59fcdb
• Add/improve xmldocs
  Dan Balasescu · 2025-04-17 02:34:10 +09:00
  c283859bab
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Merge pull request #32757 from smoogipoo/playlist-completion-icon

  Add display to show completed playlist items

  Dean Herbert · 2025-04-16 19:41:12 +09:00
  435f03745f
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Update API beatmap model to include user play count
  Salman Alshamrani · 2025-04-11 02:24:38 +09:00
  6bb84e4364
• Rename to passed
  Dan Balasescu · 2025-04-10 18:44:44 +09:00
  3dc8a4c1ed
• Add display to show completed playlist items
  Dan Balasescu · 2025-04-10 18:07:10 +09:00
  34180c62eb
• Ensure correct global leaderboard state when presenting scores

  With `ReplayPlayer` now consuming the `LeaderboardManager`'s global
  state, flows such as presenting a score need to set the global state up
  correctly to avoid accidentally showing a leaderboard from a completely
  different score.
  
  This also incidentally closes https://github.com/ppy/osu/issues/27609.

  Bartłomiej Dach · 2025-04-10 10:19:04 +02:00
  31b98ac7b9
• Update scores request to move away from old endpoint
  Bartłomiej Dach · 2025-04-10 09:46:46 +02:00
  17bcc28429
• Actually use leaderboard manager in players

  This was supposed to be the case all along, but I guess in all of the
  rewrite attempts I forgot?
  
  With this, https://github.com/ppy/osu/issues/29861 is actually fixed
  again - and additionally, so is https://github.com/ppy/osu/issues/26716.

  Bartłomiej Dach · 2025-04-10 09:46:44 +02:00
  42ff312ece
• Simplify code further
  Bartłomiej Dach · 2025-04-08 13:08:11 +02:00
  9aaa1fe5f4
• Fix test failures
  Bartłomiej Dach · 2025-04-08 13:03:35 +02:00
  f3d9f21e71
• Merge branch 'master' into yet-another-leaderboard-rewrite-attempt
  Bartłomiej Dach · 2025-04-08 12:54:27 +02:00
  567c7cb798
• Merge pull request #32669 from smoogipoo/refactor-match-subscreen

  Rewrite match subscreen to remove bindables

  Bartłomiej Dach · 2025-04-08 12:51:36 +02:00
  b3626bfb48
• Fix potential crashes due to asynchronous BindableList usage

  Band-aid fix for https://github.com/ppy/osu/issues/32671.
  
  Removes all `BindableList.BindTo` from `load()` methods (except one
  editor one which looks safe and is kinda hard to fix without moving
  drawable load to a blocking operation).

  Dean Herbert · 2025-04-04 19:54:47 +09:00
  04f8fcd04f
• Rewrite match subscreen to use full online state
  Dan Balasescu · 2025-04-04 10:48:55 +09:00
  286b3d9f5b
• Merge pull request #32657 from bdach/ruleset-specific-user-tags

  Add support for ruleset-specific user tags

  Dean Herbert · 2025-04-03 18:58:05 +09:00
  42a7094f9c
• Add [JsonIgnore] to MultiplayerRoom.CurrentPlaylistItem

  The lack of this is currently failing a unit test on
  `osu-server-spectator` current master:
  
  https://github.com/ppy/osu-server-spectator/actions/runs/14193158383/job/39762243965#step:4:28
  
  I don't think the failure actually matters because I don't think we're
  using json serialisation on spectator server side anywhere (used to for
  iOS at least, but I don't think we do anymore?), but probably better to
  be safe than sorry.

  Bartłomiej Dach · 2025-04-03 10:03:06 +02:00
  9a4371a817
• Merge pull request #32372 from smoogipoo/playlist-item-copy

  Add cloning to `MultiplayerPlaylistItem`, and tests using fake data

  Dean Herbert · 2025-04-03 12:17:35 +09:00
  ac88220a3d
• Add support for ruleset-specific user tags

  Follow-up from https://github.com/ppy/osu-web/pull/12059

  Bartłomiej Dach · 2025-04-02 13:12:49 +02:00
  22f2c6f7b9
• Merge pull request #32610 from bdach/user-tags-on-beatmap-set-overlay

  Show user tags on beatmap set overlay

  Dean Herbert · 2025-03-28 17:10:57 +09:00
  f4c96ecb54
• Implement blocking users from context menu
  Zihad · 2025-03-27 22:37:37 +06:00
  afce72896f
• Show user tags on beatmap set overlay

  Resolves one part of
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928
  
  A few caveats:
  
  - Layout is slightly different than web intentionally. Web does things
    that I think will be difficult to reproduce or just plain look bad in
    client, such as:
  
    - On web, the metadata info box has 200px min height and 300px max
      height. I just hardcoded 300 units.
  
    - On web, user tags and mapper tags are individually scrollable, and
      the amount of space taken up by each is calculated in a way that
      is - as far as I can tell - indeterminate, and probably influenced
      by some flexbox magic. I just made the entire thing scrollable
      instead.
  
  - Because song select shares controls with the beatmap set overlay, now
    song select says "Mapper Tags" in the header instead of just "Tags"
    too. I think this is fine, because people asked for user tags to be
    shown in song select too.
  
  - Search query syntax lifted from
    https://github.com/ppy/osu-web/pull/12047.
  
  - Using hardcoded English strings for now, will update to the
    translations after the next osu-resources localisations update.

  Bartłomiej Dach · 2025-03-27 14:58:03 +01:00
  7bb97d5796
• Merge pull request #32571 from smoogipoo/refactor-mp-availability

  Refactor online play beatmap availability, add multiplayer-specific implementation

  Bartłomiej Dach · 2025-03-26 13:52:07 +01:00
  c82eaafe98
• Merge pull request #32540 from frenzibyte/mod-rich-tooltip

  Display mod tooltips in rich form

  Dean Herbert · 2025-03-25 16:44:43 +09:00
  6dbd6a7e7b
• Refactor tracker to be a bit more stateless

  Removes storage of `selectedBeatmap` that was referenced through
  multiple class-level methods.
  
  To expound a bit, this structure felt better (or otherwise passing
  `APIBeatmap` through methods) alongside removal of the `#nullable
  disable`, otherwise each method would check `selectedBeatmap != null`.

  Dan Balasescu · 2025-03-25 14:23:05 +09:00
  72b56146ee
• Merge pull request #32460 from smoogipoo/refactor-match-footer

  Refactor multiplayer match footer

  Bartłomiej Dach · 2025-03-24 12:14:57 +01:00
  fdcf40d4a6
• Merge pull request #32495 from bdach/some-more-activities

  Adjust user activity updates

  Dan Balasescu · 2025-03-24 12:53:12 +09:00
  6d7e94f58e
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a