106 Commits

• Move realm collection retrieval to exist beside beatmap retrieval for organisation
  Dean Herbert · 2025-08-01 16:27:07 +09:00
  2d748e24ec
• Add support for grouping beatmaps by collections

  Takes changes in https://github.com/ppy/osu/pull/34233 and removes *all*
  of the complexity.
  
  Supersedes and closes #34233.
  
  Contains same caveat that we can only display one beatmap once in the
  carousel; this will be addressed separately.

  Dean Herbert · 2025-08-01 16:23:26 +09:00
  c3396a93a6
• Ensure adjacent selection when currently selected beatmap(set) is deleted
  Dean Herbert · 2025-07-10 17:46:09 +09:00
  994bd4abfe
• Merge pull request #33889 from frenzibyte/source-grouping

  Add mode for grouping beatmaps by their source

  Dean Herbert · 2025-07-08 17:09:45 +09:00
  3406303060
• Tweak SSv2 navigation sfx
  Jamie Taylor · 2025-07-05 02:01:22 +09:00
  567d09209b
• Fix typo
  Bartłomiej Dach · 2025-06-30 11:03:06 +02:00
  a8e3ce9af1
• Refactor distance-between-panels implementation

  The new version wasn't really working as expected, because the Y
  position measurement only considered visible panels, while it was being
  divided over all panels (including non-expanded groups or sets).
  
  Rather than trying to divide across all panels, just choose a sane
  number for the "highest pitch" sound and work with that as a constant.

  Dean Herbert · 2025-06-30 16:21:41 +09:00
  d7b7640055
• Play error sound when random selection fails
  Dean Herbert · 2025-06-30 16:20:32 +09:00
  bf8b6754dc
• Fix random sound effect not playing correctly
  Dean Herbert · 2025-06-30 16:09:23 +09:00
  9155f566ec
• Change GroupDefinition equality to be case insensitive
  Salman Alshamrani · 2025-06-26 09:58:30 +03:00
  e06e74d84e
• Merge pull request #33773 from peppy/fix-carousel-random-not-respecting-group

  SongSelectV2: Refine random selection to currently open group (and support difficulty split panels better)

  Bartłomiej Dach · 2025-06-24 14:37:09 +02:00
  a797c46d75
• Ensure expanded group is cleared when grouping is turned off
  Bartłomiej Dach · 2025-06-24 13:38:32 +02:00
  8781901d6b
• Expand test to cover more potential weirdness and fix said weirdness
  Dean Herbert · 2025-06-24 19:21:04 +09:00
  7b6ecbd10b
• Fix potential crash when attempting random selection after changing grouping mode
  Dean Herbert · 2025-06-24 17:48:38 +09:00
  a1ec71e677
• Merge pull request #33668 from peppy/ssv2-group-key-bindings
  Bartłomiej Dach · 2025-06-19 17:35:28 +02:00
  267a6a0ac7
• SongSelectV2: Fix random selection not working as expected when displaying individual difficulties

  Previously, random selection would always be done at a *set* level. The
  final operation of a random action would be "select the user's
  recommended difficulty from this randomly selected set".
  
  This makes no sense when sets are not grouped together at song select.
  In fact, it is completely broken with the previous commit which adds
  group-isolated random support – if we're grouping by difficulty and the
  user's recommendation is not in the current group it would throw the
  user into another group unexpectedly.
  
  This fixes the issue by splitting out the random implementation into two
  separate pathways depending on the carousel display mode.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  f676206331
• SongSelectV2: Fix random button not respecting open group

  Closes https://github.com/ppy/osu/issues/33569.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  d200a59902
• Fix crash when random and rewind are run on the same frame
  Dean Herbert · 2025-06-16 20:17:07 +09:00
  10c07fdf50
• Add support for toggling current group expansion using shift-enter

  Closes https://github.com/ppy/osu/issues/33617.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  52ba22ca1f
• Add support for traversing between groups using shift-left/right

  Closes https://github.com/ppy/osu/issues/33599.

  Dean Herbert · 2025-06-12 20:36:02 +09:00
  3816c5d95f
• Move and rename next/previous "group" selection keybindings to make way for group-specific bindings
  Dean Herbert · 2025-06-11 21:02:52 +09:00
  b9e1b6969e
• Add back scrollbar padding in new beatmap carousel

  Closes https://github.com/ppy/osu/issues/33447. Implementation copied
  from previous carousel.

  Dean Herbert · 2025-06-11 16:34:04 +09:00
  cfd73cc900
• Allow changing difficulties using up and down arrows when sets are grouped
  Dean Herbert · 2025-06-10 13:06:30 +09:00
  cc150faf81
• Merge branch 'master' into fix-potential-sets-changed-overhead
  Dean Herbert · 2025-06-07 02:30:20 +09:00
  f183496d19
• Ensure beatmapSetsChanged code doesn't run during gameplay
  Dean Herbert · 2025-06-07 01:28:49 +09:00
  b3bda6a560
• Use equality when updated current carousel selection
  Dean Herbert · 2025-06-06 23:20:38 +09:00
  6ab9ee76b7
• SongSelectV2: Fix incorrect selection change when filtered down to one set
  Dean Herbert · 2025-06-04 21:19:51 +09:00
  f52fabbb0c
• Ensure valid ruleset for gameplay
  Dean Herbert · 2025-06-04 15:45:40 +09:00
  c73ef15ebf
• Update one more inline comment
  Bartłomiej Dach · 2025-06-03 15:14:56 +02:00
  367b6727cd
• Remove local manifestation of beatmap sets now that set items is always populated

  Since 4d33602.

  Dean Herbert · 2025-06-03 22:03:12 +09:00
  4a4991e348
• Fix multiple incorrect behaviours due to reliance on dictionary init state
  Dean Herbert · 2025-06-02 18:10:59 +09:00
  ea2eded6e1
• Fix random selection potentially selecting a filtered-away beatmap
  Dean Herbert · 2025-06-01 00:58:56 +09:00
  4d33602ccd
• Fix selection's carousel Y position being read too early

  `updateItemYPosition()` mutates `item.CarouselYPosition`, so storing
  that to the selections before it's updated is storing stale values.

  Bartłomiej Dach · 2025-05-30 14:49:03 +02:00
  a3db764008
• Fix incorrect cross-thread access of beatmap list
  Dean Herbert · 2025-05-30 19:39:49 +09:00
  5cf173196e
• Merge pull request #33332 from peppy/song-select-v2-fix-double-filter

  SongSelectV2: Fix carousel filtering twice on entering song select

  Bartłomiej Dach · 2025-05-30 12:29:32 +02:00
  559ddd1ec9
• Use nullable Criteria instead of ctor flag
  Dean Herbert · 2025-05-30 18:15:27 +09:00
  5bf235f2dc
• Separate out expanded/selected set and difficulty panels with extra padding
  Dean Herbert · 2025-05-30 16:27:19 +09:00
  017cef4255
• Fix carousel filtering twice on entering song select
  Dean Herbert · 2025-05-30 16:03:31 +09:00
  bb938be0b6
• Separate active standalone beatmap panels from the carousel vertically
  Dean Herbert · 2025-05-30 02:20:39 +09:00
  6fbc9e4580
• SongSelectV2: Fix incorrect conditional being used for "split out" check

  🤦
  
  Have inlined the v1 usage so we don't accidentally do this again.

  Dean Herbert · 2025-05-29 01:22:22 +09:00
  ef8fd7b5d7
• Merge pull request #33306 from peppy/song-select-v2-select-single-result

  SongSelectV2: If only one results is visible after filter, select it automatically

  Bartłomiej Dach · 2025-05-28 14:05:33 +02:00
  f1b6814ff3
• Merge branch 'master' into song-select-v2-fix-loading-overlay
  Bartłomiej Dach · 2025-05-28 13:16:30 +02:00
  bbeb1be295
• SongSelectV2: If only one results is visible after filter, select it automatically
  Dean Herbert · 2025-05-28 20:07:44 +09:00
  731a4968f5
• Merge branch 'master' into song-select-v2-random
  Dean Herbert · 2025-05-28 20:06:50 +09:00
  0b527ce14b
• Merge pull request #33301 from peppy/remember-group-expansion

  SongSelectV2: Fix expanded group not being persisted over filter operations

  Bartłomiej Dach · 2025-05-28 12:55:23 +02:00
  d9d74696df
• Prevent random selection from selecting hidden beatmaps
  Bartłomiej Dach · 2025-05-28 12:22:09 +02:00
  db7c6fa850
• Fix difficulty grouping not working with random
  Dean Herbert · 2025-05-28 12:14:27 +02:00
  dca839211c
• SongSelectV2: Fix carousel loading state looking out of place
  Dean Herbert · 2025-05-28 18:31:37 +09:00
  7a4d9c7c9a
• SongSelectV2: Fix expanded group not being persisted over filter operations
  Dean Herbert · 2025-05-28 18:15:40 +09:00
  df66bab31f
• Rename and expose BeatmapCarousel selection handling variables

  For test usage and consistency.

  Dean Herbert · 2025-05-28 18:15:39 +09:00
  ef39b8d9c0