1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-08 14:37:25 +08:00
Commit Graph

57779 Commits

Author SHA1 Message Date
ansel
49ce50878d Add simple test 2023-01-07 04:15:53 +03:00
ansel
927773d565 Display submitted comments locally 2023-01-07 04:15:43 +03:00
ansel
58bf7349ee Fix request 2023-01-07 02:59:32 +03:00
ansel
32e90829e3 Integrate comment editor into container 2023-01-07 02:59:24 +03:00
ansel
768a33bb64 Add request class 2023-01-06 23:31:19 +03:00
ansel
387326db0d Make commit action abstract 2023-01-06 22:51:57 +03:00
Feodor0090
930cd15649
Merge branch 'master' into comment-editor-1 2022-12-28 17:46:01 +05:00
Bartłomiej Dach
e4c060fc3a
Merge pull request #21854 from peppy/fix-website-root
Fix `osu.ppy.sh` links no longer opening in-game
2022-12-28 13:43:24 +01:00
Dean Herbert
c20c6cdebf
Merge pull request #21878 from bdach/android-version-spec
Adjust Android package versioning to .NET 6
2022-12-28 19:39:15 +08:00
Bartłomiej Dach
4b71ccf315
Merge pull request #21879 from frenzibyte/first-object-visbility-keywords
Add keywords to ease search of "first object visibility" setting
2022-12-28 12:15:34 +01:00
Salman Ahmed
b4c5e18da0 Add keywords to ease search of "first object visibility" setting 2022-12-28 13:23:50 +03:00
Bartłomiej Dach
76367444cb
Adjust Android package versioning to .NET 6
With .NET 6, the way Xamarin package versioning works has changed.

- The `ApplicationVersion` MSBuild property aims to replace
  `android:versionCode` in the manifest.
- The `ApplicationDisplayVersion` MSBuild property aims to replace
  `android:versionName` in the manifest.

More about this can be read in Xamarin docs:

    ec712da8c1/Documentation/guides/OneDotNetSingleProject.md

To this end:

- Manual `version{Code,Name}` specs are removed from
  `AndroidManifest.xml`, as they were preventing MSBuild properties
  from functioning properly.
- `Version` now defaults to 0.0.0, so that local builds don't appear
  like they were deployed (see `OsuGameBase.IsDeployedBuild`).
- `ApplicationDisplayVersion` now defaults to `Version`.
  This addresses the Android portion of #21498.
- `ApplicationVersion` can now be specified by command line,
  but still needs to be supplied manually for version detection to
  work correctly. See `OsuGameAndroid.AssemblyVersion` for more info.

Putting the pieces together, the complete publish command to deploy
a new build should look something like so:

    dotnet publish -f net6.0-android \
                   -r android-arm64 \
                   -c Release \
                   -p:Version=2022.1228.0 \
                   -p:ApplicationVersion=202212280
2022-12-28 10:36:54 +01:00
Dean Herbert
0d78bc2248 Fix osu.ppy.sh links no longer opening in-game
Addresses https://github.com/ppy/osu/discussions/21838.
2022-12-28 06:42:35 +08:00
Dean Herbert
5e8ca11ded
Merge pull request #21819 from bdach/fix-global-ranking-accuracy-display
Fix incorrect accuracy display on overall ranking view
2022-12-28 04:47:15 +08:00
Bartłomiej Dach
e90619244d
Fix incorrect accuracy display on overall ranking view 2022-12-27 19:51:51 +01:00
Bartłomiej Dach
e2703bba18
Fix invalid data in test scene 2022-12-27 19:49:08 +01:00
Bartłomiej Dach
b4a3f872ee
Merge pull request #21809 from turbedi/split_trimentries
Use StringSplitOptions.TrimEntries in string.Split() when possible
2022-12-27 18:42:48 +01:00
Bartłomiej Dach
ae2058b55e
Merge branch 'master' into split_trimentries 2022-12-27 18:07:36 +01:00
Dean Herbert
080790d352
Merge pull request #21812 from frenzibyte/fix-publish
Move system packages version pinning workaround to game project
2022-12-27 20:31:35 +08:00
Salman Ahmed
1a4489edb2 Move version pinning of system packages to osu.Game 2022-12-27 14:58:18 +03:00
Dean Herbert
9be1689e04
Merge pull request #21811 from peppy/add-hard-link-faq
Add link to hard link explanation wiki page
2022-12-27 18:25:56 +08:00
Dean Herbert
61029b126d Add link to hard link explanation wiki page 2022-12-27 17:56:23 +08:00
Dean Herbert
42c1d410b4
Merge pull request #21810 from peppy/api-switch
Use new lazer API endpoint
2022-12-27 17:56:20 +08:00
Dean Herbert
b3e44f20bc Use new lazer API endpoint
This is a temporary change to target the new experimental/next deploy.
The main change that should result from this is having the user profile
show the pp^next values from the new domain.
2022-12-27 17:20:40 +08:00
Berkan Diler
182f36c434 Use StringSplitOptions.TrimEntries for string.Split() when possible 2022-12-27 09:41:58 +01:00
Dean Herbert
df6f2ad0a1
Merge pull request #21804 from bdach/hide-global-rankings-when-presenting-scores
Only show global rankings on solo results screen when progressing from gameplay
2022-12-27 16:39:26 +08:00
Dean Herbert
38a674cd84
Merge pull request #21807 from Joehuu/external-link-open-highlight
Highlight "open" option on external link button context menu
2022-12-27 16:09:06 +08:00
Joseph Madamba
777ffcf805 Highlight "open" option on external link button context menu 2022-12-26 20:47:24 -08:00
Salman Ahmed
bcaff37851
Merge pull request #21802 from turbedi/generic_enum
Use generic Enum methods
2022-12-27 02:42:12 +03:00
Bartłomiej Dach
01cf96e240
Only show global rankings on results screen when progressing from gameplay 2022-12-26 23:35:45 +01:00
Bartłomiej Dach
cb2b0d4178
Remove redundant type specs 2022-12-26 23:12:53 +01:00
Berkan Diler
335cb0205f Remove now unnecessary using 2022-12-26 22:50:36 +01:00
Berkan Diler
fcbb21c75e Fix typo 2022-12-26 20:38:35 +01:00
Berkan Diler
c7ca4bbba5 Use generic Enum methods 2022-12-26 20:36:39 +01:00
Bartłomiej Dach
2470991aaa
Merge pull request #21800 from mk56-spn/remove_obsolete_star_colours
Remove obsoleted "ForDifficultyRating" method
2022-12-26 17:39:25 +01:00
Bartłomiej Dach
e416bdd06b
Merge branch 'master' into remove_obsolete_star_colours 2022-12-26 16:35:47 +01:00
mk56-spn
fbff5d8d69 Remove obsoleted "ForDifficultyRating" method 2022-12-26 16:16:52 +01:00
Dean Herbert
6b5059285b
Merge pull request #21798 from peppy/update-framework
Update framework
2022-12-26 22:44:47 +08:00
Dean Herbert
5dd03c6c60 Update framework 2022-12-26 21:53:52 +08:00
Dan Balasescu
786d94c149
Merge pull request #21792 from Joehuu/fix-parameters-inspection
Fix parameters with the same default value inspection
2022-12-26 15:41:54 +09:00
Dean Herbert
0761fa54c5
Merge pull request #21778 from bdach/score-stats-on-results
Add overall ranking display to solo results screen
2022-12-26 14:14:53 +08:00
Dean Herbert
09cc41604f
Merge branch 'master' into score-stats-on-results 2022-12-26 13:37:36 +08:00
Joseph Madamba
144144c40c Revert removing redundant font parameter 2022-12-25 20:47:05 -08:00
Joseph Madamba
a10628e270 Change severity of RedundantArgumentDefaultValue to hint 2022-12-25 20:47:05 -08:00
Salman Ahmed
ee77b8cad3
Merge branch 'master' into fix-parameters-inspection 2022-12-26 05:17:40 +03:00
Dean Herbert
97d3b7bd63
Merge pull request #21781 from Joehuu/link-title-and-artist
Link beatmap set title and artist to listing search
2022-12-26 10:13:16 +08:00
Salman Ahmed
2d57ea6f15
Merge branch 'master' into link-title-and-artist 2022-12-26 03:23:05 +03:00
Joseph Madamba
973fd90af2 Fix parameters with the same default value inspection 2022-12-25 16:15:02 -08:00
Joseph Madamba
f959b02dc8 Use empty drawables for spacing badges instead 2022-12-25 16:05:59 -08:00
Joseph Madamba
8e899c2e92 Use localisation parameters to find preferred string instead 2022-12-25 16:03:44 -08:00