45783 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	e7225399a2	Fix slider event generator incorrectly not generating repeats when tick distance is zero ... RFC. This closes https://github.com/ppy/osu/issues/31186. To explain why: The issue occurs on https://osu.ppy.sh/beatmapsets/594828#osu/1258033, specifically on the slider at time 128604. The failure site is fa0d2f4af2/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderCircleOverlay.cs (L65-L66) wherein `LastRepeat` is `null`, even though the slider's `RepeatCount` is 1 and thus `SpanCount` is 2. In this case, `SliderEventGenerator` is given a non-zero `tickDistance` but a zero `length`. The former is clamped to the latter: fa0d2f4af2/osu.Game/Rulesets/Objects/SliderEventGenerator.cs (L34) Because of this, a whole block of code pertaining to tick generation gets turned off, because of zero tick spacing - however, that block also includes within it *repeat* generation, for seemingly very little reason whatsoever: fa0d2f4af2/osu.Game/Rulesets/Objects/SliderEventGenerator.cs (L47-L77) While a zero tick distance would indeed cause `generateTicks()` to loop forever, it should have absolutely no effect on repeats. While this *is* ultimately an aspire-tier bug caused by people pushing things to limits, I do believe that in this case a fix is warranted because of how hard the current behaviour violates invariants. I do not like the possibility of having a slider with multiple spans and no repeats.	2024-12-27 12:38:31 +01:00
Bartłomiej Dach	e9762422b3	Round object coordinates to nearest integers rather than truncating ... Addresses https://github.com/ppy/osu/issues/31256.	2024-12-27 11:10:29 +01:00
Bartłomiej Dach	0d16ed028b	Add setters to hitobject coordinate interfaces	2024-12-27 11:01:47 +01:00
Bartłomiej Dach	5abad07412	Pause playback when entering gameplay test from editor ... Closes https://github.com/ppy/osu/issues/31290. Tend to agree that this is a good idea for gameplay test at least. Not sure about other similar interactions like exiting - I don't think it matters what's done in those cases, because for exiting timing is in no way key, so I just applied this locally to gameplay test.	2024-12-27 09:08:16 +01:00
Dean Herbert	2a374c0695	Add migration	2024-12-26 15:46:12 +09:00
Dean Herbert	e752531aec	Fix volume adjust key repeat not working as expected ... Regressed in https://github.com/ppy/osu/pull/31146. Closes part of https://github.com/ppy/osu/issues/31267.	2024-12-26 15:05:59 +09:00
kongehund	1f60adbaf1	Switch scroll direction for beat snap ... Matches stable better	2024-12-26 00:35:21 +01:00
Dan Balasescu	6579b05561	Remove unused usings	2024-12-25 23:45:36 +09:00
Dan Balasescu	e7c272b8b9	Don't display on matching beatmap/ruleset	2024-12-25 23:39:01 +09:00
Dan Balasescu	c3aa9d6f8a	Display user style in participant panel	2024-12-25 23:30:24 +09:00
Dan Balasescu	0093af8f55	Rewrite everything to better support spectator server messaging	2024-12-25 22:24:21 +09:00
Dan Balasescu	a407e3f3e0	Fix co-variant array conversion	2024-12-25 16:46:02 +09:00
Dean Herbert	62e536baf6	Merge pull request #31138 from bdach/mark-as-played ... Implement ability to mark beatmap as played	2024-12-24 21:43:15 +09:00
Dean Herbert	df3b300fff	Merge pull request #31226 from frenzibyte/fix-raw-input-mobile ... Add `Hidden` cursor state flag on non-desktop platforms as well	2024-12-24 21:35:50 +09:00
Dan Balasescu	a2dc16f8df	Fix inspection	2024-12-24 20:22:16 +09:00
Dan Balasescu	b4f35f330c	Use online ruleset_id to build local score models	2024-12-24 20:13:42 +09:00
Dan Balasescu	c88e906cb6	Add some comments	2024-12-24 19:40:06 +09:00
Dan Balasescu	d8ff5bcacb	Fix freemods button opening overlay unexpectedly	2024-12-24 19:39:56 +09:00
Dan Balasescu	ac738f109a	Add style selection to playlists screen	2024-12-24 19:28:09 +09:00
Dan Balasescu	971ccb6a4e	Adjust namings	2024-12-24 19:05:50 +09:00
Bartłomiej Dach	287b880ec7	Merge pull request #31259 from peppy/intro-volume-adjust ... Fix adjusting volume using scroll wheel not working during intro	2024-12-24 10:18:10 +01:00
Dan Balasescu	40486c4f38	Block beatmap presents in style select screen	2024-12-24 18:04:36 +09:00
Dan Balasescu	7777c44775	Only allow selecting beatmaps within 30s length	2024-12-24 17:57:59 +09:00
Dean Herbert	ce1eda7e54	Fix adjusting volume using scroll wheel not working during intro	2024-12-24 17:11:21 +09:00
Dean Herbert	d8686f55f7	Slightly reduce background brightness at main menu when seasonal lighting is active	2024-12-24 17:10:48 +09:00
Bartłomiej Dach	1f90be3fea	Merge branch 'master' into editor-beat-snap-adjust-scroll	2024-12-24 08:21:34 +01:00
Bartłomiej Dach	d9be172647	Add explanatory comment for schema version bump	2024-12-24 08:21:27 +01:00
Dean Herbert	a5d354d753	Update framework	2024-12-24 15:17:10 +09:00
Dean Herbert	362311d040	Merge pull request #31220 from normalid-awa/feature/skin/rename-skin ... Add ability to rename the skin	2024-12-24 14:24:48 +09:00
Dean Herbert	85f5234880	Merge pull request #31238 from frenzibyte/make-featured-artist-setting ... Save "featured artists" filter to user settings and disable toggling on iOS	2024-12-24 14:07:20 +09:00
Dean Herbert	378bef34ef	Change order of skin layout editor button for better visual balance	2024-12-24 13:42:18 +09:00
Dean Herbert	ae9c7e1b35	Adjust layout and remove localisable strings for temporary buttons	2024-12-24 13:17:58 +09:00
Dean Herbert	8762e3fedb	Always show tooltip, and reword to be always applicable	2024-12-24 12:25:18 +09:00
Dean Herbert	282c67d14b	Update resources	2024-12-24 11:59:45 +09:00
Dean Herbert	7e8aaa68ff	Add keywords for intro-related settings	2024-12-24 11:46:39 +09:00
Plextora	47afab8a32	Use yellow instead of pink	2024-12-23 12:47:50 -05:00
Salman Alshamrani	6b635d588f	Add tooltip	2024-12-23 10:59:06 -05:00
Salman Alshamrani	7e3477f4bb	Remove unnecessary guarding	2024-12-23 10:54:52 -05:00
Salman Alshamrani	050bf9ec60	Keep 'x' symbol visible even while disabled	2024-12-23 10:52:18 -05:00
Dean Herbert	9ff4a58fa3	Add migration to update users which have previous default bindings for beat snap	2024-12-23 22:14:03 +09:00
Dean Herbert	097828ded2	Fix incorrect mouse wheel mappings	2024-12-23 22:07:42 +09:00
Dan Balasescu	638d959c5c	Initial support for free style selection	2024-12-23 20:12:25 +09:00
Dean Herbert	7b9f776a14	Merge pull request #31206 from peppy/christmas ... Add christmas / seasonal mode	2024-12-23 16:49:38 +09:00
Dean Herbert	f12fffd116	Fix more than obvious test failure ... Please run tests please run tests please run tests.	2024-12-23 14:43:36 +09:00
Dean Herbert	1a7feeb4ed	Use virtual property rather than inline iOS conditional	2024-12-23 14:39:07 +09:00
Plextora	b3056d6114	Change score background to pink if user is friended	2024-12-22 16:58:00 -05:00
Salman Alshamrani	fcfab9e53c	Fix spacing	2024-12-22 10:14:52 -05:00
Dean Herbert	0aed625bb8	Rename variable and adjust commentary	2024-12-22 23:58:35 +09:00
Dean Herbert	e716919a07	Remove redundant && true ... Co-authored-by: Susko3 <Susko3@protonmail.com>	2024-12-22 22:57:17 +09:00
Salman Alshamrani	589e187a80	Disable ability to toggle "featured artists" beatmap listing filter in iOS	2024-12-22 07:50:08 -05:00