3512 Commits

• Merge branch 'master' into tidy-screen-footer
  Bartłomiej Dach · 2025-05-15 12:55:28 +02:00
  0132b78eec
• Tidy up ScreenFooter and back button action flow
  Dean Herbert · 2025-05-15 18:37:42 +09:00
  087e054708
• Code quality fixes
  Dean Herbert · 2025-05-15 12:14:54 +03:00
  bb8d3bcf66
• Allow starting beatmap with autoplay via ctrl-enter
  Salman Alshamrani · 2025-05-15 17:01:23 +09:00
  8e7c093476
• Make carousel handle pressing enter with modifier keys
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  87c97ad0b5
• Merge branch 'master' into full-sorting-support
  Bartłomiej Dach · 2025-05-14 14:42:29 +02:00
  a57ca72ccf
• Allow tests to accedss CarouselItems post filter operation
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  8e15af2b2d
• Fix new (beatmap) carousel not correctly accounting for user scroll overrides

  The new carousel implementation was lacking some scroll related
  behaviours. This makes sure that post-filter, the selection is
  re-centered *unless* the user has scrolled away manually.
  
  This matches the old carousel's behaviour. See
  https://github.com/ppy/osu/pull/16647 for original implementation.
  
  Closes https://github.com/ppy/osu/issues/33052.

  Dean Herbert · 2025-05-14 17:32:44 +09:00
  a8d8d2d84c
• Fix exceptions being hidden by async task usage
  Dean Herbert · 2025-05-13 17:43:57 +09:00
  36317bc459
• Use fast invert helper in hot path
  Dan Balasescu · 2025-05-11 13:05:15 +09:00
  ff0a80751a
• Update filter control's status text with beatmap displayed count

  This also fixes code running in `Update` which shouldn't be, by
  consuming the new `NewItemsPresented` callback.
  
  Fields and properties are renamed to knock some sense into things (was
  previously called two or three different things).

  Dean Herbert · 2025-05-09 15:05:41 +09:00
  1edbdc5aac
• Expose a way of knowing when carousel's displayed items are updated
  Dean Herbert · 2025-05-09 14:49:38 +09:00
  a957f41ffc
• Merge pull request #33039 from frenzibyte/song-select-filter-support

  Hook up filter control with beatmap carousel

  Dean Herbert · 2025-05-07 19:28:24 +09:00
  724176458f
• Change ICarouselFilter interface return type rather than manual ToList

  I was hung up on keeping `IEnumerable` but there doesn't seem to be a
  good reason to do so.

  Dean Herbert · 2025-05-07 16:40:23 +09:00
  ebd6776898
• Ensure carousel filters are manifested to lists at each step

  The original `IEnumerable` flow prioritised slight performance gains,
  but a filter's implementation could actually make this detrimental to
  overall performance.
  
  I noticed in passing that there were already potentially multiple
  enumerations, via `updateYPositions` and the final `ToList` call. Rather
  than faffing around, let's keep things simple and require lists.
  
  In benchmarking, the difference is (currently) negiligible. Slight
  improvement if anything.

  Dean Herbert · 2025-05-07 15:55:20 +09:00
  cc0c21a216
• Add test coverage for song select filtering
  Salman Alshamrani · 2025-05-07 09:17:54 +03:00
  d34e040b4e
• Fix sheared components getting masked away due to negative margins
  Dean Herbert · 2025-04-30 18:33:49 +09:00
  c2a7687a66
• Add song select filter control
  Salman Alshamrani · 2025-04-30 17:53:14 +09:00
  9d3ee2a573
• Add ShearedSearchTextBox variant with "N matches" note
  Salman Alshamrani · 2025-04-30 17:42:09 +09:00
  8576ef247f
• Limit input inside slider bar pieces instead
  Salman Alshamrani · 2025-04-30 11:08:30 +03:00
  84cb4da1ec
• Fix masking bleed
  Dean Herbert · 2025-04-30 16:00:00 +09:00
  10c546dced
• Add ability to click/drag in between nubs for better control
  Dean Herbert · 2025-04-30 15:32:58 +09:00
  9871acd618
• Introduce sheared range slider
  Salman Alshamrani · 2025-04-30 14:52:51 +09:00
  f3e23def90
• Merge pull request #32847 from frenzibyte/song-select-v2-sheared-components-changes

  Fixes and improvements to existing sheared components

  Dean Herbert · 2025-04-30 14:25:28 +09:00
  c268dfd99a
• Fix sheared button getting cut when scaled beyond 100%

  Keep masking back in `Content`, since the scaling animation is happening
  on `Content` instead of `this`. This doesn't regress the intended
  behaviour in this PR (which is to just to make the button class itself
  sheared instead of its content).

  Salman Alshamrani · 2025-04-29 05:34:10 +03:00
  b4cf974662
• Attempt to improve appearance of new combo toggle / combo colour control when contracted

  Follow-up to
  https://discord.com/channels/188630481301012481/188630652340404224/1364909125812617258.
  
  Not sure if better, but an attempt was made?

  Bartłomiej Dach · 2025-04-25 08:52:59 +02:00
  bc03a2a930
• Merge pull request #32915 from peppy/carousel-update-handling

  Add basic support for beatmap updates in `BeatmapCarousel`

  Bartłomiej Dach · 2025-04-23 13:10:25 +02:00
  7cf8207e6e
• Merge pull request #32909 from bdach/fix-daily-challenge-marker

  Fix daily challenge marker text spacing

  Dean Herbert · 2025-04-23 18:24:56 +09:00
  0adda23988
• Define constant for difficulty colour cutoff
  Dean Herbert · 2025-04-23 16:57:41 +09:00
  3f719125e6
• Fix increased spacing on fps counter tooltip
  Bartłomiej Dach · 2025-04-23 08:55:41 +02:00
  3f98dd93ed
• Ensure selection is retained over beatmap update
  Dean Herbert · 2025-04-22 21:01:56 +09:00
  615c7b29b5
• Change equality to allow non-reference comparisons

  This is required to hold selection when beatmaps are updates, as one
  important case.

  Dean Herbert · 2025-04-22 20:03:07 +09:00
  ac67473433
• Merge pull request #32841 from frenzibyte/song-select-v2-shear-aligning-wrapper

  Add shear-aligning drawable wrapper

  Dean Herbert · 2025-04-22 16:43:35 +09:00
  4bc6b9b3a2
• Merge pull request #32840 from frenzibyte/song-select-v2-constants

  Prerequisite changes for song select v2 design work

  Dean Herbert · 2025-04-22 16:39:05 +09:00
  a0698be6c2
• Merge pull request #32839 from frenzibyte/song-select-v2-panel-metrics

  Use new font specifications in beatmap panels and apply minor adjustments

  Dean Herbert · 2025-04-22 16:35:11 +09:00
  3ba3f3ace7
• Merge pull request #32838 from peppy/carousel-group-counts

  Add accounting of nested group items for group panel display purposes

  Bartłomiej Dach · 2025-04-21 14:05:21 +02:00
  930c56e713
• Fix slider tooltip text not updating with current value
  schiavoanto · 2025-04-20 09:43:45 +02:00
  267dccdd9a
• Remove weird default for slider nub X value
  Salman Alshamrani · 2025-04-18 07:37:23 -04:00
  af991d3b29
• Fix ShearedSliderBar left/right boxes not resized correctly
  Salman Alshamrani · 2025-04-18 07:36:55 -04:00
  4c911d3d91
• Allow disabling focus indicator in ShearedSliderBar
  Salman Alshamrani · 2025-04-18 07:28:25 -04:00
  715396e5c4
• Add drop shadow support in ShearedNub

  Used for range sliders

  Salman Alshamrani · 2025-04-18 07:28:25 -04:00
  6aab473150
• Remove padding from ShearedButton for better sheared flow alignment
  Salman Alshamrani · 2025-04-18 07:23:39 -04:00
  62b96466c4
• Add drawable wrapper for shear alignment purposes
  Salman Alshamrani · 2025-04-18 06:32:00 -04:00
  f480765bf4
• Add accounting of nested group items for group panel display purposes
  Dean Herbert · 2025-04-18 19:07:44 +09:00
  b80ea26475
• Merge pull request #32820 from peppy/global-audio-offset-control-fixes

  Fix global offset adjust control showing adjustment available when it shouldn't

  Dean Herbert · 2025-04-18 18:04:18 +09:00
  21fd4e857f
• Move number formatting to extension method and reuse for AudioOffsetAdjustmentControl

  Also adds some basic test coverage.

  Dean Herbert · 2025-04-18 17:30:31 +09:00
  e44b134552
• Update framework
  Dean Herbert · 2025-04-18 16:26:37 +09:00
  b02ff0f95c
• Adjust sheared dropdown menu padding
  Salman Alshamrani · 2025-04-17 08:54:43 -04:00
  f93e731a55
• Update song select panel metrics in line with standard specifications and apply minor adjustments
  Salman Alshamrani · 2025-04-17 08:21:32 -04:00
  9e2a05a1fb
• Disable masking of Carousel

  The default for carousels should be unmasked as their usage generally
  sees them overflowing outside their main usage area (see `bleed`
  variables).

  Dean Herbert · 2025-04-16 19:41:49 +09:00
  376b4e8929