73323 Commits

This Branch

This Branch

All Branches

• Tidy up TestSceneFooterButtonMods tests
  Dean Herbert · 2025-05-16 15:04:45 +09:00
  45d248cd26
• Merge pull request #33149 from peppy/song-select-v2-footer-beatmap-options
  Bartłomiej Dach · 2025-05-15 16:12:26 +02:00
  199da9c48c
• Fix line lost in merge resolution causing footer to disappear
  Dean Herbert · 2025-05-15 21:37:53 +09:00
  bc5c222953
• Fix compile failure
  Bartłomiej Dach · 2025-05-15 13:59:56 +02:00
  4924563eb1
• Hook up footer beatmap options via new ISongSelectBeatmapActions class
  Dean Herbert · 2025-05-15 20:31:54 +09:00
  9fea4a2ed0
• Fix screen footer buttons not having access to screen dependencies
  Dean Herbert · 2025-05-15 20:27:51 +09:00
  5a17d3c290
• Merge pull request #33147 from peppy/tidy-screen-footer

  Tidy some `ScreenFooter` code

  Dean Herbert · 2025-05-15 20:27:12 +09:00
  6897d53dbe
• Merge branch 'master' into tidy-screen-footer
  Bartłomiej Dach · 2025-05-15 12:55:28 +02:00
  0132b78eec
• Fix nullability inspections
  Bartłomiej Dach · 2025-05-15 12:55:21 +02:00
  840e51e6a1
• Merge pull request #33141 from frenzibyte/footer-fix-back-button

  Fix back button not displaying when transitioning to non-footer screen

  Dean Herbert · 2025-05-15 19:34:58 +09:00
  7f16feb92c
• Tidy up ScreenFooter and back button action flow
  Dean Herbert · 2025-05-15 18:37:42 +09:00
  087e054708
• Improve code quality
  Salman Alshamrani · 2025-05-15 12:26:28 +03:00
  60f56a0729
• Merge pull request #33118 from frenzibyte/ssv2-autoplay-shortcut

  SongSelectV2: Allow starting beatmap with autoplay via ctrl-enter

  Dean Herbert · 2025-05-15 18:18:15 +09:00
  137de6ed18
• Code quality fixes
  Dean Herbert · 2025-05-15 12:14:54 +03:00
  bb8d3bcf66
• Remove pointless dependency from ScreenFooter
  Dean Herbert · 2025-05-15 17:18:28 +09:00
  856693d7ee
• Fix song select test not waiting for initial filtering
  Salman Alshamrani · 2025-05-15 17:01:23 +09:00
  da163c1751
• Allow starting beatmap with autoplay via ctrl-enter
  Salman Alshamrani · 2025-05-15 17:01:23 +09:00
  8e7c093476
• Make carousel handle pressing enter with modifier keys
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  87c97ad0b5
• Add test coverage
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  e2ae3f2ad0
• Fix back button not displaying when transitoning to non-footer screen
  Salman Alshamrani · 2025-05-14 21:46:15 +03:00
  1829253b5a
• Add failing test case
  Salman Alshamrani · 2025-05-14 21:45:30 +03:00
  7dc9ea6774
• Merge pull request #33067 from frenzibyte/full-sorting-support

  Implement complete sorting mode support

  Dean Herbert · 2025-05-15 03:44:26 +09:00
  5939f51558
• Merge pull request #33133 from frenzibyte/ssv2-management-interface

  SongSelectV2: Expose method for opening editor and clearing local scores

  Dean Herbert · 2025-05-15 01:56:49 +09:00
  2035db6ab6
• Move dependency to correct class and use more appropriate name
  Dean Herbert · 2025-05-15 01:55:49 +09:00
  5eb14a5b26
• Merge pull request #33130 from bdach/fix-slider-extend-handle-crash

  Fix crashes when attempting to adjust length of slider whose maximum path length is less than the current beat snap

  Dean Herbert · 2025-05-14 23:20:31 +09:00
  4e27f495ab
• Expose general song select operations
  Salman Alshamrani · 2025-05-14 15:43:44 +03:00
  8fe422c35a
• Merge branch 'master' into full-sorting-support
  Bartłomiej Dach · 2025-05-14 14:42:29 +02:00
  a57ca72ccf
• Fix test failure
  Bartłomiej Dach · 2025-05-14 14:41:44 +02:00
  9899541fbb
• Fix some botched assertions
  Bartłomiej Dach · 2025-05-14 14:25:38 +02:00
  81e6d6a2de
• Merge pull request #33128 from peppy/carousel-user-scroll-accounting

  Fix new (beatmap) carousel not correctly accounting for user scroll overrides

  Bartłomiej Dach · 2025-05-14 13:57:41 +02:00
  a881498333
• Merge pull request #33127 from peppy/ssv2-backdoor

  Allow accessing song select v2 by holding control while entering song select

  Bartłomiej Dach · 2025-05-14 13:52:56 +02:00
  abd92200d9
• Merge branch 'master' into ssv2-backdoor
  Salman Alshamrani · 2025-05-14 14:43:58 +03:00
  650675e96a
• Fix crashes when attempting to adjust length of slider whose maximum path length is less than the current beat snap

  Closes https://github.com/ppy/osu/issues/32289.
  
  There are two possible choices here: either pulling the lower bound of
  the clamp down to `HitObject.Path.CalculatedDistance`, or pulling the
  higher bound up to `minDistance`, if it happens to be larger than the
  path's calculated distance.
  
  Both options are a bit weird; pulling down can result in unsnapped
  sliders when attempting to drag a slider's end when on a lower beat
  divisor than was used to place the slider, and pulling up can result in
  weird sliders wherein they get extended beyond their path's definition
  with a weird linear section at the end without an anchor that is tangent
  to the slider shape's end. I decided the first one was less weird, but
  I'm open to discuss further.

  Bartłomiej Dach · 2025-05-14 13:34:12 +02:00
  9b2f25cb93
• Merge pull request #33129 from bdach/remove-replay-recorder-depth-hack
  Dean Herbert · 2025-05-14 20:32:23 +09:00
  5d898525c6
• Make class partial
  Bartłomiej Dach · 2025-05-14 12:40:40 +02:00
  c7bfd2a52e
• Rename one more test
  Bartłomiej Dach · 2025-05-14 12:36:26 +02:00
  81689f7c69
• Fix test naming
  Dean Herbert · 2025-05-14 19:30:45 +09:00
  35e2094ed4
• Implement complete sorting mode support
  Salman Alshamrani · 2025-05-14 19:21:57 +09:00
  1a02e3266b
• Add test coverage for beatmap carousel v2 sort support
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  073b1810b3
• Allow tests to accedss CarouselItems post filter operation
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  8e15af2b2d
• Remove unnecessary replay recorder depth hack

  Addresses https://github.com/ppy/osu/pull/33102#discussion_r2087963889.

  Bartłomiej Dach · 2025-05-14 11:25:31 +02:00
  acebf3e95e
• Add baseline test coverage of replay recording in all rulesets

  Nothing fancy, just basics to ensure the subsequent commit doesn't break
  anything.

  Bartłomiej Dach · 2025-05-14 11:25:14 +02:00
  168c3cf018
• Fix new (beatmap) carousel not correctly accounting for user scroll overrides

  The new carousel implementation was lacking some scroll related
  behaviours. This makes sure that post-filter, the selection is
  re-centered *unless* the user has scrolled away manually.
  
  This matches the old carousel's behaviour. See
  https://github.com/ppy/osu/pull/16647 for original implementation.
  
  Closes https://github.com/ppy/osu/issues/33052.

  Dean Herbert · 2025-05-14 17:32:44 +09:00
  a8d8d2d84c
• Allow accessing song select v2 by holding control while entering song select
  Dean Herbert · 2025-05-14 17:06:18 +09:00
  0a3f05c52b
• Merge pull request #33120 from frenzibyte/ssv2-cache-class

  SongSelectV2: Fix `SongSelect` not cached for subcomponents

  Dean Herbert · 2025-05-14 10:47:01 +09:00
  93fda73062
• Merge pull request #33119 from frenzibyte/ssv2-mod-audio

  SongSelectV2: Apply mod adjustments to beatmap track

  Dean Herbert · 2025-05-14 01:36:57 +09:00
  7b93351197
• Fix SongSelect not cached for subcomponents
  Salman Alshamrani · 2025-05-13 15:32:44 +03:00
  74d10e2a62
• Apply mod adjustments to beatmap track
  Salman Alshamrani · 2025-05-13 15:24:18 +03:00
  bd136b88c6
• Merge pull request #32972 from bdach/multiplayer-position-indicator

  Add non-skinnable position indicator to multiplayer player

  Dean Herbert · 2025-05-13 20:53:15 +09:00
  3ce5389558
• Merge pull request #33117 from frenzibyte/ssv2-volume-keybinds

  SongSelectV2: Allow adjusting volume by scrolling

  Dean Herbert · 2025-05-13 20:34:33 +09:00
  366e0deefe