72652 Commits

This Branch

This Branch

All Branches

• Merge pull request #32640 from bdach/better-user-tag-ui

  Re-do user tag voting UI to address user complaints

  Dean Herbert · 2025-04-07 22:52:10 +09:00
  3e9ce6cd3c
• Fix crashes in statistics panel test scene
  Bartłomiej Dach · 2025-04-07 14:49:55 +02:00
  9643beafa7
• Close popovers on hiding the statistics view

  Now that the tagging popover is back,
  https://github.com/ppy/osu/issues/32630 actually needs fixing.

  Bartłomiej Dach · 2025-04-07 14:48:26 +02:00
  11e48f9f8e
• Allow tag control popover to attach to bottom too

  Looks bad when trying to tag on a replay otherwise.

  Bartłomiej Dach · 2025-04-07 14:45:38 +02:00
  cded1311c8
• Cache aquamarine colour provider at results screen

  To fix the user tag control.
  
  I would have done it locally to the user tag control, but it was pissing
  me off because I wanted the add button to be aquamarine (as it's closer
  to the accents the screen is already using), but the popover on open was
  for whatever reason purple and I just want consistency where possible.

  Bartłomiej Dach · 2025-04-07 14:39:37 +02:00
  23c711d1bc
• Merge pull request #32678 from bdach/prev-next-weirdness

  Fix weird behaviour when skipping back and forth with shuffle enabled

  Dan Balasescu · 2025-04-07 21:11:16 +09:00
  19f761b125
• Allow multiple in-flight requests
  Dean Herbert · 2025-04-07 20:28:45 +09:00
  b874eea0c5
• Move loading inline to individual tags
  Dean Herbert · 2025-04-07 20:22:49 +09:00
  f8d063a394
• Switch to using a popover again
  Dean Herbert · 2025-04-07 20:14:08 +09:00
  43ee43c9e2
• Disable incorrect cancellation token inspection
  Dean Herbert · 2025-04-07 20:12:49 +09:00
  2dc38b5f09
• Merge pull request #32638 from peppy/fix-slider-repeat-fade

  Fix slider repeat arrow fade in length not matching expectations

  Bartłomiej Dach · 2025-04-07 13:04:06 +02:00
  c921a2362a
• Disable new "duplciated statements" inspection
  Dean Herbert · 2025-04-07 20:00:53 +09:00
  3852cca19a
• Merge pull request #32675 from peppy/disable-scroll-adjust-during-gameplay

  Disallow adjusting scroll speed during gameplay

  Bartłomiej Dach · 2025-04-07 11:05:58 +02:00
  82c52918c8
• Apply review suggestions
  Bartłomiej Dach · 2025-04-07 09:36:53 +02:00
  2d619a3692
• Merge pull request #32681 from smoogipoo/fix-osd-crash

  Fix thread-race leading to `OnScreenDisplay` crash

  Dean Herbert · 2025-04-04 23:52:39 +09:00
  e0154a082e
• Resolve test failures
  Dan Balasescu · 2025-04-04 23:17:16 +09:00
  319e3db14e
• Prevent future misuse
  Dan Balasescu · 2025-04-04 22:48:33 +09:00
  6d51888896
• Fix thread-race leading to OnScreenDisplay crash
  Dan Balasescu · 2025-04-04 22:48:33 +09:00
  abfda9cbcd
• Merge pull request #32676 from peppy/fix-thread-safety-message-notifier

  Fix potential crashes due to asynchronous `BindableList` usage

  Dan Balasescu · 2025-04-04 21:24:07 +09:00
  fe3504279b
• Fix weird behaviour when skipping back and forth with shuffle enabled

  Closes https://github.com/ppy/osu/issues/32590
  
  I didn't think there would come a day where I'd unironically use a
  linked list, but here we are.

  Bartłomiej Dach · 2025-04-04 13:12:30 +02:00
  228d439fce
• Add failing test coverage
  Bartłomiej Dach · 2025-04-04 13:12:24 +02:00
  55129620b8
• Fix potential crashes due to asynchronous BindableList usage

  Band-aid fix for https://github.com/ppy/osu/issues/32671.
  
  Removes all `BindableList.BindTo` from `load()` methods (except one
  editor one which looks safe and is kinda hard to fix without moving
  drawable load to a blocking operation).

  Dean Herbert · 2025-04-04 19:54:47 +09:00
  04f8fcd04f
• Remove obsoleted ScrollTime setting
  Dean Herbert · 2025-04-04 19:46:15 +09:00
  9cdb3fe6ae
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Remove redundant argument list
  Dan Balasescu · 2025-04-04 10:58:29 +09:00
  2df3dfb99c
• Remove unreachable code
  Dan Balasescu · 2025-04-04 10:47:40 +09:00
  db2366b736
• Merge pull request #32662 from peppy/fix-timeout-aborting-import

  Fix batch import failing if one beatmap can't complete difficulty calculation

  Dan Balasescu · 2025-04-04 09:50:35 +09:00
  58411b835c
• Merge pull request #32636 from iamnotcoding/multiple_keys

  Allow users to include or exclude multiple key mods by comma separated values

  Dean Herbert · 2025-04-03 20:39:52 +09:00
  15f8bde433
• Merge pull request #32572 from peppy/storyboard-optimise-noop-alpha-transforms

  Fix storyboards with no-op alpha operations causing extended drawable lifetimes

  Bartłomiej Dach · 2025-04-03 13:15:40 +02:00
  eb6b51b5ee
• Merge pull request #32664 from peppy/fix-metronome-text-display

  Fix metronome BPM text not matching expectations due to custom rounding implementation

  Bartłomiej Dach · 2025-04-03 12:32:32 +02:00
  d1c07b2212
• Merge pull request #32593 from peppy/less-sample-overhead-during-silly-sliders

  Fix stutters when sliders with hundreds of repeats display for the first time

  Bartłomiej Dach · 2025-04-03 12:31:46 +02:00
  f11d3ddb5c
• Remove flow animations

  They don't look great, so let's just get something out which doesn't
  involve things flying everywhere to start with.

  Dean Herbert · 2025-04-03 19:19:34 +09:00
  769e0bd4ff
• Adjust mouse down animation in a better way (and apply to small tag buttons too)
  Dean Herbert · 2025-04-03 19:19:06 +09:00
  2a3241fd48
• Merge branch 'master' into better-user-tag-ui
  Bartłomiej Dach · 2025-04-03 11:59:16 +02:00
  375beae8a9
• Merge pull request #32657 from bdach/ruleset-specific-user-tags

  Add support for ruleset-specific user tags

  Dean Herbert · 2025-04-03 18:58:05 +09:00
  42a7094f9c
• Merge pull request #32601 from sineplusx/median-offset

  Use median instead of mean for average hit error calculations

  Dean Herbert · 2025-04-03 18:56:04 +09:00
  db0811bad9
• Rename some variables
  Dean Herbert · 2025-04-03 18:55:45 +09:00
  332b081603
• Merge pull request #32667 from peppy/fix-argon-reverse-arrow

  Fix argon reverse arrow animating weirdly after hit

  Bartłomiej Dach · 2025-04-03 11:39:52 +02:00
  c993c6ef30
• Add back clamping of animation durations on slider repeat runs
  Dean Herbert · 2025-04-03 18:32:02 +09:00
  6d1fc0e235
• Only show required number of decimal places (and fix final alpha levels)
  Dean Herbert · 2025-04-03 18:17:26 +09:00
  448573449c
• Merge pull request #32666 from bdach/json-ignore-current-playlist-item

  Add `[JsonIgnore]` to `MultiplayerRoom.CurrentPlaylistItem`

  Dean Herbert · 2025-04-03 18:09:51 +09:00
  2de723e27c
• Fix video offset start time regression with StartTime calculation changes
  Dean Herbert · 2025-04-03 18:03:23 +09:00
  102085668f
• Add failing test coverage of regressing video scenario
  Dean Herbert · 2025-04-03 18:02:57 +09:00
  a49f9be243
• Fix argon reverse arrow animating weirdly after hit
  Dean Herbert · 2025-04-03 17:41:13 +09:00
  bb8a9c8345
• Adjust again to be closer to stable
  Dean Herbert · 2025-04-03 17:25:42 +09:00
  4cd2e5ba25
• Add [JsonIgnore] to MultiplayerRoom.CurrentPlaylistItem

  The lack of this is currently failing a unit test on
  `osu-server-spectator` current master:
  
  https://github.com/ppy/osu-server-spectator/actions/runs/14193158383/job/39762243965#step:4:28
  
  I don't think the failure actually matters because I don't think we're
  using json serialisation on spectator server side anywhere (used to for
  iOS at least, but I don't think we do anymore?), but probably better to
  be safe than sorry.

  Bartłomiej Dach · 2025-04-03 10:03:06 +02:00
  9a4371a817
• Merge pull request #32663 from peppy/dont-json-acronyms

  Avoid writing out team acronyms to JSON

  Bartłomiej Dach · 2025-04-03 09:20:18 +02:00
  ea7c4d6c0d
• Remove left-over scheduling thing
  Dean Herbert · 2025-04-03 16:17:29 +09:00
  b471750812
• Merge pull request #32661 from peppy/player-is-a-fuckfest-of-fuck

  Fix letterbox showing above playfield border

  Bartłomiej Dach · 2025-04-03 09:05:12 +02:00
  c57103d980
• Syncrhonise tranforms between arrow and circle pieces
  Dean Herbert · 2025-04-03 15:49:15 +09:00
  f9ceb59d70