6 Commits

Author	SHA1	Message	Date
Dean Herbert	cf633973a9	Refactor exposed mod retrieval methods for better safety	2021-09-10 11:09:13 +09:00
Dean Herbert	b5954a55ad	Remove empty <returns> xmldoc	2021-04-12 17:46:14 +09:00
Bartłomiej Dach	8b74298567	Add base method for testing conversion in other direction	2020-11-15 14:48:23 +01:00
Bartłomiej Dach	9899687bfe	Rename existing method to allow for new one	2020-11-15 14:17:41 +01:00
Dean Herbert	546772192c	Add helper method to convert to legacy mods enums	2020-03-24 13:07:51 +09:00
Bartłomiej Dach	a407e267a2	Fix PF/SD legacy mod conversion ... Upon investigating an user report in #6091 that indicated that viewing replays using the Perfect mod would also display the Sudden Death mod icon despite Perfect being the more restrictive of the two, it turned out that the logic of importing legacy scores was missing that corner case. A similar case of Double Time/Nightcore mutual exclusion was handled, but PF/SD was missed. Add analogous handling of PF/SD legacy mods for all four rulesets, and additionally cover a tiny fraction of all cases with unit tests. The most problematic cases (NC+HD and PF+SD) are covered in all four basic rulesets.	2019-09-15 22:55:25 +02:00