38668 Commits

This Branch

This Branch

All Branches

• Refactor WaveformOpacityMenuItem to not receive whole config
  Dean Herbert · 2021-04-21 18:05:26 +09:00
  c6c91cd9a5
• Factor out pooling and lifetime management logic of DHO to a base class
  ekrctb · 2021-04-21 17:37:42 +09:00
  b877a29737
• Remove SkinReloadableDrawable inheritance from DHO
  ekrctb · 2021-04-21 17:34:57 +09:00
  bbf2ec369b
• Update framework
  Dean Herbert · 2021-04-21 17:27:00 +09:00
  deeb9e3765
• Merge pull request #12486 from ekrctb/unmanaged-hit-object-entry

  Associate DrawableHitObject with HitObjectLifetimeEntry rather than HitObject

  Dan Balasescu · 2021-04-21 17:08:21 +09:00
  cf55383fff
• Merge pull request #12513 from peppy/tablet-rotated-preview

  Show tablet preview with physical tablet counter-rotated for supplied user area

  Dan Balasescu · 2021-04-21 16:46:09 +09:00
  452f282e2c
• Merge branch 'master' into gcc-abstraction
  smoogipoo · 2021-04-21 16:33:36 +09:00
  31c5fb350f
• Rename to MasterGameplayClock
  smoogipoo · 2021-04-21 16:33:14 +09:00
  fb848f7544
• Fix initial rotation not being set
  Dean Herbert · 2021-04-21 16:12:09 +09:00
  ab2a8b5c89
• Show tablet preview with physical tablet counter-rotated for supplied user area selection

  Closes https://github.com/ppy/osu/issues/12399.
  
  Rotation animation is intentionally delayed slightly to give a better sense of what is going on (or maybe just look cool).

  Dean Herbert · 2021-04-21 15:55:15 +09:00
  eb20865c02
• Append "classic" mod to legacy scores
  Salman Ahmed · 2021-04-21 09:16:28 +03:00
  1a715b2926
• Implement "classic" mod for all other legacy rulesets

  Currently empty, automatically handled in game to not be selectable (see `Mod.HasImplementation`)

  Salman Ahmed · 2021-04-21 09:14:33 +03:00
  e3398d8f1f
• Add base "classic" mod
  Salman Ahmed · 2021-04-21 09:14:19 +03:00
  e90d791754
• Deprecate old overload of Apply
  ekrctb · 2021-04-21 14:32:37 +09:00
  3fbeadf318
• Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.

  HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.

  ekrctb · 2021-04-21 11:32:01 +09:00
  73d3da1687
• Merge pull request #12510 from smoogipoo/fix-wiggle-slider-tails

  Fix slider tails wiggling independently

  Dean Herbert · 2021-04-21 11:30:13 +09:00
  6164902eba
• Add to comment
  smoogipoo · 2021-04-21 10:32:13 +09:00
  e454037d82
• Merge pull request #12507 from peppy/fix-cursor-position-rotated

  Fix click-to-resume cursor location being incorrect when playfield is transformed

  Dan Balasescu · 2021-04-21 10:29:35 +09:00
  397df41570
• Fix slider tails wiggling independently
  smoogipoo · 2021-04-21 10:29:18 +09:00
  9d423201ed
• Merge pull request #12506 from peppy/fix-mod-customisation-input-blocking-padding

  Fix mod settings blocking input outside its visible area

  Dan Balasescu · 2021-04-21 10:11:35 +09:00
  be71b383f5
• Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO."

  This reverts commit 67fcfd9d

  ekrctb · 2021-04-21 10:02:50 +09:00
  44ff08cce4
• Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.

  HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.

  ekrctb · 2021-04-21 09:48:16 +09:00
  67fcfd9dbc
• Rename UnmanagedHitObjectEntry -> SyntheticHitObjectEntry

  "Unmanaged" was confusing because its lifetime is still managed by the HitObjectContainer.

  ekrctb · 2021-04-21 09:23:23 +09:00
  e80c3c317a
• Merge branch 'master' into fix-mod-customisation-input-blocking-padding
  Bartłomiej Dach · 2021-04-20 19:41:25 +02:00
  a2afa38a3f
• Fix failing test after mod settings layout changes

  The slight hack which was used in the test to ensure that the mod
  settings overlay covered the entire width of the mod overlay broke after
  adjustments to the layout in the previous commit.
  
  Locally adjust the hack to use the parent of the `ModSettingsContainer`
  rather than the container itself.

  Bartłomiej Dach · 2021-04-20 19:38:25 +02:00
  881043bc5d
• Fix click-to-resume cursor location being incorrect when playfield is transformed

  Closes #12501.

  Dean Herbert · 2021-04-21 00:12:49 +09:00
  4910d8f56c
• Merge pull request #12492 from Naxesss/bg-audio-quality-checks

  Add background and audio checks

  Dean Herbert · 2021-04-21 00:10:32 +09:00
  26430e3cb5
• Fix mod settings blocking input outside its visible area

  Closes #12502.

  Dean Herbert · 2021-04-20 23:42:56 +09:00
  7fc450c620
• Fix potential doubling of events
  smoogipoo · 2021-04-20 21:20:08 +09:00
  4cc3321d54
• Fix potentially starting play when finished

  The UserFinishedPlaying event may trigger before the event is subscribed
  to by SpectatorScreen. For such cases, an extra check is done to make
  sure the user is _actually_ playing.

  smoogipoo · 2021-04-20 21:19:08 +09:00
  a9e4a0ed50
• Merge branch 'master' into fix-initial-spectator-state-callback
  smoogipoo · 2021-04-20 21:16:05 +09:00
  156a518068
• Add xmldoc note about path being relative
  Naxess · 2021-04-20 13:44:06 +02:00
  e9dfa2860a
• Add xmldoc to GetPathForFile
  Naxess · 2021-04-20 13:40:38 +02:00
  d7a81471c8
• Merge pull request #12498 from peppy/barrel-roll-faster-spin

  Allow faster roll speed selection in "Barrel Roll" mod

  Dan Balasescu · 2021-04-20 20:39:45 +09:00
  86772869da
• Merge pull request #12499 from peppy/barrel-roll-keep-numbers-aligned

  Keep hitcircles aligned with view in "Barrel Roll" mod

  Dan Balasescu · 2021-04-20 20:39:17 +09:00
  1edda5878c
• Merge pull request #12497 from peppy/remove-catch-hyperdash-glow-fade

  Remove catcher fade during hyperdash

  Dan Balasescu · 2021-04-20 20:36:17 +09:00
  65efb7ca4e
• Simplify verifier run call args

  Uses the resolved working beatmap instead of resolving it every time.
  
  Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.

  Naxess · 2021-04-20 13:34:12 +02:00
  3e1b6b3b34
• Fix usage of _ in Moq lambdas
  Naxess · 2021-04-20 13:29:14 +02:00
  c0318a4d3e
• Add file hash to file presence test

  Necessary because we now find the storage path of the file rather than just the file itself.

  Naxess · 2021-04-20 13:28:32 +02:00
  6a1e4ff99f
• Fix wrong assert in offscreen test
  Naxess · 2021-04-20 13:21:57 +02:00
  5262d94e21
• Fix tests failing intermittently

  This was due to this code happening in UpdateAfterChildren(), after the
  GCC has processed one frame. During this time, the clock could have
  advanced an arbitrary amount.
  
  The cause of this is the removal of the Task.Run() to set the clock in
  Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
  luck.

  smoogipoo · 2021-04-20 18:41:09 +09:00
  c5d6b6ea8d
• Keep hitcircles aligned with view in "Barrel Roll" mod
  Dean Herbert · 2021-04-20 18:36:11 +09:00
  ac0ed72d04
• Fix storyboard sample test scene
  smoogipoo · 2021-04-20 18:26:30 +09:00
  f144661c31
• Move seekOffset back to MasterGameplayClockContainer
  smoogipoo · 2021-04-20 18:25:46 +09:00
  ec080fcb32
• Allow faster roll speed selection in "Barrel Roll" mod
  Dean Herbert · 2021-04-20 18:22:58 +09:00
  f11b068dee
• Remove catcher fade during hyperdash

  Closes https://github.com/ppy/osu/issues/12472.

  Dean Herbert · 2021-04-20 18:18:51 +09:00
  ddf1b560f3
• Merge pull request #12496 from smoogipoo/fix-pre-seek-sample-lifetime

  Fix storyboard samples not getting a lifetime end if initially seeked past

  Dean Herbert · 2021-04-20 18:07:15 +09:00
  3932f6c3e3
• Seek using local method
  smoogipoo · 2021-04-20 17:40:11 +09:00
  a683e5ec34
• Move clock processing to base.Seek()
  smoogipoo · 2021-04-20 17:35:59 +09:00
  97fb90d9f4
• Fix compile error
  smoogipoo · 2021-04-20 17:27:37 +09:00
  5da18c51a4