Dan Balasescu
7437d21f49
Adjust comment regarding slider tail
2023-12-24 00:45:22 +09:00
Dan Balasescu
ee0bd69e24
Merge pull request #26072 from peppy/fix-migration-hard-crash
...
Fix hard crash when attempting to change folder location during a large import
2023-12-24 00:09:13 +09:00
Dan Balasescu
8b11bcc6ea
Remove unused using
2023-12-24 00:08:15 +09:00
Dan Balasescu
0db2668026
Merge pull request #26069 from peppy/fix-legacy-version-checks
...
Change legacy version checks to account for users specifying incorrect versions
2023-12-24 00:07:01 +09:00
Dan Balasescu
807ea8a9a0
Merge pull request #26082 from bdach/relax-legacy-score-conversion
...
Fix standardised score conversion failing for scores set with 0.0x mod mutliplier
2023-12-24 00:04:10 +09:00
Dan Balasescu
00090bc527
Add combo end bonus to HP
2023-12-23 23:51:12 +09:00
Bartłomiej Dach
fde0276db3
Merge pull request #26077 from peppy/profile-cover-pixel-fix
...
Fix user profile cover showing 1px line when contracted
2023-12-23 15:49:03 +01:00
Bartłomiej Dach
a011a1ebb8
Merge pull request #26080 from peppy/cinema-no-fail
...
Change "cinema" mod to never fail
2023-12-23 15:48:42 +01:00
Dan Balasescu
d1000b2e6c
remove HP density
2023-12-23 23:36:15 +09:00
Bartłomiej Dach
0cbf594a8c
Make cinema mod incompatible with no fail
2023-12-23 15:10:31 +01:00
Bartłomiej Dach
881a91ed69
Merge pull request #26081 from peppy/fix-spectate-users
...
Fix "spectate" button not always being clickable in online users list
2023-12-23 14:52:54 +01:00
Bartłomiej Dach
32d8ee2d0c
Add test coverage
2023-12-23 13:42:19 +01:00
Bartłomiej Dach
3a2ed3677b
Fix standardised score conversion failing for scores set with 0.0x mod mutliplier
...
Closes https://github.com/ppy/osu/issues/26073 .
2023-12-23 13:28:39 +01:00
Dean Herbert
644c981673
Fix "spectate" button not always being clickable in online users list
2023-12-23 21:21:34 +09:00
Dean Herbert
15a9740eb6
Change "cinema" mod to never fail
...
Addresses https://github.com/ppy/osu/discussions/26032 .
2023-12-23 21:12:47 +09:00
Bartłomiej Dach
007ea51e20
Add extra safety against returning negative total score in conversion operation
2023-12-23 13:07:29 +01:00
Dean Herbert
a2e5f62478
Fix user profile cover showing 1px line when contracted
...
Addresses https://github.com/ppy/osu/discussions/26068 .
2023-12-23 21:07:17 +09:00
Dean Herbert
6f11885d4b
Add control to allow changing offset from gameplay
2023-12-23 20:51:30 +09:00
Dean Herbert
7e9522a722
Allow external use of offset text explanation
2023-12-23 20:46:12 +09:00
Dean Herbert
27a9dcc5a1
Add basic hotkey offset adjust support (via existing offset control)
2023-12-23 19:55:05 +09:00
Dean Herbert
8349cb7bbe
Fix hard crash when attempting to change folder location during a large import
...
Closes https://github.com/ppy/osu/issues/26067 .
2023-12-23 17:03:58 +09:00
Dean Herbert
fc56188b95
Merge pull request #26060 from jeenyuhs/adjust_beatmap_length_according_to_rate
...
Adjust BeatmapInfoWedge's beatmap length field according to mod rate
2023-12-23 16:54:40 +09:00
Dean Herbert
9f34dfa2ba
Add missing using statement
2023-12-23 16:25:52 +09:00
Dean Herbert
c5893f245c
Change legacy version checks to account for users specifying incorrect versions
2023-12-23 14:03:45 +09:00
Simon G
01cf4ee15a
add test for length updates
2023-12-22 18:11:37 +01:00
Simon G
3487b5865e
Merge branch 'ppy:master' into adjust_beatmap_length_according_to_rate
2023-12-22 18:08:35 +01:00
Dean Herbert
21e9e103fd
Merge pull request #26039 from smoogipoo/hp-drain-density
...
Add basic density consideration to HP drain
2023-12-23 01:04:53 +09:00
Dean Herbert
32e1b273c2
Merge pull request #26053 from bdach/fix-strict-tracking-sliders
...
Fix strict tracking mod forcefully missing tail before slider start time
2023-12-23 00:03:47 +09:00
Dean Herbert
85c2484ac0
Merge pull request #26041 from bdach/fix-relax-sliders
...
Fix relax mod not considering full follow area radius when automatically holding sliders
2023-12-23 00:01:34 +09:00
Bartłomiej Dach
30553dc7b8
Fix strict tracking mod forcefully missing tail before slider start time
...
Closes https://github.com/ppy/osu/issues/25816 .
Regressed in https://github.com/ppy/osu/pull/25748 .
The reason this broke is that allowing the state of `Tracking` to change
before the slider's start time to support the early hit scenario causes
strict tracking to consider loss of tracking before the slider's start
time as an actual miss, and thus forcefully miss the tail
(see test case in 6cb8231054
2023-12-22 13:43:14 +01:00
Bartłomiej Dach
6cb8231054
Add test coverage for failure case
2023-12-22 13:22:26 +01:00
Bartłomiej Dach
7e557152fb
Fix relax mod not considering full follow area radius when automatically holding sliders
...
Closes https://github.com/ppy/osu/issues/25947 .
Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
`DrawableSliderBall`.
I would have liked to include tests, but relax mod is a bit untestable,
because it disengages completely in the presence of a replay:
7e09164d70/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs (L49-L58)7e09164d70/osu.Game/Rulesets/UI/RulesetInputManager.cs (L116)
2023-12-22 12:50:42 +01:00
Dean Herbert
7e09164d70
Merge pull request #26036 from smoogipoo/fix-perfect-mod-special-judgements
...
Fix perfect mod not failing with special judgements
2023-12-22 18:22:28 +09:00
Dan Balasescu
a0185508b7
Add basic consideration of density for HP drain
2023-12-22 18:08:26 +09:00
Dan Balasescu
5703546d71
Revert change to ModSuddenDeath
2023-12-22 16:43:17 +09:00
Dan Balasescu
88a5ba8167
Add mania/osu sudden death mod tests
2023-12-22 16:43:09 +09:00
Dan Balasescu
93efa98d9b
Fix mania "Great" hits failing with perfect mod
2023-12-22 16:19:36 +09:00
Dan Balasescu
ea778c6e0a
Fix perfect/sudden death not working on slider tails
2023-12-22 14:02:25 +09:00
Dan Balasescu
9c35e25036
Add failing tests
2023-12-22 13:58:12 +09:00
Simon G
b31b9e96d0
adjust beatmap length and drain based on rate changing mods
2023-12-22 03:04:48 +01:00
Dan Balasescu
3f6dad5502
Use classic HP values for non-classic osu! HP drain
2023-12-22 02:16:46 +09:00
Bartłomiej Dach
a7326e3891
Merge pull request #26004 from DanielPower/25049-fix-skin-element-bounding-box
...
Fix scale of skin element bounding box
2023-12-21 18:14:24 +01:00
Dean Herbert
716d866178
Merge pull request #25998 from peppy/add-score-version
...
Add versioning of local scores
2023-12-21 23:58:23 +09:00
Dean Herbert
472a9da6da
Merge pull request #26003 from bdach/big-slider-judgements
...
Fix slider tick / end misses displaying with full size on legacy skins with animated misses
2023-12-21 23:57:36 +09:00
Bartłomiej Dach
b4e71a0787
Fix slider tick / end misses displaying with full size on legacy skins with animated misses
...
Resolves https://github.com/ppy/osu/issues/25987 .
Structure is a bit clumsy but I'm not sure how to do better...
2023-12-21 13:58:12 +01:00
Daniel Power
d4731e0830
Fix scale of skin element bounding box
2023-12-21 08:56:39 -03:30
Bartłomiej Dach
fbf19ea598
Merge branch 'master' into add-score-version
2023-12-21 13:06:53 +01:00
Bartłomiej Dach
5ff95db02c
Add test coverage of ClientVersion serialisation
2023-12-21 13:06:42 +01:00
Bartłomiej Dach
2baf579f7c
Serialise and deserialise ClientVersion to replays
2023-12-21 12:58:08 +01:00
Bartłomiej Dach
81bbdccee7
Rename ScoreInfo.{ -> Client}Version
2023-12-21 12:56:43 +01:00
