Joseph Madamba
3554563114
Fix beatmap info scores container not hiding when there's no leaderboard
2022-05-26 19:50:54 -07:00
Huo Yaoyuan
7cf4dabe29
Fix IDE0005 and IDE0034
2022-05-03 13:09:19 +08:00
Salman Ahmed
be2d616e34
Fix localisation use cases not falling back to default(LocalisableString)
...
Previously such use cases have been returning `null` values just fine since `GetLocalisableString` was returning `LocalisableFormattableString`, and these null values were wrapped in `LocalisableString`s implicitly, therefore not requiring an explicit fallback string and `null` doesn't break anything.
2022-04-28 11:21:00 +03:00
Joseph Madamba
5e5c8e78a6
Use existing web localisation for most hardcoded strings
2022-04-20 16:31:11 -07:00
Dan Balasescu
494955aff1
Resolve inspection issues
2022-04-14 13:11:11 +09:00
Salman Ahmed
b9859f9f21
Obsolete BeatmapInfo.MaxCombo and suppress in usages
2022-03-20 16:30:29 +03:00
Dan Balasescu
f5cd967635
Fix scores not being recalculated in beatmap listing
2022-03-08 19:07:39 +09:00
Dean Herbert
fc1877b6fa
Move to extension method and revert logic to match previous implementation
2022-02-21 13:42:26 +09:00
Dean Herbert
79408f6afc
Add xmldoc and clean up ScoreboardTimeUtils extension methods a touch
2022-02-21 13:30:58 +09:00
dekrain
15ed9ec4fa
Merge scoreboard and leaderboard implementations together
2022-02-19 20:47:02 +01:00
Dean Herbert
b7d8c9bf06
Fix a couple of cases of incorrect equality checks in the case both values are null
2022-01-28 14:29:56 +09:00
Dean Herbert
1b62a685f3
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-18 15:07:59 +09:00
Dean Herbert
51ade3251d
Improve ScoresContainer loading overlay logic to work better with tests
2022-01-17 15:15:39 +09:00
Dean Herbert
88bf406c22
Fix null reference in equality comparison causing beatmap set overlay to crash
2022-01-17 13:05:55 +09:00
Dean Herbert
3811bd8520
Fix some null inspections
2022-01-12 17:00:16 +09:00
Dean Herbert
53792811b2
more fixes (almost compiles, except ruleset and manager)
2022-01-12 16:57:27 +09:00
Dan Balasescu
af9fad00c3
Merge branch 'master' into async-deadlock-safety
2022-01-10 16:11:09 +09:00
Bartłomiej Dach
9e84e31eac
Add score time to beatmap set overlay scoreboard table
2022-01-07 19:18:16 +01:00
Bartłomiej Dach
87f7c7e691
Implement scoreboard-specific time formatting
2022-01-07 19:18:16 +01:00
Bartłomiej Dach
881fa2b86b
Add basic test scene for scoreboard time
2022-01-07 19:18:16 +01:00
Dean Herbert
00177a3ae1
Update usages to new naming
2022-01-06 22:54:43 +09:00
Dean Herbert
3ea7588a91
Update continuation usages to use GetCompletedResult
2022-01-06 22:53:07 +09:00
Dean Herbert
73b40e6833
Replace usage of .Result with .WaitSafelyForResult
2022-01-04 11:51:41 +09:00
Dean Herbert
bf1418bafc
Use OnlineID instead of legacy IDs for equality and lookups
2021-12-10 16:11:48 +09:00
Dean Herbert
183b95cbc2
Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus
...
This variable is used at more than just a set level.
2021-11-24 18:42:49 +09:00
Dean Herbert
0ecf5f201c
Rename User to APIUser and move to correct namespace
2021-11-07 11:26:01 +09:00
Dean Herbert
9f9ef570ee
Also propagate Status in temporary BeatmapInfo usage
2021-11-05 14:44:58 +09:00
Dean Herbert
08d94f864f
Update ScoresContainer to not use ToBeatmapInfo
2021-11-04 17:09:53 +09:00
Dean Herbert
a16c8f1ebc
Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet
2021-10-29 18:50:55 +09:00
Dean Herbert
3f030cebf4
Remove local score copying in GetScoresRequest to allow APIScoreInfo.Beatmap to be APIBeatmap
2021-10-29 14:14:25 +09:00
Dean Herbert
817369903a
Rename API score classes
2021-10-29 13:40:56 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dean Herbert
853cf6feaa
Rename last remaining BeatmapInfo Beatmap usage
2021-10-04 17:35:53 +09:00
smoogipoo
88fc53200e
Refactor
2021-09-01 15:41:52 +09:00
smoogipoo
2de076a74b
Merge branch 'adjust-classic-scoring' into score-ordering
2021-09-01 15:06:55 +09:00
smoogipoo
999386da29
Cleanup
2021-08-31 21:47:49 +09:00
smoogipoo
fee94236de
Fix update-thread pauses
2021-08-31 21:36:31 +09:00
smoogipoo
bfcadcc4ac
Revert some changes
2021-08-31 19:18:01 +09:00
smoogipoo
e19d81c88c
Fix potential incorrect ordering
2021-08-30 19:41:44 +09:00
smoogipoo
458ce250f0
Use new ScoreManager method in ScoreTable
2021-08-30 19:34:12 +09:00
smoogipoo
b217dd1a65
Order scores by score
2021-08-30 19:03:16 +09:00
smoogipoo
47061c0210
Trigger refresh on scoring mode change
2021-08-30 18:57:30 +09:00
Dean Herbert
678386f5c4
Fix missed null coalesce
2021-08-30 16:05:56 +09:00
Salman Ahmed
6aaef7b0be
Handle null PP during score set in TopScoreStatisticsSection
...
Supersedes #14562
Closes #14541
2021-08-29 17:19:17 +03:00
Salman Ahmed
8f3416d853
Assert PP not null when showPerformancePoints is true
2021-08-29 16:03:39 +03:00
Salman Ahmed
e374ef163d
Update localisable formattable extensions usages inline with framework change
2021-08-29 15:00:28 +03:00
Lucas A
19cc4a14a3
Localise top score mods statistics
2021-08-20 09:22:15 +02:00
Lucas A
1f942d15f8
Localise scoreboard
2021-08-16 13:38:57 +02:00
Bartłomiej Dach
239b38a0ab
Reduce implicit conversions by using default
2021-07-27 21:46:29 +02:00
Lucas A
94877117b9
Apply changes in-line with framework changes.
2021-07-27 18:22:47 +02:00
