Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
...
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.
Maybe this is okay?
2024-11-21 20:52:34 +09:00
Dan Balasescu
dc45816566
Fix inspection
2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Dean Herbert
6fba6de4dc
Merge branch 'master' into multiplayer-remove-cmc-and-composite
2024-11-20 17:24:55 +09:00
Dean Herbert
03de518484
Fix missing updateRoomPlaylist call
2024-11-20 16:56:22 +09:00
Dean Herbert
b070a50ac9
Merge pull request #30718 from frenzibyte/initial-key-counter-state
...
Fix key counter not updating activation state on initial load
2024-11-20 15:39:44 +09:00
Bartłomiej Dach
273095fd82
Merge pull request #30757 from peppy/fix-scroll-absolute-pos
...
Fix right click scroll at song select not quite matching scrollbar position
2024-11-19 10:40:00 +01:00
Dean Herbert
a2af4cbb50
Fix right click scroll at song select not quite matching scrollbar position
...
Closes https://github.com/ppy/osu/issues/30744 .
2024-11-18 23:54:56 +09:00
Bartłomiej Dach
259e9ecf65
Deactivate new combo toggle on deselecting objects
...
Closes https://github.com/ppy/osu/issues/30713 .
Was a point of discussion doing review:
https://github.com/ppy/osu/pull/30214#discussion_r1798833139
Given it got pointed out immediately for something so minor, I'm
inclined to believe it's a rather undesirable change.
2024-11-18 15:13:32 +01:00
Salman Alshamrani
b014bfea3e
Fix key counter not updating activation state on initial load
2024-11-17 09:56:19 -05:00
Joseph Madamba
465cc716d3
Add missing source query filter in song select
2024-11-15 22:53:23 -08:00
Dean Herbert
0a1f589c80
Fix black layer not fading fast enough when exiting quickly from quick restart
2024-11-16 11:52:02 +09:00
Bartłomiej Dach
21d407680b
Merge pull request #30623 from peppy/fix-flash-transition-player
...
Fix occasional flash when quick exiting / retrying from player
2024-11-15 08:42:43 +01:00
Dan Balasescu
1a656d0ec3
Remove CachedModelDependencyContainer usages from online play
2024-11-15 15:59:28 +09:00
Dan Balasescu
bfbae9458a
Remove OnlinePlayComposite
2024-11-15 15:59:28 +09:00
Dan Balasescu
34c0f72dd6
Make Room.Playlist non-bindable
2024-11-15 15:51:01 +09:00
Dan Balasescu
b16edbbf52
Make Room.RecentParticipants non-bindable
2024-11-15 15:25:43 +09:00
Dan Balasescu
dc5337d771
Make Room.UserScore non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
c4f8fd1832
Make Room.DifficultyRange non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
487a010b12
Make Room.PlaylistItemStats non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
80b3e330a6
Make Room.ChannelId non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
6c84e425f8
Make Room.MaxAttempts non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
0ceaafe731
Make Room.Duration & Room.StartDate & Room.EndDate non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
89de4f0f87
Make Room.AutoStartDuration non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
b8bae30b66
Make Room.ParticipantCount & Room.MaxParticipants non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
f001cce24a
Make Room.AutoSkip non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
ec5be6dbc3
Make Room.Password & Room.HasPassword non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
198681e644
Make Room.QueueMode non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
7e3e5208f0
Make Room.Availability non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
5d4838a08b
Make Room.Status non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
81e4cb348f
Make Room.Type non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
bde7b8e610
Make Room.Category non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
8694f7e1cc
Make Room.Host non-bindable
2024-11-15 14:42:17 +09:00
Dan Balasescu
6160df1586
Make Room.Name non-bindable
2024-11-15 14:29:15 +09:00
Dean Herbert
1a31e56d4a
Fix double restart call still existing
2024-11-14 23:59:55 +09:00
Bartłomiej Dach
5d3f55fe4d
Fill out xmldoc
2024-11-14 15:05:46 +01:00
Dean Herbert
d1b5d31ea6
Add explicit parameter in
2024-11-14 22:23:42 +09:00
Dean Herbert
3262b6d989
Refactor to avoid dual-boolean mess
2024-11-14 22:10:45 +09:00
Dean Herbert
afeb138ea0
Fix occasional flash when quick exiting / retrying from player
...
The gist of the issue is that `fadeOut` was being called *twice* in the
quick exit/retry scenarios, causing weirdness with transforms.
I've restructured things to ensure it's only called once.
2024-11-14 21:54:34 +09:00
Bartłomiej Dach
bd1d3cad49
Do not show timing distribution graph in offset control if there's not enough timed hits
...
Intended to address concerns raised in
https://github.com/ppy/osu/pull/30620#issuecomment-2475744164 .
2024-11-14 13:17:03 +01:00
Bartłomiej Dach
d08c8ae482
Merge pull request #30620 from peppy/fix-offset-adjust-crash
...
Fix crash when resetting offset after a play with no hit events
2024-11-14 12:43:47 +01:00
Bartłomiej Dach
1355fa636d
Merge pull request #30603 from peppy/quick-restart-faster-better
...
Make quick restart even faster
2024-11-14 12:30:13 +01:00
Dean Herbert
36d48a01c8
Add missing expire call
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-14 19:33:34 +09:00
Dean Herbert
9849a88eef
Adjust transition further to avoid brief "jumpscare" display of metadata
2024-11-14 18:28:27 +09:00
Bartłomiej Dach
88aea70429
Do not permit new combo toggle to remain in indeterminate state on deselect
2024-11-14 10:07:09 +01:00
Bartłomiej Dach
1b279e45cc
Merge branch 'master' into feat/optimize-polygon-tool
2024-11-14 09:54:04 +01:00
Bartłomiej Dach
02e4907fb6
Merge pull request #29896 from OliBomby/hs-toggle2
...
Collapse sample point indicators into dots if they cannot be displayed in full
2024-11-14 08:28:11 +01:00
Dean Herbert
88d220f4c5
Fix crash when resetting offset after a play with no hit events
...
Closes https://github.com/ppy/osu/issues/30573 .
2024-11-14 16:03:15 +09:00
Dean Herbert
7670a81181
Merge branch 'master' into bat-max-performance
2024-11-14 13:35:29 +09:00
Dan Balasescu
85d292ae57
Merge pull request #30602 from peppy/increase-idle-time
...
Increase idle time before gameplay loads when hovering controls
2024-11-13 21:21:23 +09:00
