Joseph Madamba
cab849b5d9
Use web localisable string for team channel label
2025-03-03 14:23:39 -08:00
Bartłomiej Dach
c30f334cf9
Merge pull request #32197 from peppy/zoom-to-centre-always
...
Always zoom timeline to centre rather than focus point
2025-03-03 20:12:28 +01:00
andy840119
23a5d6dc40
This method is not being used anymore.
...
see:
https://github.com/ppy/osu/pull/26643
2025-03-03 22:10:41 +08:00
Bartłomiej Dach
d7d5eec58c
Update failing assertions
...
Change in behaviour is expected in this case.
2025-03-03 13:53:42 +01:00
Bartłomiej Dach
a33e76717c
Merge pull request #32135 from zihadmahiuddin/fix/settings-show-at-visibility
...
Fix settings control not visible because of previous search
2025-03-03 13:29:26 +01:00
Bartłomiej Dach
bf4fa58f72
Fix playlists results screens potentially displaying negative score positions
...
Closes https://github.com/ppy/osu/issues/31434 .
2025-03-03 13:20:42 +01:00
Bartłomiej Dach
28f9e734f0
Add failing test case
2025-03-03 12:32:27 +01:00
Dean Herbert
6aaec144c8
Merge pull request #32162 from nekodex/kiai-sfx
...
Add SFX for kiai/star fountain activation
2025-03-03 19:05:05 +09:00
Dean Herbert
f32a8e8741
Update resources
2025-03-03 18:54:46 +09:00
Dean Herbert
52860def6c
Always zoom timeline to centre rather than focus point
...
Closes https://github.com/ppy/osu/issues/32183 .
2025-03-03 18:53:41 +09:00
Bartłomiej Dach
87fb8da351
Fix drain length calculation helper method being able to return negative durations
...
This is the principal failure behind
https://github.com/ppy/osu-server-beatmap-submission/issues/40 .
2025-03-03 09:35:46 +01:00
Bartłomiej Dach
0a50fb1dfa
Add failing test case
2025-03-03 09:32:27 +01:00
Bartłomiej Dach
47747aed3e
Add guards to prevent clamp calls with invalid bounds
2025-03-03 08:40:51 +01:00
Dan Balasescu
9c28ac4a72
Merge pull request #32152 from peppy/song-select-v2-test
...
Make `TestSceneSongSelect` work with local database
2025-03-03 16:21:11 +09:00
Bartłomiej Dach
8539745667
Merge pull request #32153 from peppy/carousel-design-fixes
...
Apply first wave blanket fixes to new beatmap carousel design
2025-03-03 08:13:43 +01:00
Dean Herbert
8b04b75d27
Merge pull request #32192 from smoogipoo/more-beatmap-load-cancellations
...
Cancel beatmap load in more loops
2025-03-03 16:10:06 +09:00
Dan Balasescu
033952029e
Cancel ApplyDefaults() when requested
...
Also didn't notice a particular case here, but if all code passes up
until we get to the `foreach (var h in nestedHitObjects)` below, then we
could end up stuck here for quite a while.
2025-03-03 14:46:13 +09:00
Dan Balasescu
52dad09b20
Cancel slider generation when requested
...
Didn't notice a particular case with this one, just came up as I was
looking through code.
2025-03-03 14:19:43 +09:00
Dan Balasescu
ad9a963bd0
Exit loop when cancellation requested
...
The following manages to create all hitobjects but proceeds to get stuck
in this method:
`dotnet run -- difficulty 1607040 -r:2`
2025-03-03 14:19:19 +09:00
Giovanni D.
35a21b44a6
Change timing of the flash
2025-03-02 20:43:32 -08:00
Giovanni D.
ec6ff240f3
Add taskbar flashing when a multiplayer game is starting
2025-03-02 00:49:04 -08:00
Jamie Taylor
881534eb7f
Add SFX for kiai/star fountain activation
2025-03-01 01:51:37 +09:00
Dean Herbert
38de3566b1
Adjust set panel display and animations slightly
2025-02-28 22:54:00 +09:00
Dean Herbert
4beac64bdb
Remove unused container level
2025-02-28 22:54:00 +09:00
Dean Herbert
29c35529d2
Fix activation flash being applied twice (and adjust duration)
2025-02-28 22:54:00 +09:00
Dean Herbert
8032b68932
Stop using padding for panel x offsets
2025-02-28 22:54:00 +09:00
Zihad
0d7c00ae09
use Bindable.SetDefault for clearing search text
2025-02-28 19:04:47 +06:00
Zihad
88089fb014
make SettingsPanel.SearchTextBox's setter private
2025-02-28 19:03:39 +06:00
Bartłomiej Dach
35b0ff80bb
Mark MathHelper.Clamp() as banned API
...
See previous commit for partial rationale.
There's an argument to be made about the `NaN`-spreading semantics being
desirable because at least something will loudly fail in that case, but
I'm not so sure about that these days. It feels like either way if
`NaN`s are produced, then things are outside of any control, and chances
are the game can probably continue without crashing. And, this move
reduces our dependence on osuTK, which has already been living on
borrowed time for years now and is only awaiting someone brave to go
excise it.
2025-02-28 13:48:22 +01:00
Bartłomiej Dach
ffef6ae185
Fix possible crash when scaling objects in editor
...
The specific fail case here is when `s.{X,Y}` is 0, and
`s{Lower,Upper}Bound` is `Infinity`. Because IEEE math is IEEE math,
`0 * Infinity` is `NaN`.
`MathHelper.Clamp()` is written the following way:
af742f1afd/src/osuTK/Math/MathHelper.cs (L284-L306)https://learn.microsoft.com/en-us/dotnet/api/system.math.min?view=net-8.0#system-math-min(system-single-system-single)
https://learn.microsoft.com/en-us/dotnet/api/system.math.max?view=net-8.0#system-math-max(system-single-system-single)
which means that if a `NaN` happens to sneak into the bounds, it will
start spreading outwards in an uncontrolled manner, and likely crash
things.
In contrast, the standard library provided `Math.Clamp()` is written
like so:
577c36cee5/src/libraries/System.Private.CoreLib/src/System/Math.cs (L711-L729)
2025-02-28 13:34:00 +01:00
Bartłomiej Dach
c4e37a1566
Merge pull request #32109 from smoogipoo/results-beatmap-lookup
...
Fix multiplayer results screen displaying same beatmap for all users
2025-02-28 12:36:28 +01:00
Dan Balasescu
993473c081
Pass through artist/title in beatmap transform
2025-02-28 18:40:54 +09:00
Dean Herbert
8fc744e9dc
Make TestSceneSongSelect work with local database
...
It was pointless before.
2025-02-28 17:55:21 +09:00
Dean Herbert
0e257038e8
Fix status pills displaying wrong
2025-02-28 16:47:57 +09:00
Dean Herbert
51cb0bea1c
Fix carousel taking up too much space on new song select implementation
2025-02-28 16:45:49 +09:00
Dean Herbert
1e46dc6b0a
Adjust animation duration to roughly match scroll operations
...
Previous value felt wrong when using keyboard selection for iteration.
2025-02-28 16:27:42 +09:00
Dean Herbert
a8fbac0f0d
Add better selection visibility via another tint layer
2025-02-28 16:27:18 +09:00
Dan Balasescu
89b6d7caee
Merge pull request #32149 from peppy/preview-time-display
...
Adjust preview time display to not conflict with bookmarks
2025-02-28 16:14:44 +09:00
Dean Herbert
02b950223c
Adjust x offsets to work again for keyboard selection
2025-02-28 16:08:11 +09:00
Dan Balasescu
f9c73e6501
Merge pull request #32151 from peppy/mania-barline
...
Add support for legacy osu!mania barline height and colour spec
2025-02-28 16:05:47 +09:00
Dan Balasescu
a09ef5d96d
Fix API room host not being populated
2025-02-28 15:52:02 +09:00
Dan Balasescu
306b30cb12
Add failing test
2025-02-28 15:51:54 +09:00
Dean Herbert
cb29459a1e
Add support for legacy osu!mania barline height and colour spec
2025-02-28 15:13:13 +09:00
Dean Herbert
3e8dafa3c5
Add basic setup for mania legacy barline implementation
2025-02-28 14:43:00 +09:00
Dean Herbert
e1723ec1bb
Adjust preview time display to not conflict with bookmarks
2025-02-28 14:05:49 +09:00
Dean Herbert
a659936c57
Inline some methods
2025-02-28 13:25:21 +09:00
Zihad
0913174099
Fix settings control not visible because of previous search
...
This also makes `SettingsPanel`'s `SearchTextBox` protected from private so that `SettingsOverlay` can access it.
2025-02-28 00:24:12 +06:00
Dean Herbert
7f99e60cfd
Merge pull request #32130 from bdach/fix-sliders-visible-but-not-selectable-harder
2025-02-28 00:38:03 +09:00
Bartłomiej Dach
5b318edbfb
Fix sliders not being selectable if the body is hidden but the head is still visible
...
Closes https://github.com/ppy/osu/issues/31998 .
Previously: 1648f2efa3https://github.com/ppy/osu/pull/31923 .
Oh input handling, how I love ya.
2025-02-27 15:00:29 +01:00
Bartłomiej Dach
79b737bc27
Merge pull request #32110 from bdach/combo-colour-count-limit
...
Limit number of allowed beatmap combo colours to 8
2025-02-27 12:13:06 +01:00
